[v3,2/3] usb/gadget: Add an EP dispose() callback for EP lifetime tracking

[v3,2/3] usb/gadget: Add an EP dispose() callback for EP lifetime tracking

[Benjamin Herrenschmidt]

Some UDC may want to allocate endpoints dynamically, either because
the HW supports an arbitrary large number or because (like the Aspeed
BMC SoCs), the pool of HW endpoints is shared between multiple gadgets.

The allocation side can be done rather easily using the existing
match_ep() UDC hook.

However we have no good place to "free" them.

This implements a "simple" variant of this, which calls an EP dispose
callback on all EPs associated with a gadget when the composite device
gets unbound.

This is required by my upcoming Aspeed vHub driver.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 drivers/usb/gadget/composite.c | 8 ++++++++
 include/linux/usb/gadget.h     | 1 +
 2 files changed, 9 insertions(+)

diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 77c7ecca816a..ec99c9cfc1a2 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -2172,6 +2172,7 @@ int composite_os_desc_req_prepare(struct usb_composite_dev *cdev,
 void composite_dev_cleanup(struct usb_composite_dev *cdev)
 {
 	struct usb_gadget_string_container *uc, *tmp;
+	struct usb_ep			   *ep, *tmp_ep;
 
 	list_for_each_entry_safe(uc, tmp, &cdev->gstrings, list) {
 		list_del(&uc->list);
@@ -2193,6 +2194,13 @@ void composite_dev_cleanup(struct usb_composite_dev *cdev)
 	}
 	cdev->next_string_id = 0;
 	device_remove_file(&cdev->gadget->dev, &dev_attr_suspended);
+
+	/* Dispose EPs if the UDC driver tracks lifetime */
+	list_for_each_entry_safe(ep, tmp_ep,
+				 &cdev->gadget->ep_list, ep_list) {
+		if (ep->ops->dispose)
+			ep->ops->dispose(ep);
+	}
 }
 
 static int composite_bind(struct usb_gadget *gadget,
diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
index 66a5cff7ee14..e3424234b23a 100644
--- a/include/linux/usb/gadget.h
+++ b/include/linux/usb/gadget.h
@@ -129,6 +129,7 @@ struct usb_ep_ops {
 	int (*enable) (struct usb_ep *ep,
 		const struct usb_endpoint_descriptor *desc);
 	int (*disable) (struct usb_ep *ep);
+	void (*dispose) (struct usb_ep *ep);
 
 	struct usb_request *(*alloc_request) (struct usb_ep *ep,
 		gfp_t gfp_flags);

[v3,2/3] usb/gadget: Add an EP dispose() callback for EP lifetime tracking

[Greg KH]

On Fri, Jan 12, 2018 at 05:50:03PM +1100, Benjamin Herrenschmidt wrote:
> Some UDC may want to allocate endpoints dynamically, either because
> the HW supports an arbitrary large number or because (like the Aspeed
> BMC SoCs), the pool of HW endpoints is shared between multiple gadgets.
> 
> The allocation side can be done rather easily using the existing
> match_ep() UDC hook.
> 
> However we have no good place to "free" them.
> 
> This implements a "simple" variant of this, which calls an EP dispose
> callback on all EPs associated with a gadget when the composite device
> gets unbound.
> 
> This is required by my upcoming Aspeed vHub driver.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>  drivers/usb/gadget/composite.c | 8 ++++++++
>  include/linux/usb/gadget.h     | 1 +
>  2 files changed, 9 insertions(+)

Any reason you aren't sending these to the maintainer of the usb gadget
subsystem?  get_maintainer.pl is your friend :)

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v3,2/3] usb/gadget: Add an EP dispose() callback for EP lifetime tracking

[Benjamin Herrenschmidt]

On Mon, 2018-01-22 at 15:33 +0100, Greg KH wrote:
> On Fri, Jan 12, 2018 at 05:50:03PM +1100, Benjamin Herrenschmidt wrote:
> > Some UDC may want to allocate endpoints dynamically, either because
> > the HW supports an arbitrary large number or because (like the Aspeed
> > BMC SoCs), the pool of HW endpoints is shared between multiple gadgets.
> > 
> > The allocation side can be done rather easily using the existing
> > match_ep() UDC hook.
> > 
> > However we have no good place to "free" them.
> > 
> > This implements a "simple" variant of this, which calls an EP dispose
> > callback on all EPs associated with a gadget when the composite device
> > gets unbound.
> > 
> > This is required by my upcoming Aspeed vHub driver.
> > 
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> >  drivers/usb/gadget/composite.c | 8 ++++++++
> >  include/linux/usb/gadget.h     | 1 +
> >  2 files changed, 9 insertions(+)
> 
> Any reason you aren't sending these to the maintainer of the usb gadget
> subsystem?  get_maintainer.pl is your friend :)

Ooops, forgot to CC Felipe, I suppose I assumed he follows the list.

I'll resend them. He saw earlier versions, he proposed a different
approach to solve the lifetime tracking that I very strongly disagreed
with, but he didn't reply to that last email back in the day..

Cheers,
Ben.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html