From: Dan Williams <dcbw@redhat.com>
To: Johan Hovold <johan@kernel.org>,
Kristian Evensen <kristian.evensen@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: option: Add support for Quectel EP06
Date: Wed, 31 Jan 2018 16:32:06 -0600 [thread overview]
Message-ID: <1517437926.20308.1.camel@redhat.com> (raw)
On Thu, 2018-02-01 at 09:17 +1100, Johan Hovold wrote:
> On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote:
> > Hi Johan,
> >
> > On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold <johan@kernel.org>
> > wrote:
> > > This will probably have to do for now, but we already have
> > > another
> > > blacklist struct with the same content which we could rename and
> > > reuse.
> >
> > I noticed the same, but wasn't quite sure about the policy on
> > renaming/recycling and added a new blacklist entry. I can rename
> > the
> > entry and update references as part of this commit. What would be
> > an
> > appropriate name, something straight-forward like
> > "net_intf4_intf5_blacklist"?
>
> Yeah, the policy isn't entirely clear to me either. ;) The
> net_blacklist
> are used to blacklist a single network interface, but here the other
> interface was used for ADB and for the other driver it was for an
> audio
> interface I think.
When I added/consolidated this feature a long time back I didn't think
we'd end up with as many common entries as we have. I think it's fine
to re-use use a common entry, but if you do and the common entry is
named after a vendor/model, then make it generic.
Dan
> You can just add the duplicate entry for now and if this comes up
> again,
> we'll figure out a new (naming) policy.
>
> Thanks,
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-01-31 22:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 22:32 Dan Williams [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-02-09 5:56 option: Add support for Quectel EP06 Johan Hovold
2018-02-04 18:24 Bjørn Mork
2018-02-04 1:42 Johan Hovold
2018-01-31 22:35 Dan Williams
2018-01-31 22:17 Johan Hovold
2018-01-31 8:56 Kristian Evensen
2018-01-31 6:38 Johan Hovold
2018-01-30 14:06 Kristian Evensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517437926.20308.1.camel@redhat.com \
--to=dcbw@redhat.com \
--cc=johan@kernel.org \
--cc=kristian.evensen@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).