* [1/1] usb: host: ehci: use correct device pointer for dma ops
@ 2018-02-01 4:26 Peter Chen
0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2018-02-01 4:26 UTC (permalink / raw)
To: gregkh, stern; +Cc: linux-usb, linux-imx, Peter Chen
commit a8c06e407ef9 ("usb: separate out sysdev pointer from usb_bus")
converted to use hcd->self.sysdev for DMA operations instead of
hcd->self.controller, but forgot to do it for hcd test mode. Replace
the correct one in this commit.
Fixes: a8c06e407ef9 ("usb: separate out sysdev pointer from usb_bus")
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/usb/host/ehci-hub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
index facafdf..d7641cb 100644
--- a/drivers/usb/host/ehci-hub.c
+++ b/drivers/usb/host/ehci-hub.c
@@ -774,12 +774,12 @@ static struct urb *request_single_step_set_feature_urb(
atomic_inc(&urb->use_count);
atomic_inc(&urb->dev->urbnum);
urb->setup_dma = dma_map_single(
- hcd->self.controller,
+ hcd->self.sysdev,
urb->setup_packet,
sizeof(struct usb_ctrlrequest),
DMA_TO_DEVICE);
urb->transfer_dma = dma_map_single(
- hcd->self.controller,
+ hcd->self.sysdev,
urb->transfer_buffer,
urb->transfer_buffer_length,
DMA_FROM_DEVICE);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [1/1] usb: host: ehci: use correct device pointer for dma ops
@ 2018-02-01 19:25 Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2018-02-01 19:25 UTC (permalink / raw)
To: Peter Chen; +Cc: gregkh, linux-usb, linux-imx, Peter Chen
On Thu, 1 Feb 2018, Peter Chen wrote:
> commit a8c06e407ef9 ("usb: separate out sysdev pointer from usb_bus")
> converted to use hcd->self.sysdev for DMA operations instead of
> hcd->self.controller, but forgot to do it for hcd test mode. Replace
> the correct one in this commit.
>
> Fixes: a8c06e407ef9 ("usb: separate out sysdev pointer from usb_bus")
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/usb/host/ehci-hub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> index facafdf..d7641cb 100644
> --- a/drivers/usb/host/ehci-hub.c
> +++ b/drivers/usb/host/ehci-hub.c
> @@ -774,12 +774,12 @@ static struct urb *request_single_step_set_feature_urb(
> atomic_inc(&urb->use_count);
> atomic_inc(&urb->dev->urbnum);
> urb->setup_dma = dma_map_single(
> - hcd->self.controller,
> + hcd->self.sysdev,
> urb->setup_packet,
> sizeof(struct usb_ctrlrequest),
> DMA_TO_DEVICE);
> urb->transfer_dma = dma_map_single(
> - hcd->self.controller,
> + hcd->self.sysdev,
> urb->transfer_buffer,
> urb->transfer_buffer_length,
> DMA_FROM_DEVICE);
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-01 19:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-01 4:26 [1/1] usb: host: ehci: use correct device pointer for dma ops Peter Chen
-- strict thread matches above, loose matches on Subject: below --
2018-02-01 19:25 Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).