* [v2] usb: phy: mxs: Staticize mxs_charger_secondary_detection()
@ 2018-02-12 2:24 Fabio Estevam
0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2018-02-12 2:24 UTC (permalink / raw)
To: balbi; +Cc: peter.chen, linux-usb, jun.li, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
mxs_charger_secondary_detection() is only used in this file, so make
it static.
This fixes the following sparse warning:
drivers/usb/phy/phy-mxs-usb.c:581:23: warning: symbol 'mxs_charger_secondary_detection' was not declared. Should it be static?
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Changes since v1:
- Fix typo in teh Subject (Staticize)
drivers/usb/phy/phy-mxs-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index da031c4..67371a2 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy-mxs-usb.c
@@ -578,7 +578,7 @@ static enum usb_charger_type mxs_charger_primary_detection(struct mxs_phy *x)
* It must be called after DP is pulled up, which is used to
* differentiate DCP and CDP.
*/
-enum usb_charger_type mxs_charger_secondary_detection(struct mxs_phy *x)
+static enum usb_charger_type mxs_charger_secondary_detection(struct mxs_phy *x)
{
struct regmap *regmap = x->regmap_anatop;
int val;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [v2] usb: phy: mxs: Staticize mxs_charger_secondary_detection()
@ 2018-02-12 3:14 Jun Li
0 siblings, 0 replies; 2+ messages in thread
From: Jun Li @ 2018-02-12 3:14 UTC (permalink / raw)
To: Fabio Estevam, balbi@kernel.org
Cc: Peter Chen, linux-usb@vger.kernel.org, Fabio Estevam
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: 2018年2月12日 10:24
> To: balbi@kernel.org
> Cc: Peter Chen <peter.chen@nxp.com>; linux-usb@vger.kernel.org; Jun Li
> <jun.li@nxp.com>; Fabio Estevam <fabio.estevam@nxp.com>
> Subject: [PATCH v2] usb: phy: mxs: Staticize
> mxs_charger_secondary_detection()
>
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> mxs_charger_secondary_detection() is only used in this file, so make it
> static.
>
> This fixes the following sparse warning:
>
> drivers/usb/phy/phy-mxs-usb.c:581:23: warning: symbol
> 'mxs_charger_secondary_detection' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Changes since v1:
> - Fix typo in teh Subject (Staticize)
>
> drivers/usb/phy/phy-mxs-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> index da031c4..67371a2 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/drivers/usb/phy/phy-mxs-usb.c
> @@ -578,7 +578,7 @@ static enum usb_charger_type
> mxs_charger_primary_detection(struct mxs_phy *x)
> * It must be called after DP is pulled up, which is used to
> * differentiate DCP and CDP.
> */
> -enum usb_charger_type mxs_charger_secondary_detection(struct mxs_phy
> *x)
> +static enum usb_charger_type mxs_charger_secondary_detection(struct
> +mxs_phy *x)
> {
> struct regmap *regmap = x->regmap_anatop;
> int val;
> --
> 2.7.4
Acked-by: Jun Li <jun.li@nxp.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-12 3:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-12 2:24 [v2] usb: phy: mxs: Staticize mxs_charger_secondary_detection() Fabio Estevam
-- strict thread matches above, loose matches on Subject: below --
2018-02-12 3:14 Jun Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).