From: Roger Quadros <rogerq@ti.com>
To: balbi@kernel.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Roger Quadros <rogerq@ti.com>
Subject: usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume
Date: Tue, 27 Feb 2018 13:22:06 +0200 [thread overview]
Message-ID: <1519730526-22274-1-git-send-email-rogerq@ti.com> (raw)
In the following test we get stuck by sleeping forever in _dwc3_set_mode()
after which dual-role switching doesn't work.
On dra7-evm's dual-role port,
- Load g_zero gadget driver and enumerate to host
- suspend to mem
- disconnect USB cable to host and connect otg cable with Pen drive in it.
- resume system
- we sleep indefinitely in _dwc3_set_mode due to.
dwc3_gadget_exit()->usb_del_gadget_udc()->udc_stop()->
dwc3_gadget_stop()->wait_event_lock_irq()
Let's clear the DWC3_EP_END_TRANSFER_PENDING flag on all endpoints
so we don't wait in dwc3_gadget_stop().
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/usb/dwc3/gadget.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 2bda4eb..0a360da 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -3273,6 +3273,20 @@ int dwc3_gadget_init(struct dwc3 *dwc)
void dwc3_gadget_exit(struct dwc3 *dwc)
{
+ int epnum;
+ unsigned long flags;
+
+ spin_lock_irqsave(&dwc->lock, flags);
+ for (epnum = 2; epnum < DWC3_ENDPOINTS_NUM; epnum++) {
+ struct dwc3_ep *dep = dwc->eps[epnum];
+
+ if (!dep)
+ continue;
+
+ dep->flags &= ~DWC3_EP_END_TRANSFER_PENDING;
+ }
+ spin_unlock_irqrestore(&dwc->lock, flags);
+
usb_del_gadget_udc(&dwc->gadget);
dwc3_gadget_free_endpoints(dwc);
dma_free_coherent(dwc->sysdev, DWC3_BOUNCE_SIZE, dwc->bounce,
next reply other threads:[~2018-02-27 11:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 11:22 Roger Quadros [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-02-28 3:04 usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume Baolin Wang
2018-02-28 7:53 Felipe Balbi
2018-02-28 9:55 Roger Quadros
2018-02-28 9:59 Roger Quadros
2018-03-05 8:49 Felipe Balbi
2018-03-05 9:45 Roger Quadros
2018-03-05 10:41 Baolin Wang
2018-03-05 11:03 Roger Quadros
2018-03-05 11:06 Felipe Balbi
2018-03-05 11:14 Roger Quadros
2018-03-05 11:25 Baolin Wang
2018-03-05 11:25 Felipe Balbi
2018-03-05 11:27 Felipe Balbi
2018-03-09 9:19 Roger Quadros
2018-03-09 9:23 Felipe Balbi
2018-03-09 9:26 Roger Quadros
2018-03-09 9:49 Roger Quadros
2018-03-09 10:36 Felipe Balbi
2018-03-09 10:39 Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519730526-22274-1-git-send-email-rogerq@ti.com \
--to=rogerq@ti.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).