From: Oliver Neukum <oneukum@suse.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
'Linux Samsung SOC' <linux-samsung-soc@vger.kernel.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
netdev@vger.kernel.org, Dean Jenkins <Dean_Jenkins@mentor.com>
Subject: inconsistent lock state with usbnet/asix usb ethernet and xhci
Date: Mon, 05 Mar 2018 12:46:07 +0100 [thread overview]
Message-ID: <1520250367.3990.9.camel@suse.com> (raw)
On Mon, 2018-03-05 at 08:45 +0100, Marek Szyprowski wrote:
> Hi Oliver,
>
> On 2018-02-27 17:07, Oliver Neukum wrote:
> > Am Dienstag, den 27.02.2018, 07:13 -0800 schrieb Eric Dumazet:
> >> On Tue, 2018-02-27 at 07:09 -0800, Eric Dumazet wrote:
> >>>
> >>> Note that for this one, it seems we also could perform stats updates in
> >>> BH context, since skb is queued via defer_bh()
> >>>
> >>> But simplicity wins I guess.
> >> Thinking more about this, I am not sure we have any guarantee that TX
> >> and RX can not run on multiple cpus.
> >>
> >> Using an unique syncp is not going to be safe, even if we make lockdep
> >> happy enough with the local_irq save/restore.
> > Unfortunately you are right. It is not guaranteed for some hardware.
>
> Does it mean that the fix proposed by Eric is not the proper solution?
For asix it should work, but asix is unlikely to be the only driver
with that issue. 32 bit recieves less testing nowadays.
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-03-05 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 11:46 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-03-05 19:09 inconsistent lock state with usbnet/asix usb ethernet and xhci Eric Dumazet
2018-03-05 7:45 Marek Szyprowski
2018-02-27 16:07 Oliver Neukum
2018-02-27 15:13 Eric Dumazet
2018-02-27 15:09 Eric Dumazet
2018-02-27 14:42 Marek Szyprowski
2018-02-27 14:07 Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520250367.3990.9.camel@suse.com \
--to=oneukum@suse.com \
--cc=Dean_Jenkins@mentor.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).