linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Felipe Balbi <balbi@kernel.org>, linux-usb@vger.kernel.org
Cc: Greg KH <greg@kroah.com>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@aj.id.au>
Subject: [v4,2/2] usb/gadget: Add driver for Aspeed SoC virtual hub
Date: Fri, 16 Mar 2018 11:40:04 +1100	[thread overview]
Message-ID: <1521160804.16434.177.camel@kernel.crashing.org> (raw)

On Thu, 2018-03-15 at 08:03 +1100, Benjamin Herrenschmidt wrote:
> > > Do you have more comments for the rest of the driver or that's it ?
> > 
> > so far, that's it.
> 
> Ok. I'll re-send.

So I'll resend in a minute, doing a few more tests, however, I've
noticed something which I wont' have time to track down til at
best next week, I wonder if it's normal/expected.

If I just create a mass storage function set to be "removable" and
"cdrom" with no file attached,  and enable it, I get an endless stream
of resets. It looks like the host constantly does USB resets.

I suspect the host is sending SCSI commands that fail and resets
as a result, but that's spamming both logs and is rather ... sub
optimal.

Do we know what's going on ? Is this just TEST_UNIT_READY or some other
media check ? Or are we missing some commands we should actually
implement in the mass storage gadget ?

Cheers,
Ben.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-03-16  0:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16  0:40 Benjamin Herrenschmidt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-03-20  4:36 [v4,2/2] usb/gadget: Add driver for Aspeed SoC virtual hub Benjamin Herrenschmidt
2018-03-17 13:50 Alan Stern
2018-03-17  0:40 Benjamin Herrenschmidt
2018-03-17  0:38 Benjamin Herrenschmidt
2018-03-17  0:29 Benjamin Herrenschmidt
2018-03-16 20:56 Alan Stern
2018-03-16  7:23 Felipe Balbi
2018-03-14 21:03 Benjamin Herrenschmidt
2018-03-14  8:54 Felipe Balbi
2018-03-14  3:53 Benjamin Herrenschmidt
2018-03-12 22:35 Benjamin Herrenschmidt
2018-03-09  9:20 Felipe Balbi
2018-01-26  0:01 Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521160804.16434.177.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=andrew@aj.id.au \
    --cc=balbi@kernel.org \
    --cc=greg@kroah.com \
    --cc=joel@jms.id.au \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).