linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-usb@vger.kernel.org,
	Felipe Balbi <balbi@kernel.org>, Greg KH <greg@kroah.com>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Subject: [v5,2/2] usb/gadget: Add driver for Aspeed SoC virtual hub
Date: Sat, 17 Mar 2018 11:05:58 +1100	[thread overview]
Message-ID: <1521245158.16434.195.camel@kernel.crashing.org> (raw)

On Sat, 2018-03-17 at 03:29 +0800, kbuild test robot wrote:
> Hi Benjamin,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on v4.16-rc4]
> [also build test ERROR on next-20180316]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

Wow, interesting, but it looks like a false positive, or am I missing
something ?


> url:    https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/usb-gadget-Add-an-EP-dispose-callback-for-EP-lifetime-tracking/20180317-004216
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from arch/x86/include/asm/page_32.h:35:0,
>                     from arch/x86/include/asm/page.h:14,
>                     from arch/x86/include/asm/thread_info.h:12,
>                     from include/linux/thread_info.h:38,
>                     from arch/x86/include/asm/preempt.h:7,
>                     from include/linux/preempt.h:81,
>                     from include/linux/spinlock.h:51,
>                     from include/linux/seqlock.h:36,
>                     from include/linux/time.h:6,
>                     from include/linux/stat.h:19,
>                     from include/linux/module.h:10,
>                     from drivers/usb/gadget/udc/aspeed-vhub/hub.c:16:
>    In function 'memcpy',
>        inlined from 'ast_vhub_rep_desc' at drivers/usb/gadget/udc/aspeed-vhub/hub.c:276:2:
> > > include/linux/string.h:341:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter
> 
>        __read_overflow2();
>        ^~~~~~~~~~~~~~~~~~
> 
> vim +/__read_overflow2 +341 include/linux/string.h
> 
> 6974f0c4 Daniel Micay 2017-07-12  332  
> 6974f0c4 Daniel Micay 2017-07-12  333  __FORTIFY_INLINE void *memcpy(void *p, const void *q, __kernel_size_t size)
> 6974f0c4 Daniel Micay 2017-07-12  334  {
> 6974f0c4 Daniel Micay 2017-07-12  335  	size_t p_size = __builtin_object_size(p, 0);
> 6974f0c4 Daniel Micay 2017-07-12  336  	size_t q_size = __builtin_object_size(q, 0);
> 6974f0c4 Daniel Micay 2017-07-12  337  	if (__builtin_constant_p(size)) {
> 6974f0c4 Daniel Micay 2017-07-12  338  		if (p_size < size)
> 6974f0c4 Daniel Micay 2017-07-12  339  			__write_overflow();
> 6974f0c4 Daniel Micay 2017-07-12  340  		if (q_size < size)
> 6974f0c4 Daniel Micay 2017-07-12 @341  			__read_overflow2();
> 6974f0c4 Daniel Micay 2017-07-12  342  	}
> 6974f0c4 Daniel Micay 2017-07-12  343  	if (p_size < size || q_size < size)
> 6974f0c4 Daniel Micay 2017-07-12  344  		fortify_panic(__func__);
> 6974f0c4 Daniel Micay 2017-07-12  345  	return __builtin_memcpy(p, q, size);
> 6974f0c4 Daniel Micay 2017-07-12  346  }
> 6974f0c4 Daniel Micay 2017-07-12  347  
> 
> :::::: The code at line 341 was first introduced by commit
> :::::: 6974f0c4555e285ab217cee58b6e874f776ff409 include/linux/string.h: add the option of fortified string.h functions
> 
> :::::: TO: Daniel Micay <danielmicay@gmail.com>
> :::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-03-17  0:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-17  0:05 Benjamin Herrenschmidt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-03-20  4:37 [v5,2/2] usb/gadget: Add driver for Aspeed SoC virtual hub Benjamin Herrenschmidt
2018-03-17  7:35 kbuild test robot
2018-03-17  0:07 Benjamin Herrenschmidt
2018-03-16 20:29 kbuild test robot
2018-03-16 19:29 kbuild test robot
2018-03-16  0:44 Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521245158.16434.195.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=andrew@aj.id.au \
    --cc=balbi@kernel.org \
    --cc=greg@kroah.com \
    --cc=joel@jms.id.au \
    --cc=kbuild-all@01.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).