From: Oliver Neukum <oneukum@suse.com>
To: Alexander Kappner <agk@godking.net>,
Alan Stern <stern@rowland.harvard.edu>
Cc: gregkh@linuxfoundation.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: usb-storage: Add quirks to make G-Technology "G-Drive" work
Date: Thu, 17 May 2018 14:58:28 +0200 [thread overview]
Message-ID: <1526561908.15506.5.camel@suse.com> (raw)
Am Donnerstag, den 17.05.2018, 01:15 -0700 schrieb Alexander Kappner:
> Yes. Without this flag, the device keeps throwing similar errors on
> usb-storage. That's the same result I get on a host that doesn't have UAS
> compiled in. Here's a dmesg:
Hi,
this is suspicious. You do not actually whether US_FL_NO_WP_DETECT
by itself would make the device work. Can you please test that?
You will need the attached patch for the quirk to be supported.
Regards
Oliver
From 1ff6c9c9cc66ddb4cf7ca95bea589d6a30c63623 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Thu, 17 May 2018 14:46:47 +0200
Subject: [PATCH] UAS: add support for the quirk US_FL_NO_WP_DETECT
The assumption that this quirk can be limited to old storage
devices was too optimistic.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/usb/storage/uas.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 6034c39b67d1..7ee67e8c1f1e 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -836,6 +836,10 @@ static int uas_slave_configure(struct scsi_device *sdev)
if (devinfo->flags & US_FL_BROKEN_FUA)
sdev->broken_fua = 1;
+ /* UAS also needs to support FL_NO_WP_DETECT */
+ if (devinfo->flags & US_FL_NO_WP_DETECT)
+ sdev->skip_ms_page_3f = 1;
+
scsi_change_queue_depth(sdev, devinfo->qdepth - 2);
return 0;
}
--
2.13.6
next reply other threads:[~2018-05-17 12:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 12:58 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-22 8:57 usb-storage: Add quirks to make G-Technology "G-Drive" work Oliver Neukum
2018-05-21 17:47 Alan Stern
2018-05-19 4:50 Alexander Kappner
2018-05-18 20:35 Alan Stern
2018-05-18 17:51 Alexander Kappner
2018-05-17 19:13 Alan Stern
2018-05-17 18:38 Alexander Kappner
2018-05-17 14:44 Alan Stern
2018-05-17 8:15 Alexander Kappner
2018-05-16 20:55 Alan Stern
2018-05-16 20:01 Alexander Kappner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526561908.15506.5.camel@suse.com \
--to=oneukum@suse.com \
--cc=agk@godking.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).