[02/18] dt-bindings: usb: add bindings doc for HiSilicon STB xHCI host controller

[02/18] dt-bindings: usb: add bindings doc for HiSilicon STB xHCI host controller

[Mathias Nyman]

From: Jianguo Sun <sunjianguo1@huawei.com>

This commit adds bindings doc for HiSilicon STB xHCI host controller.

Signed-off-by: Jianguo Sun <sunjianguo1@huawei.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
---
 .../bindings/usb/hisilicon,histb-xhci.txt          | 45 ++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/hisilicon,histb-xhci.txt

diff --git a/Documentation/devicetree/bindings/usb/hisilicon,histb-xhci.txt b/Documentation/devicetree/bindings/usb/hisilicon,histb-xhci.txt
new file mode 100644
index 0000000..f463349
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/hisilicon,histb-xhci.txt
@@ -0,0 +1,45 @@
+HiSilicon STB xHCI
+
+The device node for HiSilicon STB xHCI host controller
+
+Required properties:
+ - compatible: should be "hisilicon,hi3798cv200-xhci"
+ - reg: specifies physical base address and size of the registers
+ - interrupts : interrupt used by the controller
+ - clocks: a list of phandle + clock-specifier pairs, one for each
+	entry in clock-names
+ - clock-names: must contain
+	"bus": for bus clock
+	"utmi": for utmi clock
+	"pipe": for pipe clock
+	"suspend": for suspend clock
+ - resets: a list of phandle and reset specifier pairs as listed in
+	reset-names property.
+ - reset-names: must contain
+	"soft": for soft reset
+ - phys: a list of phandle + phy specifier pairs
+ - phy-names: must contain at least one of following:
+	"inno": for inno phy
+	"combo": for combo phy
+
+Optional properties:
+  - usb2-lpm-disable: indicate if we don't want to enable USB2 HW LPM
+  - usb3-lpm-capable: determines if platform is USB3 LPM capable
+  - imod-interval-ns: default interrupt moderation interval is 40000ns
+
+Example:
+
+xhci0: xchi@f98a0000 {
+	compatible = "hisilicon,hi3798cv200-xhci";
+	reg = <0xf98a0000 0x10000>;
+	interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
+	clocks = <&crg HISTB_USB3_BUS_CLK>,
+		 <&crg HISTB_USB3_UTMI_CLK>,
+		 <&crg HISTB_USB3_PIPE_CLK>,
+		 <&crg HISTB_USB3_SUSPEND_CLK>;
+	clock-names = "bus", "utmi", "pipe", "suspend";
+	resets = <&crg 0xb0 12>;
+	reset-names = "soft";
+	phys = <&usb2_phy1_port1 0>, <&combphy0 PHY_TYPE_USB3>;
+	phy-names = "inno", "combo";
+};

[02/18] dt-bindings: usb: add bindings doc for HiSilicon STB xHCI host controller

[Greg Kroah-Hartman]

On Mon, May 21, 2018 at 04:39:50PM +0300, Mathias Nyman wrote:
> From: Jianguo Sun <sunjianguo1@huawei.com>
> 
> This commit adds bindings doc for HiSilicon STB xHCI host controller.
> 
> Signed-off-by: Jianguo Sun <sunjianguo1@huawei.com>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>

Don't you need an ack from the DT maintainers for new bindings?

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[02/18] dt-bindings: usb: add bindings doc for HiSilicon STB xHCI host controller

[Mathias Nyman]

On 22.05.2018 13:06, Greg KH wrote:
> On Mon, May 21, 2018 at 04:39:50PM +0300, Mathias Nyman wrote:
>> From: Jianguo Sun <sunjianguo1@huawei.com>
>>
>> This commit adds bindings doc for HiSilicon STB xHCI host controller.
>>
>> Signed-off-by: Jianguo Sun <sunjianguo1@huawei.com>
>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> 
> Don't you need an ack from the DT maintainers for new bindings?
> 

True. The comment Rob Herring had to V2 of the HiSilicon patchseries
was fixed in V3 (this one), but V3 was never acked.

Rob, did V3 look ok?

https://marc.info/?l=linux-usb&m=152627889413412&w=2

Thanks
-Mathias
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[02/18] dt-bindings: usb: add bindings doc for HiSilicon STB xHCI host controller

[Rob Herring]

On Tue, May 22, 2018 at 8:31 AM, Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
> On 22.05.2018 13:06, Greg KH wrote:
>>
>> On Mon, May 21, 2018 at 04:39:50PM +0300, Mathias Nyman wrote:
>>>
>>> From: Jianguo Sun <sunjianguo1@huawei.com>
>>>
>>> This commit adds bindings doc for HiSilicon STB xHCI host controller.
>>>
>>> Signed-off-by: Jianguo Sun <sunjianguo1@huawei.com>
>>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>>
>>
>> Don't you need an ack from the DT maintainers for new bindings?
>>
>
> True. The comment Rob Herring had to V2 of the HiSilicon patchseries
> was fixed in V3 (this one), but V3 was never acked.
>
> Rob, did V3 look ok?
>
> https://marc.info/?l=linux-usb&m=152627889413412&w=2

Yes, somehow I marked it that I'd replied, but didn't.

Reviewed-by: Rob Herring <robh@kernel.org>

Rob
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html