From: Oliver Neukum <oneukum@suse.com>
To: Guido Kiener <guido@kiener-muenchen.de>,
dpenkler@gmail.com, steve_bayless@keysight.com,
gregkh@linuxfoundation.org, pankaj.adhikari@ni.com,
guido.kiener@rohde-schwarz.com, linux-usb@vger.kernel.org
Subject: [04/12] usb: usbtmc: Add ioctls for trigger, EOM bit and TermChar
Date: Wed, 23 May 2018 13:58:24 +0200 [thread overview]
Message-ID: <1527076704.14584.5.camel@suse.com> (raw)
Am Donnerstag, den 17.05.2018, 19:03 +0200 schrieb Guido Kiener:
> + retval = usb_bulk_msg(data->usb_dev,
> + usb_sndbulkpipe(data->usb_dev,
> + data->bulk_out),
> + buffer, USBTMC_HEADER_SIZE,
> + &actual, file_data->timeout);
> +
> + /* Store bTag (in case we need to abort) */
> + data->bTag_last_write = data->bTag;
> +
> + /* Increment bTag -- and increment again if zero */
> + data->bTag++;
> + if (!data->bTag)
> + data->bTag++;
> +
Independent of whether this needs to be split up, do you really
want to do this regardless of usb_bulk_msg() returning an error?
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-05-23 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 11:58 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-24 12:41 [04/12] usb: usbtmc: Add ioctls for trigger, EOM bit and TermChar Guido Kiener
2018-05-18 12:29 Greg Kroah-Hartman
2018-05-18 12:08 Guido Kiener
2018-05-17 17:03 Guido Kiener
2018-05-17 16:21 Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527076704.14584.5.camel@suse.com \
--to=oneukum@suse.com \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guido.kiener@rohde-schwarz.com \
--cc=guido@kiener-muenchen.de \
--cc=linux-usb@vger.kernel.org \
--cc=pankaj.adhikari@ni.com \
--cc=steve_bayless@keysight.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).