linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: guido@kiener-muenchen.de
Cc: dpenkler@gmail.com, steve_bayless@keysight.com,
	Greg KH <gregkh@linuxfoundation.org>,
	pankaj.adhikari@ni.com, guido.kiener@rohde-schwarz.com,
	linux-usb@vger.kernel.org
Subject: [02/12] usb: usbtmc: Support Read Status Byte with SRQ per file handle
Date: Sat, 26 May 2018 17:29:17 +0200	[thread overview]
Message-ID: <1527348557.26281.2.camel@suse.com> (raw)

Am Donnerstag, den 24.05.2018, 12:31 +0000 schrieb guido@kiener-
muenchen.de:
> Zitat von Oliver Neukum <oneukum@suse.com>:
> 
> > Am Montag, den 21.05.2018, 21:00 +0000 schrieb guido@kiener-
> > muenchen.de:
> > > 
> > > I looked for a race here, but I do not find a race between open and release,
> > > since a refcount of "file_data->data->kref" is always hold by
> > > usbtmc_probe/disconnect.
> > > 
> > > However I see a race between usbtmc_open and usbtmc_disconnect. Are these
> > > callback functions called mutual exclusive?
> > 
> > No, they are not.
> 
> In the meantime I found these conflictive hints:
> 
> https://github.com/torvalds/linux/commit/52a749992ca6a0fd304609af40ed3bfd6cef4660
> and
> https://elixir.bootlin.com/linux/v4.17-rc6/source/include/linux/usb.h#L1164
> 
> What do you think?
> My current feeling is that open/disconnect is mutual exclusive.
> We also could verify what really happens.

Ok, I remember.

You are safe, if and only if you share the USB minor number space.

	Regards
		Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-05-26 15:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-26 15:29 Oliver Neukum [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-05-24 12:31 [02/12] usb: usbtmc: Support Read Status Byte with SRQ per file handle Guido Kiener
2018-05-23 11:47 Oliver Neukum
2018-05-21 21:00 Guido Kiener
2018-05-18 13:10 Greg Kroah-Hartman
2018-05-18 12:36 Guido Kiener
2018-05-18 12:02 Greg Kroah-Hartman
2018-05-18 11:52 Guido Kiener
2018-05-17 17:03 Guido Kiener
2018-05-17 16:56 Greg Kroah-Hartman
2018-05-17 16:44 Randy Dunlap
2018-05-17 16:20 Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1527348557.26281.2.camel@suse.com \
    --to=oneukum@suse.com \
    --cc=dpenkler@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guido.kiener@rohde-schwarz.com \
    --cc=guido@kiener-muenchen.de \
    --cc=linux-usb@vger.kernel.org \
    --cc=pankaj.adhikari@ni.com \
    --cc=steve_bayless@keysight.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).