From: Jaejoong Kim <climbbb.kim@gmail.com>
To: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Opasiak <k.opasiak@samsung.com>,
Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org
Subject: [3/3] usb: gadget: storage: Remove EXPORT_SYMBOL_GPL for kref_{put, get}
Date: Thu, 14 Jun 2018 18:23:59 +0900 [thread overview]
Message-ID: <1528968239-2447-4-git-send-email-climbbb.kim@gmail.com> (raw)
Removing EXPORT_SYMBOL_GPL from kref_{put, get} since it is used
only in f_mass_storage
Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
---
drivers/usb/gadget/function/f_mass_storage.c | 6 ++----
drivers/usb/gadget/function/f_mass_storage.h | 4 ----
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
index b6e2930..ba0eb7e 100644
--- a/drivers/usb/gadget/function/f_mass_storage.c
+++ b/drivers/usb/gadget/function/f_mass_storage.c
@@ -2558,17 +2558,15 @@ static void fsg_lun_release(struct device *dev)
/* Nothing needs to be done */
}
-void fsg_common_get(struct fsg_common *common)
+static void __maybe_unused fsg_common_get(struct fsg_common *common)
{
kref_get(&common->ref);
}
-EXPORT_SYMBOL_GPL(fsg_common_get);
-void fsg_common_put(struct fsg_common *common)
+static void fsg_common_put(struct fsg_common *common)
{
kref_put(&common->ref, fsg_common_release);
}
-EXPORT_SYMBOL_GPL(fsg_common_put);
static struct fsg_common *fsg_common_setup(struct fsg_common *common)
{
diff --git a/drivers/usb/gadget/function/f_mass_storage.h b/drivers/usb/gadget/function/f_mass_storage.h
index 58857fc..3b8c4ce 100644
--- a/drivers/usb/gadget/function/f_mass_storage.h
+++ b/drivers/usb/gadget/function/f_mass_storage.h
@@ -115,10 +115,6 @@ fsg_opts_from_func_inst(const struct usb_function_instance *fi)
return container_of(fi, struct fsg_opts, func_inst);
}
-void fsg_common_get(struct fsg_common *common);
-
-void fsg_common_put(struct fsg_common *common);
-
void fsg_common_set_sysfs(struct fsg_common *common, bool sysfs);
int fsg_common_set_num_buffers(struct fsg_common *common, unsigned int n);
next reply other threads:[~2018-06-14 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 9:23 Jaejoong Kim [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-14 14:48 [3/3] usb: gadget: storage: Remove EXPORT_SYMBOL_GPL for kref_{put, get} Alan Stern
2018-06-14 18:14 Sergei Shtylyov
2018-06-14 18:23 Jaejoong Kim
2018-06-14 18:26 Jaejoong Kim
2018-06-14 21:09 Alan Stern
2018-06-26 8:54 Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528968239-2447-4-git-send-email-climbbb.kim@gmail.com \
--to=climbbb.kim@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=k.opasiak@samsung.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).