From: Oliver Neukum <oneukum@suse.com>
To: Vladimir Zapolskiy <vz@mleia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>
Cc: usb-storage@lists.one-eyed-alien.net, linux-usb@vger.kernel.org
Subject: [2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries
Date: Thu, 09 Aug 2018 10:23:03 +0200 [thread overview]
Message-ID: <1533802983.17217.5.camel@suse.com> (raw)
On Do, 2018-08-09 at 10:50 +0300, Vladimir Zapolskiy wrote:
> Hi Oliver,
>
> On 08/09/2018 10:38 AM, Oliver Neukum wrote:
> > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote:
> > > Because USB_STORAGE build symbol strictly depends on SCSI build
> > > symbol, there is no need to specify it again for USB_UAS and
> > > USB_STORAGE_ENE_UB6250 build options.
> >
> > [..]
> >
> > > config USB_UAS
> > > tristate "USB Attached SCSI"
> > > - depends on SCSI
> > > help
> > > The USB Attached SCSI protocol is supported by some USB
> > > storage devices. It permits higher performance by supporting
> >
> > Hi,
> >
> > I am sorry, but this is wrong. You can build and use UAS without
>
> can you please elaborate what is wrong exactly.
>
> The change is non-functional.
Hi,
as far as I can tell you are introducing an implicit dependency
of CONFIG_USB_UAS on CONFIG_USB_STORAGE.
Now, firstly implicit references are bad anyway, secondly
in this case it is wrong. Uas works without usb-storage.
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-08-09 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 8:23 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-09 9:27 [2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries Oliver Neukum
2018-08-09 9:21 Greg Kroah-Hartman
2018-08-09 7:50 Vladimir Zapolskiy
2018-08-09 7:38 Oliver Neukum
2018-08-08 22:01 Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533802983.17217.5.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).