* [V2,4/4] USB: serial: f81232: fix bulk_in/out size
@ 2018-08-30 1:47 Ji-Ze Hong (Peter Hong)
0 siblings, 0 replies; 2+ messages in thread
From: Ji-Ze Hong (Peter Hong) @ 2018-08-30 1:47 UTC (permalink / raw)
To: johan; +Cc: gregkh, linux-usb, linux-kernel, peter_hong, hpeter+linux_kernel
Fix Fintek F81232 bulk_in/out size to 64/16 according to the spec.
http://html.alldatasheet.com/html-pdf/406315/FINTEK/F81232/1762/8/F81232.html
Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
---
drivers/usb/serial/f81232.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index 863430d7535f..e3ab1646a693 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -785,8 +785,7 @@ static struct usb_serial_driver f81232_device = {
},
.id_table = id_table,
.num_ports = 1,
- .bulk_in_size = 256,
- .bulk_out_size = 256,
+ .bulk_out_size = 16,
.open = f81232_open,
.close = f81232_close,
.dtr_rts = f81232_dtr_rts,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [V2,4/4] USB: serial: f81232: fix bulk_in/out size
@ 2018-09-05 14:46 Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2018-09-05 14:46 UTC (permalink / raw)
To: Ji-Ze Hong (Peter Hong)
Cc: johan, gregkh, linux-usb, linux-kernel, peter_hong,
hpeter+linux_kernel
On Thu, Aug 30, 2018 at 09:47:14AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Fix Fintek F81232 bulk_in/out size to 64/16 according to the spec.
> http://html.alldatasheet.com/html-pdf/406315/FINTEK/F81232/1762/8/F81232.html
I know we've discussed this before, but please explain here in the
commit message why you want to do this.
The bulk_in/out_size fields only set the buffer sizes used by the
driver and using buffers larger than the endpoint size is typically only
more efficient even if there may be hardware reasons for not wanting to
use that.
You said last time, you datasheets were incorrect and that the devices
were in fact using 64 b endpoints, right?
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> ---
> drivers/usb/serial/f81232.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
> index 863430d7535f..e3ab1646a693 100644
> --- a/drivers/usb/serial/f81232.c
> +++ b/drivers/usb/serial/f81232.c
> @@ -785,8 +785,7 @@ static struct usb_serial_driver f81232_device = {
> },
> .id_table = id_table,
> .num_ports = 1,
> - .bulk_in_size = 256,
> - .bulk_out_size = 256,
> + .bulk_out_size = 16,
> .open = f81232_open,
> .close = f81232_close,
> .dtr_rts = f81232_dtr_rts,
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-05 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-30 1:47 [V2,4/4] USB: serial: f81232: fix bulk_in/out size Ji-Ze Hong (Peter Hong)
-- strict thread matches above, loose matches on Subject: below --
2018-09-05 14:46 Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).