From: Oliver Neukum <oneukum@suse.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>, Andrew Lunn <andrew@lunn.ch>
Cc: Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>,
"David S . Miller" <davem@davemloft.net>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [net-next,08/19] net: usb: aqc111: Implement TX data path
Date: Mon, 08 Oct 2018 16:07:53 +0200 [thread overview]
Message-ID: <1539007673.10342.21.camel@suse.com> (raw)
On Mo, 2018-10-08 at 13:43 +0000, Igor Russkikh wrote:
> > > + skb_push(skb, AQ_TX_HEADER_SIZE);
> > > + cpu_to_le64s(&tx_hdr);
> >
> > Is that portable? tx_hdr is a structure of 2x u32 bitfields. What
> > endian have you tested that one?
> >
>
> You are right, this is wrong for BE hardware.
>
> We don't have such a hardware to check unfortunately.
> Think its better to drop endianess conversions and declare
> the driver as little endian only.
>
> Do you think that'll be acceptable?
No. If worse comes to worse define it u64 and set the values
manually.
Regards
Oliver
next reply other threads:[~2018-10-08 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 14:07 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-09 13:50 [net-next,08/19] net: usb: aqc111: Implement TX data path Bjørn Mork
2018-10-08 13:43 Igor Russkikh
2018-10-06 1:13 Andrew Lunn
2018-10-05 10:25 Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539007673.10342.21.camel@suse.com \
--to=oneukum@suse.com \
--cc=Dmitry.Bezrukov@aquantia.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).