From: Oliver Neukum <oneukum@suse.com>
To: Igor Russkikh <igor.russkikh@aquantia.com>,
"David S . Miller" <davem@davemloft.net>
Cc: Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [net-next,05/19] net: usb: aqc111: Introduce PHY access
Date: Mon, 08 Oct 2018 16:24:25 +0200 [thread overview]
Message-ID: <1539008665.10342.28.camel@suse.com> (raw)
On Mo, 2018-10-08 at 17:10 +0300, Igor Russkikh wrote:
> Hi Oliver,
>
> > > + aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_FW_VER_MAJOR,
> > > + 1, 1, &aqc111_data->fw_ver.major);
> > > + aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_FW_VER_MINOR,
> > > + 1, 1, &aqc111_data->fw_ver.minor);
> > > + aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_FW_VER_REV,
> > > + 1, 1, &aqc111_data->fw_ver.rev);
> >
> > Why read the stuff you don't need?
>
> fw_ver is used below to determine phy access mode.
>
> fw_ver.rev is not used in this exact patch, thats true,
> but it gets reported in later patches in the set.
Hi,
OK that makes sense.
Regards
Oliver
next reply other threads:[~2018-10-08 14:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 14:24 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-10 7:54 [net-next,05/19] net: usb: aqc111: Introduce PHY access Igor Russkikh
2018-10-10 0:58 Andrew Lunn
2018-10-08 14:10 Igor Russkikh
2018-10-08 14:07 Igor Russkikh
2018-10-08 13:52 Oliver Neukum
2018-10-08 12:17 Andrew Lunn
2018-10-08 9:09 Igor Russkikh
2018-10-05 22:04 Andrew Lunn
2018-10-05 10:24 Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539008665.10342.28.camel@suse.com \
--to=oneukum@suse.com \
--cc=Dmitry.Bezrukov@aquantia.com \
--cc=davem@davemloft.net \
--cc=igor.russkikh@aquantia.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).