From: Oliver Neukum <oneukum@suse.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
stern@rowland.harvard.edu
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: [v3] usb: hub: add retry routine after intr URB submit error
Date: Tue, 20 Nov 2018 16:12:54 +0100 [thread overview]
Message-ID: <1542726774.28362.13.camel@suse.com> (raw)
> Anytime "in_reset" is set "quiescing" is also set:
>
> static int hub_pre_reset(struct usb_interface *intf)
> {
> struct usb_hub *hub = usb_get_intfdata(intf);
>
> hub_quiesce(hub, HUB_PRE_RESET); //sets quiesce
> hub->in_reset = 1;
> hub_pm_barrier_for_all_ports(hub);
> return 0;
> }
>
> static int hub_post_reset(struct usb_interface *intf)
> {
> struct usb_hub *hub = usb_get_intfdata(intf);
>
> hub->in_reset = 0;
> hub_pm_barrier_for_all_ports(hub);
> hub_activate(hub, HUB_POST_RESET); //clears quiesce
> return 0;
> }
>
> I should be OK isn't it?
Sorry, yes, I overlooked that there are two flags.
Regards
Oliver
next reply other threads:[~2018-11-20 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 15:12 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-07 21:25 [v3] usb: hub: add retry routine after intr URB submit error Oliver Neukum
2019-01-07 18:59 Alan Stern
2019-01-07 16:33 Greg Kroah-Hartman
2018-11-20 15:17 Nicolas Saenz Julienne
2018-11-20 14:57 Oliver Neukum
2018-11-20 14:34 Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542726774.28362.13.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).