* serious doubts concerning a7d57abcc8a5bdeb53bbf8e87558e8e0a2c2a29d ("xhci: workaround CSS timeout on AMD SNPS 3.0 xHC")
@ 2018-12-17 12:33 Oliver Neukum
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Neukum @ 2018-12-17 12:33 UTC (permalink / raw)
To: Sandeep Singh; +Cc: linux-usb, nsaenzjulienne, gregkh
Hi,
this patch contains the following section:
index 260b259b72bc..c3515bad5dbb 100644
The placement of the broken_suspend flag seems to break every
usage of the priv member of struct xhci_hcd.
Are you sure that is a good idea?
Regards
Oliver
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1850,6 +1850,7 @@ struct xhci_hcd {
#define XHCI_ZERO_64B_REGS BIT_ULL(32)
#define XHCI_DEFAULT_PM_RUNTIME_ALLOW BIT_ULL(33)
#define XHCI_RESET_PLL_ON_DISCONNECT BIT_ULL(34)
+#define XHCI_SNPS_BROKEN_SUSPEND BIT_ULL(35)
unsigned int num_active_eps;
unsigned int limit_active_eps;
@@ -1879,6 +1880,8 @@ struct xhci_hcd {
void *dbc;
/* platform-specific data -- must come last */
unsigned long priv[0] __aligned(sizeof(s64));
+ /* Broken Suspend flag for SNPS Suspend resume issue */
+ u8 broken_suspend;
};
/* Platform specific overrides to generic XHCI hc_driver ops */
^ permalink raw reply [flat|nested] 2+ messages in thread* serious doubts concerning a7d57abcc8a5bdeb53bbf8e87558e8e0a2c2a29d ("xhci: workaround CSS timeout on AMD SNPS 3.0 xHC")
@ 2018-12-17 12:54 Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2018-12-17 12:54 UTC (permalink / raw)
To: Oliver Neukum; +Cc: Sandeep Singh, linux-usb, nsaenzjulienne
On Mon, Dec 17, 2018 at 01:33:05PM +0100, Oliver Neukum wrote:
> Hi,
>
> this patch contains the following section:
>
> index 260b259b72bc..c3515bad5dbb 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1850,6 +1850,7 @@ struct xhci_hcd {
> #define XHCI_ZERO_64B_REGS BIT_ULL(32)
> #define XHCI_DEFAULT_PM_RUNTIME_ALLOW BIT_ULL(33)
> #define XHCI_RESET_PLL_ON_DISCONNECT BIT_ULL(34)
> +#define XHCI_SNPS_BROKEN_SUSPEND BIT_ULL(35)
>
> unsigned int num_active_eps;
> unsigned int limit_active_eps;
> @@ -1879,6 +1880,8 @@ struct xhci_hcd {
> void *dbc;
> /* platform-specific data -- must come last */
> unsigned long priv[0] __aligned(sizeof(s64));
> + /* Broken Suspend flag for SNPS Suspend resume issue */
> + u8 broken_suspend;
> };
>
> /* Platform specific overrides to generic XHCI hc_driver ops */
>
> The placement of the broken_suspend flag seems to break every
> usage of the priv member of struct xhci_hcd.
> Are you sure that is a good idea?
Ugh, ick, no, that's totally wrong :(
How did this work? I guess no one tried this type of host controller on
a platform xhci driver?
Sandeep or oliver, , want to send a fixup patch?
And shouldn't that just be a bool or a bitflag?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-17 12:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-17 12:33 serious doubts concerning a7d57abcc8a5bdeb53bbf8e87558e8e0a2c2a29d ("xhci: workaround CSS timeout on AMD SNPS 3.0 xHC") Oliver Neukum
-- strict thread matches above, loose matches on Subject: below --
2018-12-17 12:54 Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).