Linux USB
 help / color / mirror / Atom feed
From: macpaul.lin@mediatek.com
To: Oliver Neukum <oneukum@suse.com>,
	Andrey Arapov <andrey.arapov@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
	linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: [v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader.
Date: Tue, 18 Dec 2018 22:26:35 +0800	[thread overview]
Message-ID: <1545143195.10193.6.camel@mtkswgap22> (raw)

On Tue, 2018-12-18 at 14:37 +0100, Oliver Neukum wrote:
> On Di, 2018-12-18 at 13:38 +0100, Johan Hovold wrote:
> > On 
> > > @@ -1655,7 +1662,10 @@ static int acm_pre_reset(struct usb_interface *intf)
> > >  	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > >  	},
> > >  	{ USB_DEVICE(0x0e8d, 0x0003), /* FIREFLY, MediaTek Inc; andrey.arapov@gmail.com */
> > > -	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > > +	.driver_info = DISABLE_ECHO, /* DISABLE ECHO in termios flag */
> > 
> > I just noticed that you remove the NO_UNION_NORMAL here, which looks
> > wrong and definitely requires a motivation.
> > 
> > Thanks,
> > Johan
> > 
> 
> Hi,
> 
> thank you and thank you Johan.
> Unfortunately I cannot take this until the issue with the removed
> quirk is clarified.
> 
> 	Regards
> 		Oliver
> 

Hi,
Thanks Johan's help on reviewing the updated patches.
According to Andrey's patch, the commit said this change is for
"Samsung X180 China cellphone" which might be also a Mediatek SoC based
phone using Mediatek VID.
https://goo.gl/a9ddNq (I've add a url for reference here).

But I'm not sure the PID is for Mediatek's BROM or customized Preloader.
(Both should be able to apply DISABLE_ECHO flag).
Maybe I can simply update PATCH v6 by removing FIREFLY if any one has
problem here.
Let's also loop Andrey for clarification.

Thanks!

Regards,
Macpaul Lin

             reply	other threads:[~2018-12-18 14:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 14:26 macpaul.lin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-12-20 15:19 [v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader Greg Kroah-Hartman
2018-12-19  8:56 Oliver Neukum
2018-12-19  4:03 macpaul.lin
2018-12-19  3:31 Lars Melin
2018-12-19  3:16 macpaul.lin
2018-12-19  2:22 macpaul.lin
2018-12-19  0:45 Lars Melin
2018-12-18 17:48 macpaul.lin
2018-12-18 16:42 Lars Melin
2018-12-18 15:19 macpaul.lin
2018-12-18 13:37 Oliver Neukum
2018-12-18 12:38 Johan Hovold
2018-12-18 11:59 macpaul.lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1545143195.10193.6.camel@mtkswgap22 \
    --to=macpaul.lin@mediatek.com \
    --cc=andrey.arapov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=stable@vger.kernel.org \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox