From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [V7,1/4] USB: serial: f81232: clear overrun flag From: "Ji-Ze Hong \(Peter Hong\)" Message-Id: <1555403225-3430-1-git-send-email-hpeter+linux_kernel@gmail.com> Date: Tue, 16 Apr 2019 16:27:02 +0800 To: peter_hong@fintek.com.tw, johan@kernel.org, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Ji-Ze Hong \(Peter Hong\)" , Oliver Neukum List-ID: VGhlIEY4MTIzMiB3aWxsIHJlcG9ydCBkYXRhIGFuZCBMU1Igd2l0aCBidWxrIGxpa2UgZm9sbG93 aW5nIGZvcm1hdDoKYnVsay1pbiBkYXRhOiBbTFNSKDFCeXRlKStEQVRBKDFCeXRlKV1bTFNSKDFC eXRlKStEQVRBKDFCeXRlKV0uLi4KCkxTUiB3aWxsIGF1dG8gY2xlYXIgZnJhbWUvcGFyaXR5L2Jy ZWFrIGVycm9yIGZsYWcgd2hlbiByZWFkaW5nIGJ5IEgvVywKYnV0IG92ZXJycnVuIHdpbGwgb25s eSBjbGVhcmVkIHdoZW4gcmVhZGluZyBMU1IuIFNvIHRoaXMgcGF0Y2ggYWRkIGEKd29ya2VyIHRv IHJlYWQgTFNSIHdoZW4gb3ZlcnJ1biBhbmQgZmx1c2ggdGhlIHdvcmtlciBvbiBjbG9zZSgpICYK c3VzcGVuZCgpLgoKQ2M6IE9saXZlciBOZXVrdW0gPG9uZXVrdW1Ac3VzZS5jb20+ClNpZ25lZC1v ZmYtYnk6IEppLVplIEhvbmcgKFBldGVyIEhvbmcpIDxocGV0ZXIrbGludXhfa2VybmVsQGdtYWls LmNvbT4KLS0tCnY3OgoJMTogUmVtb3ZlIHNlcmlhbC0+c3VzcGVuZGluZyBjaGVjawoJMjogQWRk IHBvcnQgcHJpdiBpc19wb3J0X29wZW4gdG8gc2F2ZSBwb3J0IG9wZW4gc3RhdGUuIFdlJ2xsCgkg ICByZWdpc3RlciBpbnRlcnJ1cHQtaW4gdXJiIGluIGY4MTIzMl9yZXN1bWUoKSB3aGVuIHBvcnQg aXMKCSAgIG9wZW5lZC4KCTM6IFVzaW5nIHVzYl9raWxsX3VyYiBmb3IgcmVhZC9pbnRlcnJ1cHQg dXJiIHRvIGVuc3VyZSB1cmIKCSAgIHN0b3BwZWQuCgpWNjoKCTE6IEFkZCBkZWZlcnJlZF9sc3Jf d29ya19uZWVkZWQgdG8gcmUtdHJpZ2dlciB3aGVuIGY4MTIzMl9yZXN1bWUoKQoKdjU6CgkxOiBT b3VyY2UgY29kZSBiYXNlIHJldmVydCB0byB2MyBhbmQgcmVtb3ZlIGFsbCB2NCBjaGFuZ2VzLgoJ MjogQWRkIHNlcmlhbC0+c3VzcGVuZGluZyBjaGVjayBpbiBmODEyMzJfcHJvY2Vzc19yZWFkX3Vy YigpCgkgICBiZWZvcmUgc2NoZWR1bGVfd29yaygmcHJpdi0+bHNyX3dvcmspIHRvIGF2b2lkIHJh Y2UgY29uZGl0aW9uLgoKdjQ6CgkxOiBBZGQgc2VyaWFsLT5zdXNwZW5kaW5nIGNoZWNrIGluIGY4 MTIzMl9sc3Jfd29ya2VyKCkgdG8gYXZvaWQKCSAgIHJlLXRyaWdnZXIKCTI6IEFkZCBwb3J0X3By aXYtbHNyX3dvcmtfcmVzY2hlZCB0byByZS10cmlnZ2VyIExTUiB3b3JrZXIKCnYzOgoJMTogQWRk IGZsdXNoX3dvcmsoJnBvcnRfcHJpdi0+bHNyX3dvcmspIGluIGY4MTIzMl9zdXNwZW5kKCkuCgp2 MjoKCTE6IEFkZCBmbHVzaF93b3JrKCZwb3J0X3ByaXYtPmxzcl93b3JrKSBpbiBmODEyMzJfY2xv c2UoKS4KCiBkcml2ZXJzL3VzYi9zZXJpYWwvZjgxMjMyLmMgfCA5NyArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA4OSBpbnNlcnRp b25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3NlcmlhbC9m ODEyMzIuYyBiL2RyaXZlcnMvdXNiL3NlcmlhbC9mODEyMzIuYwppbmRleCAwZGNkY2I0YjJjZGUu LjE4ZDNmY2YyOTA3YSAxMDA2NDQKLS0tIGEvZHJpdmVycy91c2Ivc2VyaWFsL2Y4MTIzMi5jCisr KyBiL2RyaXZlcnMvdXNiL3NlcmlhbC9mODEyMzIuYwpAQCAtNDEsMTIgKzQxLDE1IEBAIE1PRFVM RV9ERVZJQ0VfVEFCTEUodXNiLCBpZF90YWJsZSk7CiAjZGVmaW5lIEZJRk9fQ09OVFJPTF9SRUdJ U1RFUgkJKDB4MDIgKyBTRVJJQUxfQkFTRV9BRERSRVNTKQogI2RlZmluZSBMSU5FX0NPTlRST0xf UkVHSVNURVIJCSgweDAzICsgU0VSSUFMX0JBU0VfQUREUkVTUykKICNkZWZpbmUgTU9ERU1fQ09O VFJPTF9SRUdJU1RFUgkJKDB4MDQgKyBTRVJJQUxfQkFTRV9BRERSRVNTKQorI2RlZmluZSBMSU5F X1NUQVRVU19SRUdJU1RFUgkJKDB4MDUgKyBTRVJJQUxfQkFTRV9BRERSRVNTKQogI2RlZmluZSBN T0RFTV9TVEFUVVNfUkVHSVNURVIJCSgweDA2ICsgU0VSSUFMX0JBU0VfQUREUkVTUykKIAogc3Ry dWN0IGY4MTIzMl9wcml2YXRlIHsKIAlzdHJ1Y3QgbXV0ZXggbG9jazsKIAl1OCBtb2RlbV9jb250 cm9sOwogCXU4IG1vZGVtX3N0YXR1czsKKwlib29sIGlzX3BvcnRfb3BlbjsKKwlzdHJ1Y3Qgd29y a19zdHJ1Y3QgbHNyX3dvcms7CiAJc3RydWN0IHdvcmtfc3RydWN0IGludGVycnVwdF93b3JrOwog CXN0cnVjdCB1c2Jfc2VyaWFsX3BvcnQgKnBvcnQ7CiB9OwpAQCAtMjgyLDYgKzI4NSw3IEBAIHN0 YXRpYyB2b2lkIGY4MTIzMl9yZWFkX2ludF9jYWxsYmFjayhzdHJ1Y3QgdXJiICp1cmIpCiBzdGF0 aWMgdm9pZCBmODEyMzJfcHJvY2Vzc19yZWFkX3VyYihzdHJ1Y3QgdXJiICp1cmIpCiB7CiAJc3Ry dWN0IHVzYl9zZXJpYWxfcG9ydCAqcG9ydCA9IHVyYi0+Y29udGV4dDsKKwlzdHJ1Y3QgZjgxMjMy X3ByaXZhdGUgKnByaXYgPSB1c2JfZ2V0X3NlcmlhbF9wb3J0X2RhdGEocG9ydCk7CiAJdW5zaWdu ZWQgY2hhciAqZGF0YSA9IHVyYi0+dHJhbnNmZXJfYnVmZmVyOwogCWNoYXIgdHR5X2ZsYWc7CiAJ dW5zaWduZWQgaW50IGk7CkBAIC0zMTUsNiArMzE5LDcgQEAgc3RhdGljIHZvaWQgZjgxMjMyX3By b2Nlc3NfcmVhZF91cmIoc3RydWN0IHVyYiAqdXJiKQogCiAJCQlpZiAobHNyICYgVUFSVF9MU1Jf T0UpIHsKIAkJCQlwb3J0LT5pY291bnQub3ZlcnJ1bisrOworCQkJCXNjaGVkdWxlX3dvcmsoJnBy aXYtPmxzcl93b3JrKTsKIAkJCQl0dHlfaW5zZXJ0X2ZsaXBfY2hhcigmcG9ydC0+cG9ydCwgMCwK IAkJCQkJCVRUWV9PVkVSUlVOKTsKIAkJCX0KQEAgLTUyOCwzNyArNTMzLDUyIEBAIHN0YXRpYyBp bnQgZjgxMjMyX3Rpb2Ntc2V0KHN0cnVjdCB0dHlfc3RydWN0ICp0dHksCiAKIHN0YXRpYyBpbnQg ZjgxMjMyX29wZW4oc3RydWN0IHR0eV9zdHJ1Y3QgKnR0eSwgc3RydWN0IHVzYl9zZXJpYWxfcG9y dCAqcG9ydCkKIHsKLQlpbnQgcmVzdWx0OwotCi0JcmVzdWx0ID0gZjgxMjMyX3BvcnRfZW5hYmxl KHBvcnQpOwotCWlmIChyZXN1bHQpCi0JCXJldHVybiByZXN1bHQ7CisJc3RydWN0IGY4MTIzMl9w cml2YXRlICpwb3J0X3ByaXYgPSB1c2JfZ2V0X3NlcmlhbF9wb3J0X2RhdGEocG9ydCk7CisJaW50 IHJlc3VsdCA9IDA7CiAKIAkvKiBTZXR1cCB0ZXJtaW9zICovCiAJaWYgKHR0eSkKIAkJZjgxMjMy X3NldF90ZXJtaW9zKHR0eSwgcG9ydCwgTlVMTCk7CiAKKwltdXRleF9sb2NrKCZwb3J0X3ByaXYt PmxvY2spOworCisJcmVzdWx0ID0gZjgxMjMyX3BvcnRfZW5hYmxlKHBvcnQpOworCWlmIChyZXN1 bHQpCisJCWdvdG8gZW5kOworCiAJcmVzdWx0ID0gdXNiX3N1Ym1pdF91cmIocG9ydC0+aW50ZXJy dXB0X2luX3VyYiwgR0ZQX0tFUk5FTCk7CiAJaWYgKHJlc3VsdCkgewogCQlkZXZfZXJyKCZwb3J0 LT5kZXYsICIlcyAtIGZhaWxlZCBzdWJtaXR0aW5nIGludGVycnVwdCB1cmIsIgogCQkJIiBlcnJv ciAlZFxuIiwgX19mdW5jX18sIHJlc3VsdCk7Ci0JCXJldHVybiByZXN1bHQ7CisJCWdvdG8gZW5k OwogCX0KIAogCXJlc3VsdCA9IHVzYl9zZXJpYWxfZ2VuZXJpY19vcGVuKHR0eSwgcG9ydCk7CiAJ aWYgKHJlc3VsdCkgewogCQl1c2Jfa2lsbF91cmIocG9ydC0+aW50ZXJydXB0X2luX3VyYik7Ci0J CXJldHVybiByZXN1bHQ7CisJCWdvdG8gZW5kOwogCX0KIAotCXJldHVybiAwOworCXBvcnRfcHJp di0+aXNfcG9ydF9vcGVuID0gdHJ1ZTsKK2VuZDoKKwltdXRleF91bmxvY2soJnBvcnRfcHJpdi0+ bG9jayk7CisKKwlyZXR1cm4gcmVzdWx0OwogfQogCiBzdGF0aWMgdm9pZCBmODEyMzJfY2xvc2Uo c3RydWN0IHVzYl9zZXJpYWxfcG9ydCAqcG9ydCkKIHsKKwlzdHJ1Y3QgZjgxMjMyX3ByaXZhdGUg KnBvcnRfcHJpdiA9IHVzYl9nZXRfc2VyaWFsX3BvcnRfZGF0YShwb3J0KTsKKworCW11dGV4X2xv Y2soJnBvcnRfcHJpdi0+bG9jayk7CisKIAlmODEyMzJfcG9ydF9kaXNhYmxlKHBvcnQpOwogCXVz Yl9zZXJpYWxfZ2VuZXJpY19jbG9zZShwb3J0KTsKIAl1c2Jfa2lsbF91cmIocG9ydC0+aW50ZXJy dXB0X2luX3VyYik7CisJZmx1c2hfd29yaygmcG9ydF9wcml2LT5sc3Jfd29yayk7CisJcG9ydF9w cml2LT5pc19wb3J0X29wZW4gPSBmYWxzZTsKKworCW11dGV4X3VubG9jaygmcG9ydF9wcml2LT5s b2NrKTsKIH0KIAogc3RhdGljIHZvaWQgZjgxMjMyX2R0cl9ydHMoc3RydWN0IHVzYl9zZXJpYWxf cG9ydCAqcG9ydCwgaW50IG9uKQpAQCAtNjAzLDYgKzYyMywyMSBAQCBzdGF0aWMgdm9pZCAgZjgx MjMyX2ludGVycnVwdF93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKIAlmODEyMzJfcmVh ZF9tc3IocHJpdi0+cG9ydCk7CiB9CiAKK3N0YXRpYyB2b2lkIGY4MTIzMl9sc3Jfd29ya2VyKHN0 cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKK3sKKwlzdHJ1Y3QgZjgxMjMyX3ByaXZhdGUgKnByaXY7 CisJc3RydWN0IHVzYl9zZXJpYWxfcG9ydCAqcG9ydDsKKwlpbnQgc3RhdHVzOworCXU4IHRtcDsK KworCXByaXYgPSBjb250YWluZXJfb2Yod29yaywgc3RydWN0IGY4MTIzMl9wcml2YXRlLCBsc3Jf d29yayk7CisJcG9ydCA9IHByaXYtPnBvcnQ7CisKKwlzdGF0dXMgPSBmODEyMzJfZ2V0X3JlZ2lz dGVyKHBvcnQsIExJTkVfU1RBVFVTX1JFR0lTVEVSLCAmdG1wKTsKKwlpZiAoc3RhdHVzKQorCQlk ZXZfd2FybigmcG9ydC0+ZGV2LCAicmVhZCBMU1IgZmFpbGVkOiAlZFxuIiwgc3RhdHVzKTsKK30K Kwogc3RhdGljIGludCBmODEyMzJfcG9ydF9wcm9iZShzdHJ1Y3QgdXNiX3NlcmlhbF9wb3J0ICpw b3J0KQogewogCXN0cnVjdCBmODEyMzJfcHJpdmF0ZSAqcHJpdjsKQEAgLTYxMyw2ICs2NDgsNyBA QCBzdGF0aWMgaW50IGY4MTIzMl9wb3J0X3Byb2JlKHN0cnVjdCB1c2Jfc2VyaWFsX3BvcnQgKnBv cnQpCiAKIAltdXRleF9pbml0KCZwcml2LT5sb2NrKTsKIAlJTklUX1dPUksoJnByaXYtPmludGVy cnVwdF93b3JrLCAgZjgxMjMyX2ludGVycnVwdF93b3JrKTsKKwlJTklUX1dPUksoJnByaXYtPmxz cl93b3JrLCBmODEyMzJfbHNyX3dvcmtlcik7CiAKIAl1c2Jfc2V0X3NlcmlhbF9wb3J0X2RhdGEo cG9ydCwgcHJpdik7CiAKQEAgLTYzMiw2ICs2NjgsNDkgQEAgc3RhdGljIGludCBmODEyMzJfcG9y dF9yZW1vdmUoc3RydWN0IHVzYl9zZXJpYWxfcG9ydCAqcG9ydCkKIAlyZXR1cm4gMDsKIH0KIAor c3RhdGljIGludCBmODEyMzJfc3VzcGVuZChzdHJ1Y3QgdXNiX3NlcmlhbCAqc2VyaWFsLCBwbV9t ZXNzYWdlX3QgbWVzc2FnZSkKK3sKKwlzdHJ1Y3QgdXNiX3NlcmlhbF9wb3J0ICpwb3J0ID0gc2Vy aWFsLT5wb3J0WzBdOworCXN0cnVjdCBmODEyMzJfcHJpdmF0ZSAqcG9ydF9wcml2ID0gdXNiX2dl dF9zZXJpYWxfcG9ydF9kYXRhKHBvcnQpOworCWludCBpOworCisJZm9yIChpID0gMDsgaSA8IEFS UkFZX1NJWkUocG9ydC0+cmVhZF91cmJzKTsgKytpKQorCQl1c2Jfa2lsbF91cmIocG9ydC0+cmVh ZF91cmJzW2ldKTsKKworCXVzYl9raWxsX3VyYihwb3J0LT5pbnRlcnJ1cHRfaW5fdXJiKTsKKwor CWlmIChwb3J0X3ByaXYpCisJCWZsdXNoX3dvcmsoJnBvcnRfcHJpdi0+bHNyX3dvcmspOworCisJ cmV0dXJuIDA7Cit9CisKK3N0YXRpYyBpbnQgZjgxMjMyX3Jlc3VtZShzdHJ1Y3QgdXNiX3Nlcmlh bCAqc2VyaWFsKQoreworCXN0cnVjdCB1c2Jfc2VyaWFsX3BvcnQgKnBvcnQgPSBzZXJpYWwtPnBv cnRbMF07CisJc3RydWN0IGY4MTIzMl9wcml2YXRlICpwb3J0X3ByaXYgPSB1c2JfZ2V0X3Nlcmlh bF9wb3J0X2RhdGEocG9ydCk7CisJaW50IHJlc3VsdCA9IDA7CisKKwltdXRleF9sb2NrKCZwb3J0 X3ByaXYtPmxvY2spOworCisJaWYgKHBvcnRfcHJpdiAmJiBwb3J0X3ByaXYtPmlzX3BvcnRfb3Bl bikgeworCQlyZXN1bHQgPSB1c2Jfc3VibWl0X3VyYihwb3J0LT5pbnRlcnJ1cHRfaW5fdXJiLCBH RlBfS0VSTkVMKTsKKwkJaWYgKHJlc3VsdCkgeworCQkJZGV2X2VycigmcG9ydC0+ZGV2LAorCQkJ CQkiJXM6IHN1Ym1pdCBpbnRlcnJ1cHQgdXJiIGZhaWxlZDogJWQiLAorCQkJCQlfX2Z1bmNfXywg cmVzdWx0KTsKKwkJCWdvdG8gZW5kOworCQl9CisJfQorCisJcmVzdWx0ID0gdXNiX3NlcmlhbF9n ZW5lcmljX3Jlc3VtZShzZXJpYWwpOworCitlbmQ6CisJbXV0ZXhfdW5sb2NrKCZwb3J0X3ByaXYt PmxvY2spOworCisJcmV0dXJuIHJlc3VsdDsKK30KKwogc3RhdGljIHN0cnVjdCB1c2Jfc2VyaWFs X2RyaXZlciBmODEyMzJfZGV2aWNlID0gewogCS5kcml2ZXIgPSB7CiAJCS5vd25lciA9CVRISVNf TU9EVUxFLApAQCAtNjU1LDYgKzczNCw4IEBAIHN0YXRpYyBzdHJ1Y3QgdXNiX3NlcmlhbF9kcml2 ZXIgZjgxMjMyX2RldmljZSA9IHsKIAkucmVhZF9pbnRfY2FsbGJhY2sgPQlmODEyMzJfcmVhZF9p bnRfY2FsbGJhY2ssCiAJLnBvcnRfcHJvYmUgPQkJZjgxMjMyX3BvcnRfcHJvYmUsCiAJLnBvcnRf cmVtb3ZlID0JCWY4MTIzMl9wb3J0X3JlbW92ZSwKKwkuc3VzcGVuZCA9CQlmODEyMzJfc3VzcGVu ZCwKKwkucmVzdW1lID0JCWY4MTIzMl9yZXN1bWUsCiB9OwogCiBzdGF0aWMgc3RydWN0IHVzYl9z ZXJpYWxfZHJpdmVyICogY29uc3Qgc2VyaWFsX2RyaXZlcnNbXSA9IHsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D66AC10F14 for ; Tue, 16 Apr 2019 08:27:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5EDA2073F for ; Tue, 16 Apr 2019 08:27:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KdJaQVIr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728698AbfDPI1L (ORCPT ); Tue, 16 Apr 2019 04:27:11 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33977 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727195AbfDPI1K (ORCPT ); Tue, 16 Apr 2019 04:27:10 -0400 Received: by mail-pg1-f194.google.com with SMTP id v12so9981317pgq.1; Tue, 16 Apr 2019 01:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=uhAEkyyjkNnZbB0S3fzuTsDrada7JnXbrIJMvnrBSrI=; b=KdJaQVIrbFlAZU1oWu6iHq0Mj3DGxdpIxkVS/fchNgdNzh3Y1bwSDEg6/AzfXu9oq/ pzd8ZWXE8MwHJg7agrQWGKDIUi5YMls3FRjjjKv3ZBE8bYtpPYrmGu817ttu6zg0Fu8l 5+2KToS1+o6eh61WVQmIY1xFxu94TRP5Qt6HEVftCPnlhstjeBmgQ0tzCqPGDFdm4Rvi rQpbBGx90IRjwAHSe2q4lmaBJnnu7n6Ldyzai1B5zsB7WGyg6aI/22fSItPd6htsh9oV CSk/IuoG2IvzwdZmbbvYR8Ti8ojzUqMumGzmSYaGVG0dTP+b3GL1k/mgcSuLG2XDMynk fZhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uhAEkyyjkNnZbB0S3fzuTsDrada7JnXbrIJMvnrBSrI=; b=PyS+LACe5eU88Bx1Fh3ebvCcJ0AqCyg0Cl8TyrG+RyHg9rNbnj6G/1mNoDSIlK5uMc VKGifa6XDh6r52t/bJxzAnlXkDiVBbDm5AYdkR3JASyULX+bUI6kN91D3SepTK2dwipI 1P5ksNFKrnrhguc95qp88q+yXiawYiqK3Qz3ytUlH79tKHd6Nl5SLRUNR6PrLhaV+t1T yjI4MA76j7jay+IVCVV1U2ngcbLeAQJtP6fEWPlYqHU7QbEdAZiqC98KN8Vn50mxXjwM 0MrpI4c4yEHa8OIi35mtjO0xcJsD64GwH24wKrIqOCOqu0C4JVdB1o8L4AUM7L+PxFL0 9nGA== X-Gm-Message-State: APjAAAXZz2ieYXTnqcYViyiCCyW3qfEN1q8x14V8qA6EgE6GWXy3CZJs v3nTy4Ivw69PFWFcg3EKVMa9y9cI X-Google-Smtp-Source: APXvYqyUSMKnqCZoxSun45hgeV9BOtz5Hrr2nbAqLEzPXmLGnCL+4AZHiwU177fj41velZ7pkqz13g== X-Received: by 2002:a65:6144:: with SMTP id o4mr74941023pgv.247.1555403229593; Tue, 16 Apr 2019 01:27:09 -0700 (PDT) Received: from localhost (59-120-186-245.HINET-IP.hinet.net. [59.120.186.245]) by smtp.gmail.com with ESMTPSA id w1sm47325757pfw.101.2019.04.16.01.27.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Apr 2019 01:27:09 -0700 (PDT) From: "Ji-Ze Hong (Peter Hong)" X-Google-Original-From: "Ji-Ze Hong (Peter Hong)" To: peter_hong@fintek.com.tw, johan@kernel.org, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Ji-Ze Hong (Peter Hong)" , Oliver Neukum Subject: [PATCH V7 1/4] USB: serial: f81232: clear overrun flag Date: Tue, 16 Apr 2019 16:27:02 +0800 Message-Id: <1555403225-3430-1-git-send-email-hpeter+linux_kernel@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Message-ID: <20190416082702.F20QREFGsYGD8NeK2Jrj2YK59JtHxQsf2X4UpEfzgAk@z> The F81232 will report data and LSR with bulk like following format: bulk-in data: [LSR(1Byte)+DATA(1Byte)][LSR(1Byte)+DATA(1Byte)]... LSR will auto clear frame/parity/break error flag when reading by H/W, but overrrun will only cleared when reading LSR. So this patch add a worker to read LSR when overrun and flush the worker on close() & suspend(). Cc: Oliver Neukum Signed-off-by: Ji-Ze Hong (Peter Hong) --- v7: 1: Remove serial->suspending check 2: Add port priv is_port_open to save port open state. We'll register interrupt-in urb in f81232_resume() when port is opened. 3: Using usb_kill_urb for read/interrupt urb to ensure urb stopped. V6: 1: Add deferred_lsr_work_needed to re-trigger when f81232_resume() v5: 1: Source code base revert to v3 and remove all v4 changes. 2: Add serial->suspending check in f81232_process_read_urb() before schedule_work(&priv->lsr_work) to avoid race condition. v4: 1: Add serial->suspending check in f81232_lsr_worker() to avoid re-trigger 2: Add port_priv-lsr_work_resched to re-trigger LSR worker v3: 1: Add flush_work(&port_priv->lsr_work) in f81232_suspend(). v2: 1: Add flush_work(&port_priv->lsr_work) in f81232_close(). drivers/usb/serial/f81232.c | 97 +++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 89 insertions(+), 8 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c index 0dcdcb4b2cde..18d3fcf2907a 100644 --- a/drivers/usb/serial/f81232.c +++ b/drivers/usb/serial/f81232.c @@ -41,12 +41,15 @@ MODULE_DEVICE_TABLE(usb, id_table); #define FIFO_CONTROL_REGISTER (0x02 + SERIAL_BASE_ADDRESS) #define LINE_CONTROL_REGISTER (0x03 + SERIAL_BASE_ADDRESS) #define MODEM_CONTROL_REGISTER (0x04 + SERIAL_BASE_ADDRESS) +#define LINE_STATUS_REGISTER (0x05 + SERIAL_BASE_ADDRESS) #define MODEM_STATUS_REGISTER (0x06 + SERIAL_BASE_ADDRESS) struct f81232_private { struct mutex lock; u8 modem_control; u8 modem_status; + bool is_port_open; + struct work_struct lsr_work; struct work_struct interrupt_work; struct usb_serial_port *port; }; @@ -282,6 +285,7 @@ static void f81232_read_int_callback(struct urb *urb) static void f81232_process_read_urb(struct urb *urb) { struct usb_serial_port *port = urb->context; + struct f81232_private *priv = usb_get_serial_port_data(port); unsigned char *data = urb->transfer_buffer; char tty_flag; unsigned int i; @@ -315,6 +319,7 @@ static void f81232_process_read_urb(struct urb *urb) if (lsr & UART_LSR_OE) { port->icount.overrun++; + schedule_work(&priv->lsr_work); tty_insert_flip_char(&port->port, 0, TTY_OVERRUN); } @@ -528,37 +533,52 @@ static int f81232_tiocmset(struct tty_struct *tty, static int f81232_open(struct tty_struct *tty, struct usb_serial_port *port) { - int result; - - result = f81232_port_enable(port); - if (result) - return result; + struct f81232_private *port_priv = usb_get_serial_port_data(port); + int result = 0; /* Setup termios */ if (tty) f81232_set_termios(tty, port, NULL); + mutex_lock(&port_priv->lock); + + result = f81232_port_enable(port); + if (result) + goto end; + result = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); if (result) { dev_err(&port->dev, "%s - failed submitting interrupt urb," " error %d\n", __func__, result); - return result; + goto end; } result = usb_serial_generic_open(tty, port); if (result) { usb_kill_urb(port->interrupt_in_urb); - return result; + goto end; } - return 0; + port_priv->is_port_open = true; +end: + mutex_unlock(&port_priv->lock); + + return result; } static void f81232_close(struct usb_serial_port *port) { + struct f81232_private *port_priv = usb_get_serial_port_data(port); + + mutex_lock(&port_priv->lock); + f81232_port_disable(port); usb_serial_generic_close(port); usb_kill_urb(port->interrupt_in_urb); + flush_work(&port_priv->lsr_work); + port_priv->is_port_open = false; + + mutex_unlock(&port_priv->lock); } static void f81232_dtr_rts(struct usb_serial_port *port, int on) @@ -603,6 +623,21 @@ static void f81232_interrupt_work(struct work_struct *work) f81232_read_msr(priv->port); } +static void f81232_lsr_worker(struct work_struct *work) +{ + struct f81232_private *priv; + struct usb_serial_port *port; + int status; + u8 tmp; + + priv = container_of(work, struct f81232_private, lsr_work); + port = priv->port; + + status = f81232_get_register(port, LINE_STATUS_REGISTER, &tmp); + if (status) + dev_warn(&port->dev, "read LSR failed: %d\n", status); +} + static int f81232_port_probe(struct usb_serial_port *port) { struct f81232_private *priv; @@ -613,6 +648,7 @@ static int f81232_port_probe(struct usb_serial_port *port) mutex_init(&priv->lock); INIT_WORK(&priv->interrupt_work, f81232_interrupt_work); + INIT_WORK(&priv->lsr_work, f81232_lsr_worker); usb_set_serial_port_data(port, priv); @@ -632,6 +668,49 @@ static int f81232_port_remove(struct usb_serial_port *port) return 0; } +static int f81232_suspend(struct usb_serial *serial, pm_message_t message) +{ + struct usb_serial_port *port = serial->port[0]; + struct f81232_private *port_priv = usb_get_serial_port_data(port); + int i; + + for (i = 0; i < ARRAY_SIZE(port->read_urbs); ++i) + usb_kill_urb(port->read_urbs[i]); + + usb_kill_urb(port->interrupt_in_urb); + + if (port_priv) + flush_work(&port_priv->lsr_work); + + return 0; +} + +static int f81232_resume(struct usb_serial *serial) +{ + struct usb_serial_port *port = serial->port[0]; + struct f81232_private *port_priv = usb_get_serial_port_data(port); + int result = 0; + + mutex_lock(&port_priv->lock); + + if (port_priv && port_priv->is_port_open) { + result = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); + if (result) { + dev_err(&port->dev, + "%s: submit interrupt urb failed: %d", + __func__, result); + goto end; + } + } + + result = usb_serial_generic_resume(serial); + +end: + mutex_unlock(&port_priv->lock); + + return result; +} + static struct usb_serial_driver f81232_device = { .driver = { .owner = THIS_MODULE, @@ -655,6 +734,8 @@ static struct usb_serial_driver f81232_device = { .read_int_callback = f81232_read_int_callback, .port_probe = f81232_port_probe, .port_remove = f81232_port_remove, + .suspend = f81232_suspend, + .resume = f81232_resume, }; static struct usb_serial_driver * const serial_drivers[] = { -- 2.7.4