From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [V8,1/4] USB: serial: f81232: clear overrun flag From: "Ji-Ze Hong \(Peter Hong\)" Message-Id: <1555641933-19336-1-git-send-email-hpeter+linux_kernel@gmail.com> Date: Fri, 19 Apr 2019 10:45:30 +0800 To: peter_hong@fintek.com.tw, johan@kernel.org, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Ji-Ze Hong \(Peter Hong\)" , Oliver Neukum List-ID: VGhlIEY4MTIzMiB3aWxsIHJlcG9ydCBkYXRhIGFuZCBMU1Igd2l0aCBidWxrIGxpa2UgZm9sbG93 aW5nIGZvcm1hdDoKYnVsay1pbiBkYXRhOiBbTFNSKDFCeXRlKStEQVRBKDFCeXRlKV1bTFNSKDFC eXRlKStEQVRBKDFCeXRlKV0uLi4KCkxTUiB3aWxsIGF1dG8gY2xlYXIgZnJhbWUvcGFyaXR5L2Jy ZWFrIGVycm9yIGZsYWcgd2hlbiByZWFkaW5nIGJ5IEgvVywKYnV0IG92ZXJycnVuIHdpbGwgb25s eSBjbGVhcmVkIHdoZW4gcmVhZGluZyBMU1IuIFNvIHRoaXMgcGF0Y2ggYWRkIGEKd29ya2VyIHRv IHJlYWQgTFNSIHdoZW4gb3ZlcnJ1biBhbmQgZmx1c2ggdGhlIHdvcmtlciBvbiBjbG9zZSgpICYK c3VzcGVuZCgpLgoKQ2M6IE9saXZlciBOZXVrdW0gPG9uZXVrdW1Ac3VzZS5jb20+ClNpZ25lZC1v ZmYtYnk6IEppLVplIEhvbmcgKFBldGVyIEhvbmcpIDxocGV0ZXIrbGludXhfa2VybmVsQGdtYWls LmNvbT4KLS0tCnY4OgoJMTogRml4IHVzYl9zdWJtaXRfdXJiKCkgaW4gZjgxMjMyX3Jlc3VtZSgp IHdpdGggR0ZQX05PSU8sIG5vdAoJICAgR0ZQX0tFUk5FTC4KCnY3OgoJMTogUmVtb3ZlIHNlcmlh bC0+c3VzcGVuZGluZyBjaGVjawoJMjogQWRkIHBvcnQgcHJpdiBpc19wb3J0X29wZW4gdG8gc2F2 ZSBwb3J0IG9wZW4gc3RhdGUuIFdlJ2xsCgkgICByZWdpc3RlciBpbnRlcnJ1cHQtaW4gdXJiIGlu IGY4MTIzMl9yZXN1bWUoKSB3aGVuIHBvcnQgaXMKCSAgIG9wZW5lZC4KCTM6IFVzaW5nIHVzYl9r aWxsX3VyYiBmb3IgcmVhZC9pbnRlcnJ1cHQgdXJiIHRvIGVuc3VyZSB1cmIKCSAgIHN0b3BwZWQu Cgp2NjoKCTE6IEFkZCBkZWZlcnJlZF9sc3Jfd29ya19uZWVkZWQgdG8gcmUtdHJpZ2dlciB3aGVu IGY4MTIzMl9yZXN1bWUoKQoKdjU6CgkxOiBTb3VyY2UgY29kZSBiYXNlIHJldmVydCB0byB2MyBh bmQgcmVtb3ZlIGFsbCB2NCBjaGFuZ2VzLgoJMjogQWRkIHNlcmlhbC0+c3VzcGVuZGluZyBjaGVj ayBpbiBmODEyMzJfcHJvY2Vzc19yZWFkX3VyYigpCgkgICBiZWZvcmUgc2NoZWR1bGVfd29yaygm cHJpdi0+bHNyX3dvcmspIHRvIGF2b2lkIHJhY2UgY29uZGl0aW9uLgoKdjQ6CgkxOiBBZGQgc2Vy aWFsLT5zdXNwZW5kaW5nIGNoZWNrIGluIGY4MTIzMl9sc3Jfd29ya2VyKCkgdG8gYXZvaWQKCSAg IHJlLXRyaWdnZXIKCTI6IEFkZCBwb3J0X3ByaXYtbHNyX3dvcmtfcmVzY2hlZCB0byByZS10cmln Z2VyIExTUiB3b3JrZXIKCnYzOgoJMTogQWRkIGZsdXNoX3dvcmsoJnBvcnRfcHJpdi0+bHNyX3dv cmspIGluIGY4MTIzMl9zdXNwZW5kKCkuCgp2MjoKCTE6IEFkZCBmbHVzaF93b3JrKCZwb3J0X3By aXYtPmxzcl93b3JrKSBpbiBmODEyMzJfY2xvc2UoKS4KCiBkcml2ZXJzL3VzYi9zZXJpYWwvZjgx MjMyLmMgfCA5NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0K IDEgZmlsZSBjaGFuZ2VkLCA4OSBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2RyaXZlcnMvdXNiL3NlcmlhbC9mODEyMzIuYyBiL2RyaXZlcnMvdXNiL3NlcmlhbC9m ODEyMzIuYwppbmRleCAwZGNkY2I0YjJjZGUuLjFmMGRkNDA4N2Q3OSAxMDA2NDQKLS0tIGEvZHJp dmVycy91c2Ivc2VyaWFsL2Y4MTIzMi5jCisrKyBiL2RyaXZlcnMvdXNiL3NlcmlhbC9mODEyMzIu YwpAQCAtNDEsMTIgKzQxLDE1IEBAIE1PRFVMRV9ERVZJQ0VfVEFCTEUodXNiLCBpZF90YWJsZSk7 CiAjZGVmaW5lIEZJRk9fQ09OVFJPTF9SRUdJU1RFUgkJKDB4MDIgKyBTRVJJQUxfQkFTRV9BRERS RVNTKQogI2RlZmluZSBMSU5FX0NPTlRST0xfUkVHSVNURVIJCSgweDAzICsgU0VSSUFMX0JBU0Vf QUREUkVTUykKICNkZWZpbmUgTU9ERU1fQ09OVFJPTF9SRUdJU1RFUgkJKDB4MDQgKyBTRVJJQUxf QkFTRV9BRERSRVNTKQorI2RlZmluZSBMSU5FX1NUQVRVU19SRUdJU1RFUgkJKDB4MDUgKyBTRVJJ QUxfQkFTRV9BRERSRVNTKQogI2RlZmluZSBNT0RFTV9TVEFUVVNfUkVHSVNURVIJCSgweDA2ICsg U0VSSUFMX0JBU0VfQUREUkVTUykKIAogc3RydWN0IGY4MTIzMl9wcml2YXRlIHsKIAlzdHJ1Y3Qg bXV0ZXggbG9jazsKIAl1OCBtb2RlbV9jb250cm9sOwogCXU4IG1vZGVtX3N0YXR1czsKKwlib29s IGlzX3BvcnRfb3BlbjsKKwlzdHJ1Y3Qgd29ya19zdHJ1Y3QgbHNyX3dvcms7CiAJc3RydWN0IHdv cmtfc3RydWN0IGludGVycnVwdF93b3JrOwogCXN0cnVjdCB1c2Jfc2VyaWFsX3BvcnQgKnBvcnQ7 CiB9OwpAQCAtMjgyLDYgKzI4NSw3IEBAIHN0YXRpYyB2b2lkIGY4MTIzMl9yZWFkX2ludF9jYWxs YmFjayhzdHJ1Y3QgdXJiICp1cmIpCiBzdGF0aWMgdm9pZCBmODEyMzJfcHJvY2Vzc19yZWFkX3Vy YihzdHJ1Y3QgdXJiICp1cmIpCiB7CiAJc3RydWN0IHVzYl9zZXJpYWxfcG9ydCAqcG9ydCA9IHVy Yi0+Y29udGV4dDsKKwlzdHJ1Y3QgZjgxMjMyX3ByaXZhdGUgKnByaXYgPSB1c2JfZ2V0X3Nlcmlh bF9wb3J0X2RhdGEocG9ydCk7CiAJdW5zaWduZWQgY2hhciAqZGF0YSA9IHVyYi0+dHJhbnNmZXJf YnVmZmVyOwogCWNoYXIgdHR5X2ZsYWc7CiAJdW5zaWduZWQgaW50IGk7CkBAIC0zMTUsNiArMzE5 LDcgQEAgc3RhdGljIHZvaWQgZjgxMjMyX3Byb2Nlc3NfcmVhZF91cmIoc3RydWN0IHVyYiAqdXJi KQogCiAJCQlpZiAobHNyICYgVUFSVF9MU1JfT0UpIHsKIAkJCQlwb3J0LT5pY291bnQub3ZlcnJ1 bisrOworCQkJCXNjaGVkdWxlX3dvcmsoJnByaXYtPmxzcl93b3JrKTsKIAkJCQl0dHlfaW5zZXJ0 X2ZsaXBfY2hhcigmcG9ydC0+cG9ydCwgMCwKIAkJCQkJCVRUWV9PVkVSUlVOKTsKIAkJCX0KQEAg LTUyOCwzNyArNTMzLDUyIEBAIHN0YXRpYyBpbnQgZjgxMjMyX3Rpb2Ntc2V0KHN0cnVjdCB0dHlf c3RydWN0ICp0dHksCiAKIHN0YXRpYyBpbnQgZjgxMjMyX29wZW4oc3RydWN0IHR0eV9zdHJ1Y3Qg KnR0eSwgc3RydWN0IHVzYl9zZXJpYWxfcG9ydCAqcG9ydCkKIHsKLQlpbnQgcmVzdWx0OwotCi0J cmVzdWx0ID0gZjgxMjMyX3BvcnRfZW5hYmxlKHBvcnQpOwotCWlmIChyZXN1bHQpCi0JCXJldHVy biByZXN1bHQ7CisJc3RydWN0IGY4MTIzMl9wcml2YXRlICpwb3J0X3ByaXYgPSB1c2JfZ2V0X3Nl cmlhbF9wb3J0X2RhdGEocG9ydCk7CisJaW50IHJlc3VsdCA9IDA7CiAKIAkvKiBTZXR1cCB0ZXJt aW9zICovCiAJaWYgKHR0eSkKIAkJZjgxMjMyX3NldF90ZXJtaW9zKHR0eSwgcG9ydCwgTlVMTCk7 CiAKKwltdXRleF9sb2NrKCZwb3J0X3ByaXYtPmxvY2spOworCisJcmVzdWx0ID0gZjgxMjMyX3Bv cnRfZW5hYmxlKHBvcnQpOworCWlmIChyZXN1bHQpCisJCWdvdG8gZW5kOworCiAJcmVzdWx0ID0g dXNiX3N1Ym1pdF91cmIocG9ydC0+aW50ZXJydXB0X2luX3VyYiwgR0ZQX0tFUk5FTCk7CiAJaWYg KHJlc3VsdCkgewogCQlkZXZfZXJyKCZwb3J0LT5kZXYsICIlcyAtIGZhaWxlZCBzdWJtaXR0aW5n IGludGVycnVwdCB1cmIsIgogCQkJIiBlcnJvciAlZFxuIiwgX19mdW5jX18sIHJlc3VsdCk7Ci0J CXJldHVybiByZXN1bHQ7CisJCWdvdG8gZW5kOwogCX0KIAogCXJlc3VsdCA9IHVzYl9zZXJpYWxf Z2VuZXJpY19vcGVuKHR0eSwgcG9ydCk7CiAJaWYgKHJlc3VsdCkgewogCQl1c2Jfa2lsbF91cmIo cG9ydC0+aW50ZXJydXB0X2luX3VyYik7Ci0JCXJldHVybiByZXN1bHQ7CisJCWdvdG8gZW5kOwog CX0KIAotCXJldHVybiAwOworCXBvcnRfcHJpdi0+aXNfcG9ydF9vcGVuID0gdHJ1ZTsKK2VuZDoK KwltdXRleF91bmxvY2soJnBvcnRfcHJpdi0+bG9jayk7CisKKwlyZXR1cm4gcmVzdWx0OwogfQog CiBzdGF0aWMgdm9pZCBmODEyMzJfY2xvc2Uoc3RydWN0IHVzYl9zZXJpYWxfcG9ydCAqcG9ydCkK IHsKKwlzdHJ1Y3QgZjgxMjMyX3ByaXZhdGUgKnBvcnRfcHJpdiA9IHVzYl9nZXRfc2VyaWFsX3Bv cnRfZGF0YShwb3J0KTsKKworCW11dGV4X2xvY2soJnBvcnRfcHJpdi0+bG9jayk7CisKIAlmODEy MzJfcG9ydF9kaXNhYmxlKHBvcnQpOwogCXVzYl9zZXJpYWxfZ2VuZXJpY19jbG9zZShwb3J0KTsK IAl1c2Jfa2lsbF91cmIocG9ydC0+aW50ZXJydXB0X2luX3VyYik7CisJZmx1c2hfd29yaygmcG9y dF9wcml2LT5sc3Jfd29yayk7CisJcG9ydF9wcml2LT5pc19wb3J0X29wZW4gPSBmYWxzZTsKKwor CW11dGV4X3VubG9jaygmcG9ydF9wcml2LT5sb2NrKTsKIH0KIAogc3RhdGljIHZvaWQgZjgxMjMy X2R0cl9ydHMoc3RydWN0IHVzYl9zZXJpYWxfcG9ydCAqcG9ydCwgaW50IG9uKQpAQCAtNjAzLDYg KzYyMywyMSBAQCBzdGF0aWMgdm9pZCAgZjgxMjMyX2ludGVycnVwdF93b3JrKHN0cnVjdCB3b3Jr X3N0cnVjdCAqd29yaykKIAlmODEyMzJfcmVhZF9tc3IocHJpdi0+cG9ydCk7CiB9CiAKK3N0YXRp YyB2b2lkIGY4MTIzMl9sc3Jfd29ya2VyKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKK3sKKwlz dHJ1Y3QgZjgxMjMyX3ByaXZhdGUgKnByaXY7CisJc3RydWN0IHVzYl9zZXJpYWxfcG9ydCAqcG9y dDsKKwlpbnQgc3RhdHVzOworCXU4IHRtcDsKKworCXByaXYgPSBjb250YWluZXJfb2Yod29yaywg c3RydWN0IGY4MTIzMl9wcml2YXRlLCBsc3Jfd29yayk7CisJcG9ydCA9IHByaXYtPnBvcnQ7CisK KwlzdGF0dXMgPSBmODEyMzJfZ2V0X3JlZ2lzdGVyKHBvcnQsIExJTkVfU1RBVFVTX1JFR0lTVEVS LCAmdG1wKTsKKwlpZiAoc3RhdHVzKQorCQlkZXZfd2FybigmcG9ydC0+ZGV2LCAicmVhZCBMU1Ig ZmFpbGVkOiAlZFxuIiwgc3RhdHVzKTsKK30KKwogc3RhdGljIGludCBmODEyMzJfcG9ydF9wcm9i ZShzdHJ1Y3QgdXNiX3NlcmlhbF9wb3J0ICpwb3J0KQogewogCXN0cnVjdCBmODEyMzJfcHJpdmF0 ZSAqcHJpdjsKQEAgLTYxMyw2ICs2NDgsNyBAQCBzdGF0aWMgaW50IGY4MTIzMl9wb3J0X3Byb2Jl KHN0cnVjdCB1c2Jfc2VyaWFsX3BvcnQgKnBvcnQpCiAKIAltdXRleF9pbml0KCZwcml2LT5sb2Nr KTsKIAlJTklUX1dPUksoJnByaXYtPmludGVycnVwdF93b3JrLCAgZjgxMjMyX2ludGVycnVwdF93 b3JrKTsKKwlJTklUX1dPUksoJnByaXYtPmxzcl93b3JrLCBmODEyMzJfbHNyX3dvcmtlcik7CiAK IAl1c2Jfc2V0X3NlcmlhbF9wb3J0X2RhdGEocG9ydCwgcHJpdik7CiAKQEAgLTYzMiw2ICs2Njgs NDkgQEAgc3RhdGljIGludCBmODEyMzJfcG9ydF9yZW1vdmUoc3RydWN0IHVzYl9zZXJpYWxfcG9y dCAqcG9ydCkKIAlyZXR1cm4gMDsKIH0KIAorc3RhdGljIGludCBmODEyMzJfc3VzcGVuZChzdHJ1 Y3QgdXNiX3NlcmlhbCAqc2VyaWFsLCBwbV9tZXNzYWdlX3QgbWVzc2FnZSkKK3sKKwlzdHJ1Y3Qg dXNiX3NlcmlhbF9wb3J0ICpwb3J0ID0gc2VyaWFsLT5wb3J0WzBdOworCXN0cnVjdCBmODEyMzJf cHJpdmF0ZSAqcG9ydF9wcml2ID0gdXNiX2dldF9zZXJpYWxfcG9ydF9kYXRhKHBvcnQpOworCWlu dCBpOworCisJZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUocG9ydC0+cmVhZF91cmJzKTsgKytp KQorCQl1c2Jfa2lsbF91cmIocG9ydC0+cmVhZF91cmJzW2ldKTsKKworCXVzYl9raWxsX3VyYihw b3J0LT5pbnRlcnJ1cHRfaW5fdXJiKTsKKworCWlmIChwb3J0X3ByaXYpCisJCWZsdXNoX3dvcmso JnBvcnRfcHJpdi0+bHNyX3dvcmspOworCisJcmV0dXJuIDA7Cit9CisKK3N0YXRpYyBpbnQgZjgx MjMyX3Jlc3VtZShzdHJ1Y3QgdXNiX3NlcmlhbCAqc2VyaWFsKQoreworCXN0cnVjdCB1c2Jfc2Vy aWFsX3BvcnQgKnBvcnQgPSBzZXJpYWwtPnBvcnRbMF07CisJc3RydWN0IGY4MTIzMl9wcml2YXRl ICpwb3J0X3ByaXYgPSB1c2JfZ2V0X3NlcmlhbF9wb3J0X2RhdGEocG9ydCk7CisJaW50IHJlc3Vs dCA9IDA7CisKKwltdXRleF9sb2NrKCZwb3J0X3ByaXYtPmxvY2spOworCisJaWYgKHBvcnRfcHJp diAmJiBwb3J0X3ByaXYtPmlzX3BvcnRfb3BlbikgeworCQlyZXN1bHQgPSB1c2Jfc3VibWl0X3Vy Yihwb3J0LT5pbnRlcnJ1cHRfaW5fdXJiLCBHRlBfTk9JTyk7CisJCWlmIChyZXN1bHQpIHsKKwkJ CWRldl9lcnIoJnBvcnQtPmRldiwKKwkJCQkJIiVzOiBzdWJtaXQgaW50ZXJydXB0IHVyYiBmYWls ZWQ6ICVkIiwKKwkJCQkJX19mdW5jX18sIHJlc3VsdCk7CisJCQlnb3RvIGVuZDsKKwkJfQorCX0K KworCXJlc3VsdCA9IHVzYl9zZXJpYWxfZ2VuZXJpY19yZXN1bWUoc2VyaWFsKTsKKworZW5kOgor CW11dGV4X3VubG9jaygmcG9ydF9wcml2LT5sb2NrKTsKKworCXJldHVybiByZXN1bHQ7Cit9CisK IHN0YXRpYyBzdHJ1Y3QgdXNiX3NlcmlhbF9kcml2ZXIgZjgxMjMyX2RldmljZSA9IHsKIAkuZHJp dmVyID0gewogCQkub3duZXIgPQlUSElTX01PRFVMRSwKQEAgLTY1NSw2ICs3MzQsOCBAQCBzdGF0 aWMgc3RydWN0IHVzYl9zZXJpYWxfZHJpdmVyIGY4MTIzMl9kZXZpY2UgPSB7CiAJLnJlYWRfaW50 X2NhbGxiYWNrID0JZjgxMjMyX3JlYWRfaW50X2NhbGxiYWNrLAogCS5wb3J0X3Byb2JlID0JCWY4 MTIzMl9wb3J0X3Byb2JlLAogCS5wb3J0X3JlbW92ZSA9CQlmODEyMzJfcG9ydF9yZW1vdmUsCisJ LnN1c3BlbmQgPQkJZjgxMjMyX3N1c3BlbmQsCisJLnJlc3VtZSA9CQlmODEyMzJfcmVzdW1lLAog fTsKIAogc3RhdGljIHN0cnVjdCB1c2Jfc2VyaWFsX2RyaXZlciAqIGNvbnN0IHNlcmlhbF9kcml2 ZXJzW10gPSB7Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 762CEC282DD for ; Fri, 19 Apr 2019 02:46:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 397762171F for ; Fri, 19 Apr 2019 02:46:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FZX2sySY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727193AbfDSCpn (ORCPT ); Thu, 18 Apr 2019 22:45:43 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:39127 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726822AbfDSCpn (ORCPT ); Thu, 18 Apr 2019 22:45:43 -0400 Received: by mail-pf1-f194.google.com with SMTP id i17so1958641pfo.6; Thu, 18 Apr 2019 19:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=bGjxE57b+sAJtijpBTPtqZ9fwf0KWs86liucmXiKgLc=; b=FZX2sySY0mAIx85oNvUgXhxW4/mChLYkZ3MLfwdE0bSjaFdcxeKGyvyLGn9KWw2xA4 a56YpT7SnA/kgLfsXUKIw0H8WhXIsVQC63BhyiFqtBh/DJ49Gz7ZVkk3admhaUCZbReB esalGMra5iMZnsyY+4zE1SWi0RG3bOtaAQKk2FLRMB1mMEOaD7Ilh2ST5NcrcmVLDUeU +RXCizDFRnSTCANhjj8voynyRSQF63xE3iqKAjJP8K2ksM3/RNymYQgyLg2F++sQFuKk K7VKIwuJNzcXr7KETSvhamXP/ApArbNZli+/ihFgzcGMbiZhcrU8IYge5ZVhQMJzZci6 0BSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bGjxE57b+sAJtijpBTPtqZ9fwf0KWs86liucmXiKgLc=; b=WO8MOOQuq1X7MNnQTzwnQHFp17atZ6Z2/Sx+oRlem4qU8XCa+BFo1o7r90RuIX4Zoe AmEsha1Y+8WARo24955HRpdxlNB/GjlhHihnFAbbYnOh1t18kGnx48m0g2hIwSC6tzoc pJmyWt5gXfWa6EuvCc7qSzWfSAs7IJMCeEYNj5AUBzMn7pb+KgSEBvgGbjKFcyVZL2Io c5dkYXA230U+INVx0Zz8VTeBmtTCX+PDb3FGmrInCUGgeqnczeiFyMmOZcEhdwA2I3Uz mZNuwChwBo9L8Amt8/jY+y8vcocJsqz6kI2mBVPtBQNZHK5zza9GUqhQKB0QuWZjmAvb 7cGA== X-Gm-Message-State: APjAAAUnJ7etr+DpIIBbD40fV1IKqvJbDsZo63pUvQP5StZm3YsI8v3+ 7cRBvuJWDRIIhYZpw8iYLfM= X-Google-Smtp-Source: APXvYqytEvGEN3UvH6ThjFtqihx/0qfRrRIxtpZJDUpo0KcNGbdmmPGz+7iaLwRYQQMXGYNZNCBCag== X-Received: by 2002:a63:1359:: with SMTP id 25mr1447049pgt.92.1555641942177; Thu, 18 Apr 2019 19:45:42 -0700 (PDT) Received: from localhost (59-120-186-245.HINET-IP.hinet.net. [59.120.186.245]) by smtp.gmail.com with ESMTPSA id c1sm3363317pgq.33.2019.04.18.19.45.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 19:45:41 -0700 (PDT) From: "Ji-Ze Hong (Peter Hong)" X-Google-Original-From: "Ji-Ze Hong (Peter Hong)" To: peter_hong@fintek.com.tw, johan@kernel.org, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Ji-Ze Hong (Peter Hong)" , Oliver Neukum Subject: [PATCH V8 1/4] USB: serial: f81232: clear overrun flag Date: Fri, 19 Apr 2019 10:45:30 +0800 Message-Id: <1555641933-19336-1-git-send-email-hpeter+linux_kernel@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Message-ID: <20190419024530.x4oFjO2tRuR4yIXKw5YgpZ5HX3o_h1BXmGhqZBIYtvE@z> The F81232 will report data and LSR with bulk like following format: bulk-in data: [LSR(1Byte)+DATA(1Byte)][LSR(1Byte)+DATA(1Byte)]... LSR will auto clear frame/parity/break error flag when reading by H/W, but overrrun will only cleared when reading LSR. So this patch add a worker to read LSR when overrun and flush the worker on close() & suspend(). Cc: Oliver Neukum Signed-off-by: Ji-Ze Hong (Peter Hong) --- v8: 1: Fix usb_submit_urb() in f81232_resume() with GFP_NOIO, not GFP_KERNEL. v7: 1: Remove serial->suspending check 2: Add port priv is_port_open to save port open state. We'll register interrupt-in urb in f81232_resume() when port is opened. 3: Using usb_kill_urb for read/interrupt urb to ensure urb stopped. v6: 1: Add deferred_lsr_work_needed to re-trigger when f81232_resume() v5: 1: Source code base revert to v3 and remove all v4 changes. 2: Add serial->suspending check in f81232_process_read_urb() before schedule_work(&priv->lsr_work) to avoid race condition. v4: 1: Add serial->suspending check in f81232_lsr_worker() to avoid re-trigger 2: Add port_priv-lsr_work_resched to re-trigger LSR worker v3: 1: Add flush_work(&port_priv->lsr_work) in f81232_suspend(). v2: 1: Add flush_work(&port_priv->lsr_work) in f81232_close(). drivers/usb/serial/f81232.c | 97 +++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 89 insertions(+), 8 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c index 0dcdcb4b2cde..1f0dd4087d79 100644 --- a/drivers/usb/serial/f81232.c +++ b/drivers/usb/serial/f81232.c @@ -41,12 +41,15 @@ MODULE_DEVICE_TABLE(usb, id_table); #define FIFO_CONTROL_REGISTER (0x02 + SERIAL_BASE_ADDRESS) #define LINE_CONTROL_REGISTER (0x03 + SERIAL_BASE_ADDRESS) #define MODEM_CONTROL_REGISTER (0x04 + SERIAL_BASE_ADDRESS) +#define LINE_STATUS_REGISTER (0x05 + SERIAL_BASE_ADDRESS) #define MODEM_STATUS_REGISTER (0x06 + SERIAL_BASE_ADDRESS) struct f81232_private { struct mutex lock; u8 modem_control; u8 modem_status; + bool is_port_open; + struct work_struct lsr_work; struct work_struct interrupt_work; struct usb_serial_port *port; }; @@ -282,6 +285,7 @@ static void f81232_read_int_callback(struct urb *urb) static void f81232_process_read_urb(struct urb *urb) { struct usb_serial_port *port = urb->context; + struct f81232_private *priv = usb_get_serial_port_data(port); unsigned char *data = urb->transfer_buffer; char tty_flag; unsigned int i; @@ -315,6 +319,7 @@ static void f81232_process_read_urb(struct urb *urb) if (lsr & UART_LSR_OE) { port->icount.overrun++; + schedule_work(&priv->lsr_work); tty_insert_flip_char(&port->port, 0, TTY_OVERRUN); } @@ -528,37 +533,52 @@ static int f81232_tiocmset(struct tty_struct *tty, static int f81232_open(struct tty_struct *tty, struct usb_serial_port *port) { - int result; - - result = f81232_port_enable(port); - if (result) - return result; + struct f81232_private *port_priv = usb_get_serial_port_data(port); + int result = 0; /* Setup termios */ if (tty) f81232_set_termios(tty, port, NULL); + mutex_lock(&port_priv->lock); + + result = f81232_port_enable(port); + if (result) + goto end; + result = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); if (result) { dev_err(&port->dev, "%s - failed submitting interrupt urb," " error %d\n", __func__, result); - return result; + goto end; } result = usb_serial_generic_open(tty, port); if (result) { usb_kill_urb(port->interrupt_in_urb); - return result; + goto end; } - return 0; + port_priv->is_port_open = true; +end: + mutex_unlock(&port_priv->lock); + + return result; } static void f81232_close(struct usb_serial_port *port) { + struct f81232_private *port_priv = usb_get_serial_port_data(port); + + mutex_lock(&port_priv->lock); + f81232_port_disable(port); usb_serial_generic_close(port); usb_kill_urb(port->interrupt_in_urb); + flush_work(&port_priv->lsr_work); + port_priv->is_port_open = false; + + mutex_unlock(&port_priv->lock); } static void f81232_dtr_rts(struct usb_serial_port *port, int on) @@ -603,6 +623,21 @@ static void f81232_interrupt_work(struct work_struct *work) f81232_read_msr(priv->port); } +static void f81232_lsr_worker(struct work_struct *work) +{ + struct f81232_private *priv; + struct usb_serial_port *port; + int status; + u8 tmp; + + priv = container_of(work, struct f81232_private, lsr_work); + port = priv->port; + + status = f81232_get_register(port, LINE_STATUS_REGISTER, &tmp); + if (status) + dev_warn(&port->dev, "read LSR failed: %d\n", status); +} + static int f81232_port_probe(struct usb_serial_port *port) { struct f81232_private *priv; @@ -613,6 +648,7 @@ static int f81232_port_probe(struct usb_serial_port *port) mutex_init(&priv->lock); INIT_WORK(&priv->interrupt_work, f81232_interrupt_work); + INIT_WORK(&priv->lsr_work, f81232_lsr_worker); usb_set_serial_port_data(port, priv); @@ -632,6 +668,49 @@ static int f81232_port_remove(struct usb_serial_port *port) return 0; } +static int f81232_suspend(struct usb_serial *serial, pm_message_t message) +{ + struct usb_serial_port *port = serial->port[0]; + struct f81232_private *port_priv = usb_get_serial_port_data(port); + int i; + + for (i = 0; i < ARRAY_SIZE(port->read_urbs); ++i) + usb_kill_urb(port->read_urbs[i]); + + usb_kill_urb(port->interrupt_in_urb); + + if (port_priv) + flush_work(&port_priv->lsr_work); + + return 0; +} + +static int f81232_resume(struct usb_serial *serial) +{ + struct usb_serial_port *port = serial->port[0]; + struct f81232_private *port_priv = usb_get_serial_port_data(port); + int result = 0; + + mutex_lock(&port_priv->lock); + + if (port_priv && port_priv->is_port_open) { + result = usb_submit_urb(port->interrupt_in_urb, GFP_NOIO); + if (result) { + dev_err(&port->dev, + "%s: submit interrupt urb failed: %d", + __func__, result); + goto end; + } + } + + result = usb_serial_generic_resume(serial); + +end: + mutex_unlock(&port_priv->lock); + + return result; +} + static struct usb_serial_driver f81232_device = { .driver = { .owner = THIS_MODULE, @@ -655,6 +734,8 @@ static struct usb_serial_driver f81232_device = { .read_int_callback = f81232_read_int_callback, .port_probe = f81232_port_probe, .port_remove = f81232_port_remove, + .suspend = f81232_suspend, + .resume = f81232_resume, }; static struct usb_serial_driver * const serial_drivers[] = { -- 2.7.4