From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,4/6] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun Message-Id: <1556261237-13823-5-git-send-email-chunfeng.yun@mediatek.com> Date: Fri, 26 Apr 2019 14:47:15 +0800 To: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus Cc: Mark Rutland , Chunfeng Yun , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Biju Das , Linus Walleij List-ID: QWRkIGZ3bm9kZV91c2Jfcm9sZV9zd2l0Y2hfZ2V0KCkgdG8gbWFrZSBlYXNpZXIgdG8gZ2V0CnVz Yl9yb2xlX3N3aXRjaCBieSBmd25vZGUgd2hpY2ggcmVnaXN0ZXIgaXQuCkl0J3MgdXNlZnVsIHdo ZW4gdGhlcmUgaXMgbm90IGRldmljZV9jb25uZWN0aW9uIHJlZ2lzdGVyZWQKYmV0d2VlbiB0d28g ZHJpdmVycyBhbmQgb25seSBrbm93cyB0aGUgZndub2RlIHdoaWNoIHJlZ2lzdGVyCnVzYl9yb2xl X3N3aXRjaC4KClNpZ25lZC1vZmYtYnk6IENodW5mZW5nIFl1biA8Y2h1bmZlbmcueXVuQG1lZGlh dGVrLmNvbT4KLS0tCnY0IGNoYW5nZXM6CiAgMS4gdXNlIHN3aXRjaF9md25vZGVfbWF0Y2goKSB0 byBmaW5kIGZ3bm9kZSBzdWdnZXN0ZWQgYnkgSGVpa2tpCiAgMi4gdGhpcyBwYXRjaCBub3cgZGVw ZW5kcyBvbiBbMV0KCiBbMV0gW3Y2LDA4LzEzXSB1c2I6IHJvbGVzOiBJbnRyb2R1Y2Ugc3R1YnMg Zm9yIHRoZSBleGl0aW5nIGZ1bmN0aW9ucyBpbiByb2xlLmgKICAgIGh0dHBzOi8vcGF0Y2h3b3Jr Lmtlcm5lbC5vcmcvcGF0Y2gvMTA5MDk5NzEvCgp2MyBjaGFuZ2VzOgogIDEuIHVzZSBmd25vZGVz IGluc3RlYWQgb2Ygbm9kZSBzdWdnZXN0ZWQgYnkgQW5keQogIDIuIHJlYnVpbGQgdGhlIEFQSSBz dWdnZXN0ZWQgYnkgSGVpa2tpCgp2MiBubyBjaGFuZ2VzCi0tLQogZHJpdmVycy91c2Ivcm9sZXMv Y2xhc3MuYyB8IDI1ICsrKysrKysrKysrKysrKysrKysrKysrKysKIGluY2x1ZGUvbGludXgvdXNi L3JvbGUuaCAgfCAgOCArKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCsp CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivcm9sZXMvY2xhc3MuYyBiL2RyaXZlcnMvdXNiL3Jv bGVzL2NsYXNzLmMKaW5kZXggZjQ1ZDhkZjVjZmI4Li45OTRmY2I5Nzk3OTUgMTAwNjQ0Ci0tLSBh L2RyaXZlcnMvdXNiL3JvbGVzL2NsYXNzLmMKKysrIGIvZHJpdmVycy91c2Ivcm9sZXMvY2xhc3Mu YwpAQCAtMTIsNiArMTIsNyBAQAogI2luY2x1ZGUgPGxpbnV4L2RldmljZS5oPgogI2luY2x1ZGUg PGxpbnV4L21vZHVsZS5oPgogI2luY2x1ZGUgPGxpbnV4L211dGV4Lmg+CisjaW5jbHVkZSA8bGlu dXgvb2YuaD4KICNpbmNsdWRlIDxsaW51eC9zbGFiLmg+CiAKIHN0YXRpYyBzdHJ1Y3QgY2xhc3Mg KnJvbGVfY2xhc3M7CkBAIC0xMzUsNiArMTM2LDMwIEBAIHN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2gg KnVzYl9yb2xlX3N3aXRjaF9nZXQoc3RydWN0IGRldmljZSAqZGV2KQogfQogRVhQT1JUX1NZTUJP TF9HUEwodXNiX3JvbGVfc3dpdGNoX2dldCk7CiAKKy8qKgorICogZndub2RlX3VzYl9yb2xlX3N3 aXRjaF9nZXQgLSBGaW5kIFVTQiByb2xlIHN3aXRjaCBieSBpdCdzIHBhcmVudCBmd25vZGUKKyAq IEBmd25vZGU6IFRoZSBmd25vZGUgdGhhdCByZWdpc3RlciBVU0Igcm9sZSBzd2l0Y2gKKyAqCisg KiBGaW5kcyBhbmQgcmV0dXJucyByb2xlIHN3aXRjaCByZWdpc3RlcmVkIGJ5IEBmd25vZGUuIFRo ZSByZWZlcmVuY2UgY291bnQKKyAqIGZvciB0aGUgZm91bmQgc3dpdGNoIGlzIGluY3JlbWVudGVk LgorICovCitzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICoKK2Z3bm9kZV91c2Jfcm9sZV9zd2l0Y2hf Z2V0KHN0cnVjdCBmd25vZGVfaGFuZGxlICpmd25vZGUpCit7CisJc3RydWN0IHVzYl9yb2xlX3N3 aXRjaCAqc3c7CisJc3RydWN0IGRldmljZSAqZGV2OworCisJZGV2ID0gY2xhc3NfZmluZF9kZXZp Y2Uocm9sZV9jbGFzcywgTlVMTCwgZndub2RlLCBzd2l0Y2hfZndub2RlX21hdGNoKTsKKwlpZiAo IWRldikKKwkJcmV0dXJuIEVSUl9QVFIoLUVQUk9CRV9ERUZFUik7CisKKwlzdyA9IHRvX3JvbGVf c3dpdGNoKGRldik7CisJV0FSTl9PTighdHJ5X21vZHVsZV9nZXQoc3ctPmRldi5wYXJlbnQtPmRy aXZlci0+b3duZXIpKTsKKworCXJldHVybiBzdzsKK30KK0VYUE9SVF9TWU1CT0xfR1BMKGZ3bm9k ZV91c2Jfcm9sZV9zd2l0Y2hfZ2V0KTsKKwogLyoqCiAgKiB1c2Jfcm9sZV9zd2l0Y2hfcHV0IC0g UmVsZWFzZSBoYW5kbGUgdG8gYSBzd2l0Y2gKICAqIEBzdzogVVNCIFJvbGUgU3dpdGNoCmRpZmYg LS1naXQgYS9pbmNsdWRlL2xpbnV4L3VzYi9yb2xlLmggYi9pbmNsdWRlL2xpbnV4L3VzYi9yb2xl LmgKaW5kZXggZGEyYjk2NDFiODc3Li4zNWQ0NjBmOWVjNDAgMTAwNjQ0Ci0tLSBhL2luY2x1ZGUv bGludXgvdXNiL3JvbGUuaAorKysgYi9pbmNsdWRlL2xpbnV4L3VzYi9yb2xlLmgKQEAgLTQ4LDYg KzQ4LDggQEAgaW50IHVzYl9yb2xlX3N3aXRjaF9zZXRfcm9sZShzdHJ1Y3QgdXNiX3JvbGVfc3dp dGNoICpzdywgZW51bSB1c2Jfcm9sZSByb2xlKTsKIGVudW0gdXNiX3JvbGUgdXNiX3JvbGVfc3dp dGNoX2dldF9yb2xlKHN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2ggKnN3KTsKIHN0cnVjdCB1c2Jfcm9s ZV9zd2l0Y2ggKnVzYl9yb2xlX3N3aXRjaF9nZXQoc3RydWN0IGRldmljZSAqZGV2KTsKIHZvaWQg dXNiX3JvbGVfc3dpdGNoX3B1dChzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICpzdyk7CitzdHJ1Y3Qg dXNiX3JvbGVfc3dpdGNoICoKK2Z3bm9kZV91c2Jfcm9sZV9zd2l0Y2hfZ2V0KHN0cnVjdCBmd25v ZGVfaGFuZGxlICpmd25vZGUpOwogCiBzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICoKIHVzYl9yb2xl X3N3aXRjaF9yZWdpc3RlcihzdHJ1Y3QgZGV2aWNlICpwYXJlbnQsCkBAIC03Miw2ICs3NCwxMiBA QCBzdGF0aWMgaW5saW5lIHN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2ggKnVzYl9yb2xlX3N3aXRjaF9n ZXQoc3RydWN0IGRldmljZSAqZGV2KQogCiBzdGF0aWMgaW5saW5lIHZvaWQgdXNiX3JvbGVfc3dp dGNoX3B1dChzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICpzdykgeyB9CiAKK3N0YXRpYyBpbmxpbmUg c3RydWN0IHVzYl9yb2xlX3N3aXRjaCAqCitmd25vZGVfdXNiX3JvbGVfc3dpdGNoX2dldChzdHJ1 Y3QgZndub2RlX2hhbmRsZSAqZndub2RlKQoreworCXJldHVybiBFUlJfUFRSKC1FTk9ERVYpOwor fQorCiBzdGF0aWMgaW5saW5lIHN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2ggKgogdXNiX3JvbGVfc3dp dGNoX3JlZ2lzdGVyKHN0cnVjdCBkZXZpY2UgKnBhcmVudCwKIAkJCSBjb25zdCBzdHJ1Y3QgdXNi X3JvbGVfc3dpdGNoX2Rlc2MgKmRlc2MpCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A3BC43218 for ; Fri, 26 Apr 2019 06:47:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3096D206DD for ; Fri, 26 Apr 2019 06:47:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725942AbfDZGru (ORCPT ); Fri, 26 Apr 2019 02:47:50 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:30606 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725901AbfDZGru (ORCPT ); Fri, 26 Apr 2019 02:47:50 -0400 X-UUID: 2b670c16918c4daa9fff884702ae7fc9-20190426 X-UUID: 2b670c16918c4daa9fff884702ae7fc9-20190426 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 2088178522; Fri, 26 Apr 2019 14:47:40 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 26 Apr 2019 14:47:38 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 26 Apr 2019 14:47:37 +0800 From: Chunfeng Yun To: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus CC: Mark Rutland , Chunfeng Yun , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , , , , , , Biju Das , Linus Walleij Subject: [PATCH v4 4/6] usb: roles: add API to get usb_role_switch by node Date: Fri, 26 Apr 2019 14:47:15 +0800 Message-ID: <1556261237-13823-5-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-MTK: N Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190426064715.Y0BnziaF3JLfBQBZ2uhilzuSHL4bh2e5YygxAqaL8bI@z> Add fwnode_usb_role_switch_get() to make easier to get usb_role_switch by fwnode which register it. It's useful when there is not device_connection registered between two drivers and only knows the fwnode which register usb_role_switch. Signed-off-by: Chunfeng Yun --- v4 changes: 1. use switch_fwnode_match() to find fwnode suggested by Heikki 2. this patch now depends on [1] [1] [v6,08/13] usb: roles: Introduce stubs for the exiting functions in role.h https://patchwork.kernel.org/patch/10909971/ v3 changes: 1. use fwnodes instead of node suggested by Andy 2. rebuild the API suggested by Heikki v2 no changes --- drivers/usb/roles/class.c | 25 +++++++++++++++++++++++++ include/linux/usb/role.h | 8 ++++++++ 2 files changed, 33 insertions(+) diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c index f45d8df5cfb8..994fcb979795 100644 --- a/drivers/usb/roles/class.c +++ b/drivers/usb/roles/class.c @@ -12,6 +12,7 @@ #include #include #include +#include #include static struct class *role_class; @@ -135,6 +136,30 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev) } EXPORT_SYMBOL_GPL(usb_role_switch_get); +/** + * fwnode_usb_role_switch_get - Find USB role switch by it's parent fwnode + * @fwnode: The fwnode that register USB role switch + * + * Finds and returns role switch registered by @fwnode. The reference count + * for the found switch is incremented. + */ +struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) +{ + struct usb_role_switch *sw; + struct device *dev; + + dev = class_find_device(role_class, NULL, fwnode, switch_fwnode_match); + if (!dev) + return ERR_PTR(-EPROBE_DEFER); + + sw = to_role_switch(dev); + WARN_ON(!try_module_get(sw->dev.parent->driver->owner)); + + return sw; +} +EXPORT_SYMBOL_GPL(fwnode_usb_role_switch_get); + /** * usb_role_switch_put - Release handle to a switch * @sw: USB Role Switch diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h index da2b9641b877..35d460f9ec40 100644 --- a/include/linux/usb/role.h +++ b/include/linux/usb/role.h @@ -48,6 +48,8 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); struct usb_role_switch *usb_role_switch_get(struct device *dev); void usb_role_switch_put(struct usb_role_switch *sw); +struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode); struct usb_role_switch * usb_role_switch_register(struct device *parent, @@ -72,6 +74,12 @@ static inline struct usb_role_switch *usb_role_switch_get(struct device *dev) static inline void usb_role_switch_put(struct usb_role_switch *sw) { } +static inline struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) +{ + return ERR_PTR(-ENODEV); +} + static inline struct usb_role_switch * usb_role_switch_register(struct device *parent, const struct usb_role_switch_desc *desc) -- 2.21.0