From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,4/6] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun Message-Id: <1556262995.10179.209.camel@mhfsdcap03> Date: Fri, 26 Apr 2019 15:16:35 +0800 To: Biju Das Cc: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Linus Walleij List-ID: SGkgQmlqdSwKT24gRnJpLCAyMDE5LTA0LTI2IGF0IDA3OjAyICswMDAwLCBCaWp1IERhcyB3cm90 ZToKPiBIaSBDaHVuZmVuZyBZdW4sCj4gCj4gVGhhbmtzIGZvciB0aGUgcGF0Y2guCj4gCj4gPiBT dWJqZWN0OiBbUEFUQ0ggdjQgNC82XSB1c2I6IHJvbGVzOiBhZGQgQVBJIHRvIGdldCB1c2Jfcm9s ZV9zd2l0Y2ggYnkgbm9kZQo+ID4gCj4gPiBBZGQgZndub2RlX3VzYl9yb2xlX3N3aXRjaF9nZXQo KSB0byBtYWtlIGVhc2llciB0byBnZXQgdXNiX3JvbGVfc3dpdGNoCj4gPiBieSBmd25vZGUgd2hp Y2ggcmVnaXN0ZXIgaXQuCj4gPiBJdCdzIHVzZWZ1bCB3aGVuIHRoZXJlIGlzIG5vdCBkZXZpY2Vf Y29ubmVjdGlvbiByZWdpc3RlcmVkIGJldHdlZW4gdHdvCj4gPiBkcml2ZXJzIGFuZCBvbmx5IGtu b3dzIHRoZSBmd25vZGUgd2hpY2ggcmVnaXN0ZXIgdXNiX3JvbGVfc3dpdGNoLgo+ID4gCj4gPiBT aWduZWQtb2ZmLWJ5OiBDaHVuZmVuZyBZdW4gPGNodW5mZW5nLnl1bkBtZWRpYXRlay5jb20+Cj4g VGVzdGVkLWJ5OiBCaWp1IERhcyA8YmlqdS5kYXNAYnAucmVuZXNhcy5jb20+Cj4gPiAtLS0KPiA+ IHY0IGNoYW5nZXM6Cj4gPiAgIDEuIHVzZSBzd2l0Y2hfZndub2RlX21hdGNoKCkgdG8gZmluZCBm d25vZGUgc3VnZ2VzdGVkIGJ5IEhlaWtraQo+ID4gICAyLiB0aGlzIHBhdGNoIG5vdyBkZXBlbmRz IG9uIFsxXQo+ID4gCj4gPiAgWzFdIFt2NiwwOC8xM10gdXNiOiByb2xlczogSW50cm9kdWNlIHN0 dWJzIGZvciB0aGUgZXhpdGluZyBmdW5jdGlvbnMgaW4gcm9sZS5oCj4gPiAgICAgaHR0cHM6Ly9w YXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDkwOTk3MS8KPiA+IAo+ID4gdjMgY2hhbmdlczoK PiA+ICAgMS4gdXNlIGZ3bm9kZXMgaW5zdGVhZCBvZiBub2RlIHN1Z2dlc3RlZCBieSBBbmR5Cj4g PiAgIDIuIHJlYnVpbGQgdGhlIEFQSSBzdWdnZXN0ZWQgYnkgSGVpa2tpCj4gPiAKPiA+IHYyIG5v IGNoYW5nZXMKPiA+IC0tLQo+ID4gIGRyaXZlcnMvdXNiL3JvbGVzL2NsYXNzLmMgfCAyNSArKysr KysrKysrKysrKysrKysrKysrKysrCj4gPiBpbmNsdWRlL2xpbnV4L3VzYi9yb2xlLmggIHwgIDgg KysrKysrKysKPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKykKPiA+IAo+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3JvbGVzL2NsYXNzLmMgYi9kcml2ZXJzL3VzYi9yb2xl cy9jbGFzcy5jIGluZGV4Cj4gPiBmNDVkOGRmNWNmYjguLjk5NGZjYjk3OTc5NSAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvdXNiL3JvbGVzL2NsYXNzLmMKPiA+ICsrKyBiL2RyaXZlcnMvdXNiL3Jv bGVzL2NsYXNzLmMKPiA+IEBAIC0xMiw2ICsxMiw3IEBACj4gPiAgI2luY2x1ZGUgPGxpbnV4L2Rl dmljZS5oPgo+ID4gICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KPiA+ICAjaW5jbHVkZSA8bGlu dXgvbXV0ZXguaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvb2YuaD4KPiAKPiBJcyBpdCByZXF1aXJl ZD8KRm9yZ290IHRvIHJlbW92ZSBpdCBhZnRlciB1c2luZyBmd25vZGUgaW5zdGVhZCBvZiBub2Rl LCB3aWxsIHJlbW92ZSBpdAppbiBuZXh0IHZlcnNpb24KClRoYW5rcyBhIGxvdAoKPiAKPiA+ICAj aW5jbHVkZSA8bGludXgvc2xhYi5oPgo+ID4gCj4gPiAgc3RhdGljIHN0cnVjdCBjbGFzcyAqcm9s ZV9jbGFzczsKPiA+IEBAIC0xMzUsNiArMTM2LDMwIEBAIHN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2gg KnVzYl9yb2xlX3N3aXRjaF9nZXQoc3RydWN0Cj4gPiBkZXZpY2UgKmRldikgIH0gIEVYUE9SVF9T WU1CT0xfR1BMKHVzYl9yb2xlX3N3aXRjaF9nZXQpOwo+ID4gCj4gPiArLyoqCj4gPiArICogZndu b2RlX3VzYl9yb2xlX3N3aXRjaF9nZXQgLSBGaW5kIFVTQiByb2xlIHN3aXRjaCBieSBpdCdzIHBh cmVudAo+ID4gK2Z3bm9kZQo+ID4gKyAqIEBmd25vZGU6IFRoZSBmd25vZGUgdGhhdCByZWdpc3Rl ciBVU0Igcm9sZSBzd2l0Y2gKPiA+ICsgKgo+ID4gKyAqIEZpbmRzIGFuZCByZXR1cm5zIHJvbGUg c3dpdGNoIHJlZ2lzdGVyZWQgYnkgQGZ3bm9kZS4gVGhlIHJlZmVyZW5jZQo+ID4gK2NvdW50Cj4g PiArICogZm9yIHRoZSBmb3VuZCBzd2l0Y2ggaXMgaW5jcmVtZW50ZWQuCj4gPiArICovCj4gPiAr c3RydWN0IHVzYl9yb2xlX3N3aXRjaCAqCj4gPiArZndub2RlX3VzYl9yb2xlX3N3aXRjaF9nZXQo c3RydWN0IGZ3bm9kZV9oYW5kbGUgKmZ3bm9kZSkgewo+ID4gKwlzdHJ1Y3QgdXNiX3JvbGVfc3dp dGNoICpzdzsKPiA+ICsJc3RydWN0IGRldmljZSAqZGV2Owo+ID4gKwo+ID4gKwlkZXYgPSBjbGFz c19maW5kX2RldmljZShyb2xlX2NsYXNzLCBOVUxMLCBmd25vZGUsCj4gPiBzd2l0Y2hfZndub2Rl X21hdGNoKTsKPiA+ICsJaWYgKCFkZXYpCj4gPiArCQlyZXR1cm4gRVJSX1BUUigtRVBST0JFX0RF RkVSKTsKPiA+ICsKPiA+ICsJc3cgPSB0b19yb2xlX3N3aXRjaChkZXYpOwo+ID4gKwlXQVJOX09O KCF0cnlfbW9kdWxlX2dldChzdy0+ZGV2LnBhcmVudC0+ZHJpdmVyLT5vd25lcikpOwo+ID4gKwo+ ID4gKwlyZXR1cm4gc3c7Cj4gPiArfQo+ID4gK0VYUE9SVF9TWU1CT0xfR1BMKGZ3bm9kZV91c2Jf cm9sZV9zd2l0Y2hfZ2V0KTsKPiA+ICsKPiA+ICAvKioKPiA+ICAgKiB1c2Jfcm9sZV9zd2l0Y2hf cHV0IC0gUmVsZWFzZSBoYW5kbGUgdG8gYSBzd2l0Y2gKPiA+ICAgKiBAc3c6IFVTQiBSb2xlIFN3 aXRjaAo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvdXNiL3JvbGUuaCBiL2luY2x1ZGUv bGludXgvdXNiL3JvbGUuaCBpbmRleAo+ID4gZGEyYjk2NDFiODc3Li4zNWQ0NjBmOWVjNDAgMTAw NjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3VzYi9yb2xlLmgKPiA+ICsrKyBiL2luY2x1ZGUv bGludXgvdXNiL3JvbGUuaAo+ID4gQEAgLTQ4LDYgKzQ4LDggQEAgaW50IHVzYl9yb2xlX3N3aXRj aF9zZXRfcm9sZShzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoCj4gPiAqc3csIGVudW0gdXNiX3JvbGUg cm9sZSk7ICBlbnVtIHVzYl9yb2xlIHVzYl9yb2xlX3N3aXRjaF9nZXRfcm9sZShzdHJ1Y3QKPiA+ IHVzYl9yb2xlX3N3aXRjaCAqc3cpOyAgc3RydWN0IHVzYl9yb2xlX3N3aXRjaCAqYyhzdHJ1Y3QK PiA+IGRldmljZSAqZGV2KTsgIHZvaWQgdXNiX3JvbGVfc3dpdGNoX3B1dChzdHJ1Y3QgdXNiX3Jv bGVfc3dpdGNoICpzdyk7Cj4gPiArc3RydWN0IHVzYl9yb2xlX3N3aXRjaCAqCj4gPiArZndub2Rl X3VzYl9yb2xlX3N3aXRjaF9nZXQoc3RydWN0IGZ3bm9kZV9oYW5kbGUgKmZ3bm9kZSk7Cj4gCj4g PiAgc3RydWN0IHVzYl9yb2xlX3N3aXRjaCAqCj4gPiAgdXNiX3JvbGVfc3dpdGNoX3JlZ2lzdGVy KHN0cnVjdCBkZXZpY2UgKnBhcmVudCwgQEAgLTcyLDYgKzc0LDEyIEBAIHN0YXRpYwo+ID4gaW5s aW5lIHN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2ggKnVzYl9yb2xlX3N3aXRjaF9nZXQoc3RydWN0IGRl dmljZSAqZGV2KQo+ID4gCj4gPiAgc3RhdGljIGlubGluZSB2b2lkIHVzYl9yb2xlX3N3aXRjaF9w dXQoc3RydWN0IHVzYl9yb2xlX3N3aXRjaCAqc3cpIHsgfQo+ID4gCj4gPiArc3RhdGljIGlubGlu ZSBzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICoKPiA+ICtmd25vZGVfdXNiX3JvbGVfc3dpdGNoX2dl dChzdHJ1Y3QgZndub2RlX2hhbmRsZSAqZndub2RlKSB7Cj4gPiArCXJldHVybiBFUlJfUFRSKC1F Tk9ERVYpOwo+ID4gK30KPiA+ICsKPiAKPiA+ICBzdGF0aWMgaW5saW5lIHN0cnVjdCB1c2Jfcm9s ZV9zd2l0Y2ggKgo+ID4gIHVzYl9yb2xlX3N3aXRjaF9yZWdpc3RlcihzdHJ1Y3QgZGV2aWNlICpw YXJlbnQsCj4gPiAgCQkJIGNvbnN0IHN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2hfZGVzYyAqZGVzYykK PiA+IC0tCj4gPiAyLjIxLjAKPgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59688C43218 for ; Fri, 26 Apr 2019 07:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34A282084F for ; Fri, 26 Apr 2019 07:16:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725965AbfDZHQq (ORCPT ); Fri, 26 Apr 2019 03:16:46 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:5904 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725893AbfDZHQq (ORCPT ); Fri, 26 Apr 2019 03:16:46 -0400 X-UUID: e68ea29a041c48dba8209f091923ef2b-20190426 X-UUID: e68ea29a041c48dba8209f091923ef2b-20190426 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 635092751; Fri, 26 Apr 2019 15:16:38 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 26 Apr 2019 15:16:36 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 26 Apr 2019 15:16:35 +0800 Message-ID: <1556262995.10179.209.camel@mhfsdcap03> Subject: RE: [PATCH v4 4/6] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun To: Biju Das CC: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , "Badhri Jagan Sridharan" , Hans de Goede , Andy Shevchenko , Min Guo , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Linus Walleij Date: Fri, 26 Apr 2019 15:16:35 +0800 In-Reply-To: References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> <1556261237-13823-5-git-send-email-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190426071635.3HR6yeHaTjTg1DO4Mb3LIol7ZfG-diRYnV6cDOtDR58@z> Hi Biju, On Fri, 2019-04-26 at 07:02 +0000, Biju Das wrote: > Hi Chunfeng Yun, > > Thanks for the patch. > > > Subject: [PATCH v4 4/6] usb: roles: add API to get usb_role_switch by node > > > > Add fwnode_usb_role_switch_get() to make easier to get usb_role_switch > > by fwnode which register it. > > It's useful when there is not device_connection registered between two > > drivers and only knows the fwnode which register usb_role_switch. > > > > Signed-off-by: Chunfeng Yun > Tested-by: Biju Das > > --- > > v4 changes: > > 1. use switch_fwnode_match() to find fwnode suggested by Heikki > > 2. this patch now depends on [1] > > > > [1] [v6,08/13] usb: roles: Introduce stubs for the exiting functions in role.h > > https://patchwork.kernel.org/patch/10909971/ > > > > v3 changes: > > 1. use fwnodes instead of node suggested by Andy > > 2. rebuild the API suggested by Heikki > > > > v2 no changes > > --- > > drivers/usb/roles/class.c | 25 +++++++++++++++++++++++++ > > include/linux/usb/role.h | 8 ++++++++ > > 2 files changed, 33 insertions(+) > > > > diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c index > > f45d8df5cfb8..994fcb979795 100644 > > --- a/drivers/usb/roles/class.c > > +++ b/drivers/usb/roles/class.c > > @@ -12,6 +12,7 @@ > > #include > > #include > > #include > > +#include > > Is it required? Forgot to remove it after using fwnode instead of node, will remove it in next version Thanks a lot > > > #include > > > > static struct class *role_class; > > @@ -135,6 +136,30 @@ struct usb_role_switch *usb_role_switch_get(struct > > device *dev) } EXPORT_SYMBOL_GPL(usb_role_switch_get); > > > > +/** > > + * fwnode_usb_role_switch_get - Find USB role switch by it's parent > > +fwnode > > + * @fwnode: The fwnode that register USB role switch > > + * > > + * Finds and returns role switch registered by @fwnode. The reference > > +count > > + * for the found switch is incremented. > > + */ > > +struct usb_role_switch * > > +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) { > > + struct usb_role_switch *sw; > > + struct device *dev; > > + > > + dev = class_find_device(role_class, NULL, fwnode, > > switch_fwnode_match); > > + if (!dev) > > + return ERR_PTR(-EPROBE_DEFER); > > + > > + sw = to_role_switch(dev); > > + WARN_ON(!try_module_get(sw->dev.parent->driver->owner)); > > + > > + return sw; > > +} > > +EXPORT_SYMBOL_GPL(fwnode_usb_role_switch_get); > > + > > /** > > * usb_role_switch_put - Release handle to a switch > > * @sw: USB Role Switch > > diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h index > > da2b9641b877..35d460f9ec40 100644 > > --- a/include/linux/usb/role.h > > +++ b/include/linux/usb/role.h > > @@ -48,6 +48,8 @@ int usb_role_switch_set_role(struct usb_role_switch > > *sw, enum usb_role role); enum usb_role usb_role_switch_get_role(struct > > usb_role_switch *sw); struct usb_role_switch *c(struct > > device *dev); void usb_role_switch_put(struct usb_role_switch *sw); > > +struct usb_role_switch * > > +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode); > > > struct usb_role_switch * > > usb_role_switch_register(struct device *parent, @@ -72,6 +74,12 @@ static > > inline struct usb_role_switch *usb_role_switch_get(struct device *dev) > > > > static inline void usb_role_switch_put(struct usb_role_switch *sw) { } > > > > +static inline struct usb_role_switch * > > +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) { > > + return ERR_PTR(-ENODEV); > > +} > > + > > > static inline struct usb_role_switch * > > usb_role_switch_register(struct device *parent, > > const struct usb_role_switch_desc *desc) > > -- > > 2.21.0 >