From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,5/6] usb: roles: add USB Type-B GPIO connector driver From: Chunfeng Yun Message-Id: <1556443596.10179.212.camel@mhfsdcap03> Date: Sun, 28 Apr 2019 17:26:36 +0800 To: Biju Das Cc: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" List-ID: SGkgQmlqdSwKT24gRnJpLCAyMDE5LTA0LTI2IGF0IDA5OjIyICswMDAwLCBCaWp1IERhcyB3cm90 ZToKPiBIaSBDaHVuZmVuZyBZdW4sCj4gCj4gVGhhbmtzIGZvciB0aGUgcGF0Y2guCj4gCj4gPiBT dWJqZWN0OiBbUEFUQ0ggdjQgNS82XSB1c2I6IHJvbGVzOiBhZGQgVVNCIFR5cGUtQiBHUElPIGNv bm5lY3RvciBkcml2ZXIKPiA+IAo+ID4gRHVlIHRvIHRoZSByZXF1aXJlbWVudCBvZiB1c2ItY29u bmVjdG9yLnR4dCBiaW5kaW5nLCB0aGUgb2xkIHdheSB1c2luZwo+ID4gZXh0Y29uIHRvIHN1cHBv cnQgVVNCIER1YWwtUm9sZSBzd2l0Y2ggaXMgbm93IGRlcHJlY2F0ZWQgd2hlbiB1c2UgVHlwZS1C Cj4gPiBjb25uZWN0b3IuCj4gPiBUaGlzIHBhdGNoIGludHJvZHVjZXMgYSBkcml2ZXIgb2YgVHlw ZS1CIGNvbm5lY3RvciB3aGljaCB0eXBpY2FsbHkgdXNlcyBhbgo+ID4gaW5wdXQgR1BJTyB0byBk ZXRlY3QgVVNCIElEIHBpbiwgYW5kIHRyeSB0byByZXBsYWNlIHRoZSBmdW5jdGlvbiBwcm92aWRl ZCBieQo+ID4gZXh0Y29uLXVzYi1ncGlvIGRyaXZlcgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBD aHVuZmVuZyBZdW4gPGNodW5mZW5nLnl1bkBtZWRpYXRlay5jb20+Cj4gPiAtLS0KPiA+IHY0IGNo YW5nZXM6Cj4gPiAgIDEuIHJlbW92ZSBsaW51eC9ncGlvLmggc3VnZ2VzdGVkIGJ5IExpbnVzCj4g PiAgIDIuIHB1dCBub2RlIHdoZW4gZXJyb3IgaGFwcGVucwo+ID4gCj4gPiB2MyBjaGFuZ2VzOgo+ ID4gICAxLiB0cmVhdCBieXBlLUIgY29ubmVjdG9yIGFzIGEgdmlydHVhbCBkZXZpY2U7Cj4gPiAg IDIuIGNoYW5nZSBmaWxlIG5hbWUgYWdhaW4KPiA+IAo+ID4gdjIgY2hhbmdlczoKPiA+ICAgMS4g ZmlsZSBuYW1lIGlzIGNoYW5nZWQKPiA+ICAgMi4gdXNlIG5ldyBjb21wYXRpYmxlCj4gPiAtLS0K PiA+ICBkcml2ZXJzL3VzYi9yb2xlcy9LY29uZmlnICAgICAgICAgICB8ICAxMSArCj4gPiAgZHJp dmVycy91c2Ivcm9sZXMvTWFrZWZpbGUgICAgICAgICAgfCAgIDEgKwo+ID4gIGRyaXZlcnMvdXNi L3JvbGVzL3R5cGViLWNvbm4tZ3Bpby5jIHwgMzA1Cj4gPiArKysrKysrKysrKysrKysrKysrKysr KysrKysrCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAzMTcgaW5zZXJ0aW9ucygrKQo+ID4gIGNyZWF0 ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL3VzYi9yb2xlcy90eXBlYi1jb25uLWdwaW8uYwo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivcm9sZXMvS2NvbmZpZyBiL2RyaXZlcnMvdXNiL3Jv bGVzL0tjb25maWcgaW5kZXgKPiA+IGY4YjMxYWE2NzUyNi4uZDExNTZlMThhODFhIDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy91c2Ivcm9sZXMvS2NvbmZpZwo+ID4gKysrIGIvZHJpdmVycy91c2Iv cm9sZXMvS2NvbmZpZwo+ID4gQEAgLTI2LDQgKzI2LDE1IEBAIGNvbmZpZyBVU0JfUk9MRVNfSU5U RUxfWEhDSQo+ID4gIAkgIFRvIGNvbXBpbGUgdGhlIGRyaXZlciBhcyBhIG1vZHVsZSwgY2hvb3Nl IE0gaGVyZTogdGhlIG1vZHVsZSB3aWxsCj4gPiAgCSAgYmUgY2FsbGVkIGludGVsLXhoY2ktdXNi LXJvbGUtc3dpdGNoLgo+ID4gCj4gPiArY29uZmlnIFRZUEVCX0NPTk5fR1BJTwo+ID4gKwl0cmlz dGF0ZSAiVVNCIFR5cGUtQiBHUElPIENvbm5lY3RvciIKPiA+ICsJZGVwZW5kcyBvbiBHUElPTElC Cj4gPiArCWhlbHAKPiA+ICsJICBUaGUgZHJpdmVyIHN1cHBvcnRzIFVTQiByb2xlIHN3aXRjaCBi ZXR3ZWVuIGhvc3QgYW5kIGRldmljZSB2aWEKPiA+IEdQSU8KPiA+ICsJICBiYXNlZCBVU0IgY2Fi bGUgZGV0ZWN0aW9uLCB1c2VkIHR5cGljYWxseSBpZiBhbiBpbnB1dCBHUElPIGlzIHVzZWQKPiA+ ICsJICB0byBkZXRlY3QgVVNCIElEIHBpbi4KPiA+ICsKPiA+ICsJICBUbyBjb21waWxlIHRoZSBk cml2ZXIgYXMgYSBtb2R1bGUsIGNob29zZSBNIGhlcmU6IHRoZSBtb2R1bGUgd2lsbAo+ID4gKwkg IGJlIGNhbGxlZCB0eXBlYi1jb25uLWdwaW8ua28KPiA+ICsKPiA+ICBlbmRpZiAjIFVTQl9ST0xF X1NXSVRDSAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3JvbGVzL01ha2VmaWxlIGIvZHJp dmVycy91c2Ivcm9sZXMvTWFrZWZpbGUgaW5kZXgKPiA+IDc1N2E3ZDI3OTdlYi4uNWQ1NjIwZDlk MTEzIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy91c2Ivcm9sZXMvTWFrZWZpbGUKPiA+ICsrKyBi L2RyaXZlcnMvdXNiL3JvbGVzL01ha2VmaWxlCj4gPiBAQCAtMywzICszLDQgQEAKPiA+ICBvYmot JChDT05GSUdfVVNCX1JPTEVfU1dJVENIKQkJKz0gcm9sZXMubwo+ID4gIHJvbGVzLXkJCQkJCTo9 IGNsYXNzLm8KPiA+ICBvYmotJChDT05GSUdfVVNCX1JPTEVTX0lOVEVMX1hIQ0kpCSs9IGludGVs LXhoY2ktdXNiLXJvbGUtCj4gPiBzd2l0Y2gubwo+ID4gK29iai0kKENPTkZJR19UWVBFQl9DT05O X0dQSU8pCQkrPSB0eXBlYi1jb25uLWdwaW8ubwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNi L3JvbGVzL3R5cGViLWNvbm4tZ3Bpby5jIGIvZHJpdmVycy91c2Ivcm9sZXMvdHlwZWItCj4gPiBj b25uLWdwaW8uYwo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+IGluZGV4IDAwMDAwMDAwMDAw MC4uMDk3ZDJjYTEyYTEyCj4gPiAtLS0gL2Rldi9udWxsCj4gPiArKysgYi9kcml2ZXJzL3VzYi9y b2xlcy90eXBlYi1jb25uLWdwaW8uYwo+ID4gQEAgLTAsMCArMSwzMDUgQEAKPiA+ICsvLyBTUERY LUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAo+ID4gKy8qCj4gPiArICogVVNCIFR5cGUtQiBH UElPIENvbm5lY3RvciBEcml2ZXIKPiA+ICsgKgo+ID4gKyAqIENvcHlyaWdodCAoQykgMjAxOSBN ZWRpYVRlayBJbmMuCj4gPiArICoKPiA+ICsgKiBBdXRob3I6IENodW5mZW5nIFl1biA8Y2h1bmZl bmcueXVuQG1lZGlhdGVrLmNvbT4KPiA+ICsgKgo+ID4gKyAqIFNvbWUgY29kZSBib3Jyb3dlZCBm cm9tIGRyaXZlcnMvZXh0Y29uL2V4dGNvbi11c2ItZ3Bpby5jICAqLwo+ID4gKwo+ID4gKyNpbmNs dWRlIDxsaW51eC9kZXZpY2UuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvZ3Bpby9jb25zdW1lci5o Pgo+ID4gKyNpbmNsdWRlIDxsaW51eC9pbnRlcnJ1cHQuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgv aXJxLmg+Cj4gPiArI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ID4gKyNpbmNsdWRlIDxsaW51 eC9vZi5oPgo+ID4gKyNpbmNsdWRlIDxsaW51eC9vZl9ncmFwaC5oPgo+ID4gKyNpbmNsdWRlIDxs aW51eC9waW5jdHJsL2NvbnN1bWVyLmg+Cj4gPiArI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2Rl dmljZS5oPgo+ID4gKyNpbmNsdWRlIDxsaW51eC9yZWd1bGF0b3IvY29uc3VtZXIuaD4KPiA+ICsj aW5jbHVkZSA8bGludXgvdXNiL3JvbGUuaD4KPiA+ICsKPiA+ICsjZGVmaW5lIFVTQl9HUElPX0RF Ql9NUwkJMjAJLyogbXMgKi8KPiA+ICsjZGVmaW5lIFVTQl9HUElPX0RFQl9VUwkJKChVU0JfR1BJ T19ERUJfTVMpICogMTAwMCkJLyogdXMKPiA+ICovCj4gPiArCj4gPiArI2RlZmluZSBVU0JfQ09O Tl9JUlFGCVwKPiA+ICsJKElSUUZfVFJJR0dFUl9SSVNJTkcgfCBJUlFGX1RSSUdHRVJfRkFMTElO RyB8Cj4gPiBJUlFGX09ORVNIT1QpCj4gPiArCj4gPiArc3RydWN0IHVzYl9jb25uX2luZm8gewo+ ID4gKwlzdHJ1Y3QgZGV2aWNlICpkZXY7Cj4gPiArCXN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2ggKnJv bGVfc3c7Cj4gPiArCWVudW0gdXNiX3JvbGUgbGFzdF9yb2xlOwo+ID4gKwlzdHJ1Y3QgcmVndWxh dG9yICp2YnVzOwo+ID4gKwlzdHJ1Y3QgZGVsYXllZF93b3JrIGR3X2RldDsKPiA+ICsJdW5zaWdu ZWQgbG9uZyBkZWJvdW5jZV9qaWZmaWVzOwo+ID4gKwo+ID4gKwlzdHJ1Y3QgZ3Bpb19kZXNjICpp ZF9ncGlvZDsKPiA+ICsJc3RydWN0IGdwaW9fZGVzYyAqdmJ1c19ncGlvZDsKPiA+ICsJaW50IGlk X2lycTsKPiA+ICsJaW50IHZidXNfaXJxOwo+ID4gK307Cj4gPiArCj4gPiArLyoqCj4gPiArICog IkRFVklDRSIgPSBWQlVTIGFuZCAiSE9TVCIgPSAhSUQsIHNvIHdlIGhhdmU6Cj4gPiArICogQm90 aCAiREVWSUNFIiBhbmQgIkhPU1QiIGNhbid0IGJlIHNldCBhcyBhY3RpdmUgYXQgdGhlIHNhbWUg dGltZQo+ID4gKyAqIHNvIGlmICJIT1NUIiBpcyBhY3RpdmUgKGkuZS4gSUQgaXMgMCkgIHdlIGtl ZXAgIkRFVklDRSIgaW5hY3RpdmUKPiA+ICsgKiBldmVuIGlmIFZCVVMgaXMgb24uCj4gPiArICoK PiA+ICsgKiAgUm9sZSAgICAgICAgICB8ICAgSUQgIHwgIFZCVVMKPiA+ICsgKiAtLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ICsgKiAgWzFdIERFVklDRSAgICB8ICAgSCAg IHwgICBICj4gPiArICogIFsyXSBOT05FICAgICAgfCAgIEggICB8ICAgTAo+ID4gKyAqICBbM10g SE9TVCAgICAgIHwgICBMICAgfCAgIEgKPiA+ICsgKiAgWzRdIEhPU1QgICAgICB8ICAgTCAgIHwg ICBMCj4gPiArICoKPiA+ICsgKiBJbiBjYXNlIHdlIGhhdmUgb25seSBvbmUgb2YgdGhlc2Ugc2ln bmFsczoKPiA+ICsgKiAtIFZCVVMgb25seSAtIHdlIHdhbnQgdG8gZGlzdGluZ3Vpc2ggYmV0d2Vl biBbMV0gYW5kIFsyXSwgc28gSUQgaXMKPiA+ICthbHdheXMgMQo+ID4gKyAqIC0gSUQgb25seSAt IHdlIHdhbnQgdG8gZGlzdGluZ3Vpc2ggYmV0d2VlbiBbMV0gYW5kIFs0XSwgc28gVkJVUyA9IElE Cj4gPiArKi8gc3RhdGljIHZvaWQgdXNiX2Nvbm5fZGV0ZWN0X2NhYmxlKHN0cnVjdCB3b3JrX3N0 cnVjdCAqd29yaykgewo+ID4gKwlzdHJ1Y3QgdXNiX2Nvbm5faW5mbyAqaW5mbzsKPiA+ICsJZW51 bSB1c2Jfcm9sZSByb2xlOwo+ID4gKwlpbnQgaWQsIHZidXMsIHJldDsKPiA+ICsKPiA+ICsJaW5m byA9IGNvbnRhaW5lcl9vZih0b19kZWxheWVkX3dvcmsod29yayksCj4gPiArCQkJICAgIHN0cnVj dCB1c2JfY29ubl9pbmZvLCBkd19kZXQpOwo+ID4gKwo+ID4gKwkvKiBjaGVjayBJRCBhbmQgVkJV UyAqLwo+ID4gKwlpZCA9IGluZm8tPmlkX2dwaW9kID8KPiA+ICsJCWdwaW9kX2dldF92YWx1ZV9j YW5zbGVlcChpbmZvLT5pZF9ncGlvZCkgOiAxOwo+ID4gKwl2YnVzID0gaW5mby0+dmJ1c19ncGlv ZCA/Cj4gPiArCQlncGlvZF9nZXRfdmFsdWVfY2Fuc2xlZXAoaW5mby0+dmJ1c19ncGlvZCkgOiBp ZDsKPiA+ICsKPiA+ICsJaWYgKCFpZCkKPiA+ICsJCXJvbGUgPSBVU0JfUk9MRV9IT1NUOwo+ID4g KwllbHNlIGlmICh2YnVzKQo+ID4gKwkJcm9sZSA9IFVTQl9ST0xFX0RFVklDRTsKPiA+ICsJZWxz ZQo+ID4gKwkJcm9sZSA9IFVTQl9ST0xFX05PTkU7Cj4gPiArCj4gPiArCWRldl9kYmcoaW5mby0+ ZGV2LCAicm9sZSAlZC8lZCwgZ3Bpb3M6IGlkICVkLCB2YnVzICVkXG4iLAo+ID4gKwkJaW5mby0+ bGFzdF9yb2xlLCByb2xlLCBpZCwgdmJ1cyk7Cj4gPiArCj4gPiArCWlmIChpbmZvLT5sYXN0X3Jv bGUgPT0gcm9sZSkgewo+ID4gKwkJZGV2X3dhcm4oaW5mby0+ZGV2LCAicmVwZWF0ZWQgcm9sZTog JWRcbiIsIHJvbGUpOwo+ID4gKwkJcmV0dXJuOwo+ID4gKwl9Cj4gPiArCj4gPiArCWlmIChpbmZv LT5sYXN0X3JvbGUgPT0gVVNCX1JPTEVfSE9TVCkKPiA+ICsJCXJlZ3VsYXRvcl9kaXNhYmxlKGlu Zm8tPnZidXMpOwo+ID4gKwo+ID4gKwlyZXQgPSB1c2Jfcm9sZV9zd2l0Y2hfc2V0X3JvbGUoaW5m by0+cm9sZV9zdywgcm9sZSk7Cj4gPiArCWlmIChyZXQpCj4gPiArCQlkZXZfZXJyKGluZm8tPmRl diwgImZhaWxlZCB0byBzZXQgcm9sZTogJWRcbiIsIHJldCk7Cj4gPiArCj4gPiArCWlmIChyb2xl ID09IFVTQl9ST0xFX0hPU1QpIHsKPiA+ICsJCXJldCA9IHJlZ3VsYXRvcl9lbmFibGUoaW5mby0+ dmJ1cyk7Cj4gPiArCQlpZiAocmV0KQo+ID4gKwkJCWRldl9lcnIoaW5mby0+ZGV2LCAiZW5hYmxl IHZidXMgcmVndWxhdG9yIGZhaWxlZFxuIik7Cj4gPiArCX0KPiA+ICsKPiA+ICsJaW5mby0+bGFz dF9yb2xlID0gcm9sZTsKPiA+ICsKPiA+ICsJZGV2X2RiZyhpbmZvLT5kZXYsICJ2YnVzIHJlZ3Vs YXRvciBpcyAlc1xuIiwKPiA+ICsJCXJlZ3VsYXRvcl9pc19lbmFibGVkKGluZm8tPnZidXMpID8g ImVuYWJsZWQiIDogImRpc2FibGVkIik7IH0KPiA+ICsKPiA+ICtzdGF0aWMgdm9pZCB1c2JfY29u bl9xdWV1ZV9kd29yayhzdHJ1Y3QgdXNiX2Nvbm5faW5mbyAqaW5mbywKPiA+ICsJCQkJIHVuc2ln bmVkIGxvbmcgZGVsYXkpCj4gPiArewo+ID4gKwlxdWV1ZV9kZWxheWVkX3dvcmsoc3lzdGVtX3Bv d2VyX2VmZmljaWVudF93cSwgJmluZm8tCj4gPiA+ZHdfZGV0LCBkZWxheSk7IH0KPiA+ICsKPiA+ ICtzdGF0aWMgaXJxcmV0dXJuX3QgdXNiX2Nvbm5faXNyKGludCBpcnEsIHZvaWQgKmRldl9pZCkg ewo+ID4gKwlzdHJ1Y3QgdXNiX2Nvbm5faW5mbyAqaW5mbyA9IGRldl9pZDsKPiA+ICsKPiA+ICsJ dXNiX2Nvbm5fcXVldWVfZHdvcmsoaW5mbywgaW5mby0+ZGVib3VuY2VfamlmZmllcyk7Cj4gPiAr Cj4gPiArCXJldHVybiBJUlFfSEFORExFRDsKPiA+ICt9Cj4gPiArCj4gPiArc3RhdGljIGludCB1 c2JfY29ubl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KSB7Cj4gPiArCXN0cnVj dCBkZXZpY2UgKmRldiA9ICZwZGV2LT5kZXY7Cj4gPiArCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAg PSBkZXYtPm9mX25vZGU7Cj4gPiArCXN0cnVjdCBkZXZpY2Vfbm9kZSAqcGFyZW50Owo+ID4gKwlz dHJ1Y3QgZGV2aWNlX25vZGUgKmNoaWxkOwo+ID4gKwlzdHJ1Y3QgdXNiX2Nvbm5faW5mbyAqaW5m bzsKPiA+ICsJaW50IHJldCA9IDA7Cj4gPiArCj4gPiArCWlmICghbnApCj4gPiArCQlyZXR1cm4g LUVJTlZBTDsKPiA+ICsKPiA+ICsJaW5mbyA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqaW5m byksIEdGUF9LRVJORUwpOwo+ID4gKwlpZiAoIWluZm8pCj4gPiArCQlyZXR1cm4gLUVOT01FTTsK PiA+ICsKPiA+ICsJaW5mby0+ZGV2ID0gZGV2Owo+ID4gKwo+ID4gKwljaGlsZCA9IG9mX2dldF9j aGlsZF9ieV9uYW1lKG5wLCAiY29ubmVjdG9yIik7Cj4gPiArCWlmICghY2hpbGQpIHsKPiA+ICsJ CWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIGZpbmQgY29ubmVjdG9yIG5vZGVcbiIpOwo+ID4gKwkJ cmV0dXJuIC1FTk9ERVY7Cj4gPiArCX0KPiA+ICsKPiA+ICsJaW5mby0+aWRfZ3Bpb2QgPSBkZXZt X2dwaW9kX2dldF9mcm9tX29mX25vZGUoCj4gPiArCQkJCWRldiwgY2hpbGQsICJpZC1ncGlvcyIs IDAsIEdQSU9EX0lOLCAiaWRwaW4iKTsKPiA+ICsJaWYgKElTX0VSUihpbmZvLT5pZF9ncGlvZCkp IHsKPiA+ICsJCW9mX25vZGVfcHV0KGNoaWxkKTsKPiA+ICsJCXJldHVybiBQVFJfRVJSKGluZm8t PmlkX2dwaW9kKTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlpbmZvLT52YnVzX2dwaW9kID0gZGV2bV9n cGlvZF9nZXRfZnJvbV9vZl9ub2RlKAo+ID4gKwkJCQlkZXYsIGNoaWxkLCAidmJ1cy1ncGlvcyIs IDAsIEdQSU9EX0lOLAo+ID4gKwkJCQkidmJ1c3BpbiIpOwo+ID4gKwlpZiAoSVNfRVJSKGluZm8t PnZidXNfZ3Bpb2QpKSB7Cj4gPiArCQlvZl9ub2RlX3B1dChjaGlsZCk7Cj4gPiArCQlyZXR1cm4g UFRSX0VSUihpbmZvLT52YnVzX2dwaW9kKTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlpZiAoIWluZm8t PmlkX2dwaW9kICYmICFpbmZvLT52YnVzX2dwaW9kKSB7Cj4gPiArCQlkZXZfZXJyKGRldiwgImZh aWxlZCB0byBnZXQgZ3Bpb3NcbiIpOwo+ID4gKwkJcmV0dXJuIC1FTk9ERVY7Cj4gPiArCX0KPiA+ ICsKPiA+ICsJb2Zfbm9kZV9wdXQoY2hpbGQpOwo+ID4gKwo+ID4gKwlpZiAoaW5mby0+aWRfZ3Bp b2QpCj4gPiArCQlyZXQgPSBncGlvZF9zZXRfZGVib3VuY2UoaW5mby0+aWRfZ3Bpb2QsCj4gPiBV U0JfR1BJT19ERUJfVVMpOwo+ID4gKwlpZiAoIXJldCAmJiBpbmZvLT52YnVzX2dwaW9kKQo+ID4g KwkJcmV0ID0gZ3Bpb2Rfc2V0X2RlYm91bmNlKGluZm8tPnZidXNfZ3Bpb2QsCj4gPiBVU0JfR1BJ T19ERUJfVVMpOwo+ID4gKwlpZiAocmV0IDwgMCkKPiA+ICsJCWluZm8tPmRlYm91bmNlX2ppZmZp ZXMgPQo+ID4gbXNlY3NfdG9famlmZmllcyhVU0JfR1BJT19ERUJfTVMpOwo+ID4gKwo+ID4gKwlJ TklUX0RFTEFZRURfV09SSygmaW5mby0+ZHdfZGV0LCB1c2JfY29ubl9kZXRlY3RfY2FibGUpOwo+ ID4gKwo+ID4gKwlpbmZvLT52YnVzID0gZGV2bV9yZWd1bGF0b3JfZ2V0KGRldiwgInZidXMiKTsK PiA+ICsJaWYgKElTX0VSUihpbmZvLT52YnVzKSkgewo+ID4gKwkJZGV2X2VycihkZXYsICJmYWls ZWQgdG8gZ2V0IHZidXNcbiIpOwo+ID4gKwkJcmV0dXJuIFBUUl9FUlIoaW5mby0+dmJ1cyk7Cj4g PiArCX0KPiA+ICsKPiA+ICsJY2hpbGQgPSBvZl9ncmFwaF9nZXRfZW5kcG9pbnRfYnlfcmVncyhu cCwgLTEsIDApOwo+ID4gKwlwYXJlbnQgPSBvZl9ncmFwaF9nZXRfcmVtb3RlX3BvcnRfcGFyZW50 KGNoaWxkKTsKPiA+ICsJaW5mby0+cm9sZV9zdyA9Cj4gPiBmd25vZGVfdXNiX3JvbGVfc3dpdGNo X2dldChvZl9md25vZGVfaGFuZGxlKHBhcmVudCkpOwo+ID4gKwlvZl9ub2RlX3B1dChjaGlsZCk7 Cj4gPiArCW9mX25vZGVfcHV0KHBhcmVudCk7Cj4gPiArCWlmIChJU19FUlIoaW5mby0+cm9sZV9z dykpIHsKPiA+ICsJCWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIGdldCByb2xlIHN3aXRjaFxuIik7 Cj4gPiArCQlyZXR1cm4gUFRSX0VSUihpbmZvLT5yb2xlX3N3KTsKPiA+ICsJfQo+ID4gKwo+ID4g KwlpZiAoaW5mby0+aWRfZ3Bpb2QpIHsKPiA+ICsJCWluZm8tPmlkX2lycSA9IGdwaW9kX3RvX2ly cShpbmZvLT5pZF9ncGlvZCk7Cj4gPiArCQlpZiAoaW5mby0+aWRfaXJxIDwgMCkgewo+ID4gKwkJ CWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIGdldCBJRCBJUlFcbiIpOwo+IE1heSBiZSB1c2Jfcm9s ZV9zd2l0Y2hfcHV0KGluZm8tPnJvbGVfc3cpOyA/PwpHb29kIGNhdGNoLCB3aWxsIGZpeCBpdC4K ClRoYW5rcwo+ID4gKwkJCXJldHVybiBpbmZvLT5pZF9pcnE7Cj4gPiArCQl9Cj4gPiArCj4gPiAr CQlyZXQgPSBkZXZtX3JlcXVlc3RfdGhyZWFkZWRfaXJxKGRldiwgaW5mby0+aWRfaXJxLCBOVUxM LAo+ID4gKwkJCQkJCXVzYl9jb25uX2lzciwKPiA+IFVTQl9DT05OX0lSUUYsCj4gPiArCQkJCQkJ cGRldi0+bmFtZSwgaW5mbyk7Cj4gPiArCQlpZiAocmV0IDwgMCkgewo+ID4gKwkJCWRldl9lcnIo ZGV2LCAiZmFpbGVkIHRvIHJlcXVlc3QgSUQgSVJRXG4iKTsKPiBNYXkgYmUgdXNiX3JvbGVfc3dp dGNoX3B1dChpbmZvLT5yb2xlX3N3KTsgPz8KPiA+ICsJCQlyZXR1cm4gcmV0Owo+ID4gKwkJfQo+ ID4gKwl9Cj4gPiArCj4gPiArCWlmIChpbmZvLT52YnVzX2dwaW9kKSB7Cj4gPiArCQlpbmZvLT52 YnVzX2lycSA9IGdwaW9kX3RvX2lycShpbmZvLT52YnVzX2dwaW9kKTsKPiA+ICsJCWlmIChpbmZv LT52YnVzX2lycSA8IDApIHsKPiA+ICsJCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgVkJV UyBJUlFcbiIpOwo+IE1heSBiZSB1c2Jfcm9sZV9zd2l0Y2hfcHV0KGluZm8tPnJvbGVfc3cpOwo+ ID4gKwkJCXJldHVybiBpbmZvLT52YnVzX2lycTsKPiA+ICsJCX0KPiA+ICsKPiA+ICsJCXJldCA9 IGRldm1fcmVxdWVzdF90aHJlYWRlZF9pcnEoZGV2LCBpbmZvLT52YnVzX2lycSwKPiA+IE5VTEws Cj4gPiArCQkJCQkJdXNiX2Nvbm5faXNyLAo+ID4gVVNCX0NPTk5fSVJRRiwKPiA+ICsJCQkJCQlw ZGV2LT5uYW1lLCBpbmZvKTsKPiA+ICsJCWlmIChyZXQgPCAwKSB7Cj4gPiArCQkJZGV2X2Vycihk ZXYsICJmYWlsZWQgdG8gcmVxdWVzdCBWQlVTIElSUVxuIik7Cj4gTWF5IGJlIHVzYl9yb2xlX3N3 aXRjaF9wdXQoaW5mby0+cm9sZV9zdyk7ID8/Cj4gPiArCQkJcmV0dXJuIHJldDsKPiA+ICsJCX0K PiA+ICsJfQo+ID4gKwo+ID4gKwlwbGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCBpbmZvKTsKPiA+ ICsKPiA+ICsJLyogUGVyZm9ybSBpbml0aWFsIGRldGVjdGlvbiAqLwo+ID4gKwl1c2JfY29ubl9x dWV1ZV9kd29yayhpbmZvLCAwKTsKPiA+ICsKPiA+ICsJcmV0dXJuIDA7Cj4gPiArfQo+ID4gKwo+ ID4gK3N0YXRpYyBpbnQgdXNiX2Nvbm5fcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpIHsKPiA+ICsJc3RydWN0IHVzYl9jb25uX2luZm8gKmluZm8gPSBwbGF0Zm9ybV9nZXRfZHJ2 ZGF0YShwZGV2KTsKPiA+ICsKPiA+ICsJY2FuY2VsX2RlbGF5ZWRfd29ya19zeW5jKCZpbmZvLT5k d19kZXQpOwo+ID4gKwo+ID4gKwlpZiAoaW5mby0+bGFzdF9yb2xlID09IFVTQl9ST0xFX0hPU1Qp Cj4gPiArCQlyZWd1bGF0b3JfZGlzYWJsZShpbmZvLT52YnVzKTsKPiA+ICsKPiA+ICsJdXNiX3Jv bGVfc3dpdGNoX3B1dChpbmZvLT5yb2xlX3N3KTsKPiA+ICsKPiA+ICsJcmV0dXJuIDA7Cj4gPiAr fQo+ID4gKwo+ID4gK3N0YXRpYyBpbnQgX19tYXliZV91bnVzZWQgdXNiX2Nvbm5fc3VzcGVuZChz dHJ1Y3QgZGV2aWNlICpkZXYpIHsKPiA+ICsJc3RydWN0IHVzYl9jb25uX2luZm8gKmluZm8gPSBk ZXZfZ2V0X2RydmRhdGEoZGV2KTsKPiA+ICsKPiA+ICsJaWYgKGluZm8tPmlkX2dwaW9kKQo+ID4g KwkJZGlzYWJsZV9pcnEoaW5mby0+aWRfaXJxKTsKPiA+ICsJaWYgKGluZm8tPnZidXNfZ3Bpb2Qp Cj4gPiArCQlkaXNhYmxlX2lycShpbmZvLT52YnVzX2lycSk7Cj4gPiArCj4gPiArCXBpbmN0cmxf cG1fc2VsZWN0X3NsZWVwX3N0YXRlKGRldik7Cj4gPiArCj4gPiArCXJldHVybiAwOwo+ID4gK30K PiA+ICsKPiA+ICtzdGF0aWMgaW50IF9fbWF5YmVfdW51c2VkIHVzYl9jb25uX3Jlc3VtZShzdHJ1 Y3QgZGV2aWNlICpkZXYpIHsKPiA+ICsJc3RydWN0IHVzYl9jb25uX2luZm8gKmluZm8gPSBkZXZf Z2V0X2RydmRhdGEoZGV2KTsKPiA+ICsKPiA+ICsJcGluY3RybF9wbV9zZWxlY3RfZGVmYXVsdF9z dGF0ZShkZXYpOwo+ID4gKwo+ID4gKwlpZiAoaW5mby0+aWRfZ3Bpb2QpCj4gPiArCQllbmFibGVf aXJxKGluZm8tPmlkX2lycSk7Cj4gPiArCWlmIChpbmZvLT52YnVzX2dwaW9kKQo+ID4gKwkJZW5h YmxlX2lycShpbmZvLT52YnVzX2lycSk7Cj4gPiArCj4gPiArCXVzYl9jb25uX3F1ZXVlX2R3b3Jr KGluZm8sIDApOwo+ID4gKwo+ID4gKwlyZXR1cm4gMDsKPiA+ICt9Cj4gPiArCj4gPiArc3RhdGlj IFNJTVBMRV9ERVZfUE1fT1BTKHVzYl9jb25uX3BtX29wcywKPiA+ICsJCQkgdXNiX2Nvbm5fc3Vz cGVuZCwgdXNiX2Nvbm5fcmVzdW1lKTsKPiA+ICsKPiA+ICsjZGVmaW5lIERFVl9QTVNfT1BTIChJ U19FTkFCTEVEKENPTkZJR19QTV9TTEVFUCkgPwo+ID4gJnVzYl9jb25uX3BtX29wcyA6Cj4gPiAr TlVMTCkKPiA+ICsKPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCB1c2JfY29u bl9kdF9tYXRjaFtdID0gewo+ID4gKwl7IC5jb21wYXRpYmxlID0gImxpbnV4LHR5cGViLWNvbm4t Z3BpbyIsIH0sCj4gPiArCXsgfQo+ID4gK307Cj4gPiArTU9EVUxFX0RFVklDRV9UQUJMRShvZiwg dXNiX2Nvbm5fZHRfbWF0Y2gpOwo+ID4gKwo+ID4gK3N0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJp dmVyIHVzYl9jb25uX2RyaXZlciA9IHsKPiA+ICsJLnByb2JlCQk9IHVzYl9jb25uX3Byb2JlLAo+ ID4gKwkucmVtb3ZlCQk9IHVzYl9jb25uX3JlbW92ZSwKPiA+ICsJLmRyaXZlcgkJPSB7Cj4gPiAr CQkubmFtZQk9ICJ0eXBlYi1jb25uLWdwaW8iLAo+ID4gKwkJLnBtCT0gREVWX1BNU19PUFMsCj4g PiArCQkub2ZfbWF0Y2hfdGFibGUgPSB1c2JfY29ubl9kdF9tYXRjaCwKPiA+ICsJfSwKPiA+ICt9 Owo+ID4gKwo+ID4gK21vZHVsZV9wbGF0Zm9ybV9kcml2ZXIodXNiX2Nvbm5fZHJpdmVyKTsKPiA+ ICsKPiA+ICtNT0RVTEVfQVVUSE9SKCJDaHVuZmVuZyBZdW4gPGNodW5mZW5nLnl1bkBtZWRpYXRl ay5jb20+Iik7Cj4gPiArTU9EVUxFX0RFU0NSSVBUSU9OKCJVU0IgVHlwZS1CIEdQSU8gY29ubmVj dG9yIGRyaXZlciIpOwo+ID4gK01PRFVMRV9MSUNFTlNFKCJHUEwgdjIiKTsKPiA+IC0tCj4gPiAy LjIxLjAKPgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCFDFC43219 for ; Sun, 28 Apr 2019 09:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 827D32075D for ; Sun, 28 Apr 2019 09:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726308AbfD1J0t (ORCPT ); Sun, 28 Apr 2019 05:26:49 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:50637 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726247AbfD1J0s (ORCPT ); Sun, 28 Apr 2019 05:26:48 -0400 X-UUID: 114a31504742434d8047bf9c84466861-20190428 X-UUID: 114a31504742434d8047bf9c84466861-20190428 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 777227468; Sun, 28 Apr 2019 17:26:39 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 28 Apr 2019 17:26:37 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sun, 28 Apr 2019 17:26:37 +0800 Message-ID: <1556443596.10179.212.camel@mhfsdcap03> Subject: RE: [PATCH v4 5/6] usb: roles: add USB Type-B GPIO connector driver From: Chunfeng Yun To: Biju Das CC: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , "Badhri Jagan Sridharan" , Hans de Goede , Andy Shevchenko , Min Guo , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" Date: Sun, 28 Apr 2019 17:26:36 +0800 In-Reply-To: References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> <1556261237-13823-6-git-send-email-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190428092636.fGg89rxPvxFwTkHruZWd54L98_pKG4alF-wQDuzmAz8@z> Hi Biju, On Fri, 2019-04-26 at 09:22 +0000, Biju Das wrote: > Hi Chunfeng Yun, > > Thanks for the patch. > > > Subject: [PATCH v4 5/6] usb: roles: add USB Type-B GPIO connector driver > > > > Due to the requirement of usb-connector.txt binding, the old way using > > extcon to support USB Dual-Role switch is now deprecated when use Type-B > > connector. > > This patch introduces a driver of Type-B connector which typically uses an > > input GPIO to detect USB ID pin, and try to replace the function provided by > > extcon-usb-gpio driver > > > > Signed-off-by: Chunfeng Yun > > --- > > v4 changes: > > 1. remove linux/gpio.h suggested by Linus > > 2. put node when error happens > > > > v3 changes: > > 1. treat bype-B connector as a virtual device; > > 2. change file name again > > > > v2 changes: > > 1. file name is changed > > 2. use new compatible > > --- > > drivers/usb/roles/Kconfig | 11 + > > drivers/usb/roles/Makefile | 1 + > > drivers/usb/roles/typeb-conn-gpio.c | 305 > > ++++++++++++++++++++++++++++ > > 3 files changed, 317 insertions(+) > > create mode 100644 drivers/usb/roles/typeb-conn-gpio.c > > > > diff --git a/drivers/usb/roles/Kconfig b/drivers/usb/roles/Kconfig index > > f8b31aa67526..d1156e18a81a 100644 > > --- a/drivers/usb/roles/Kconfig > > +++ b/drivers/usb/roles/Kconfig > > @@ -26,4 +26,15 @@ config USB_ROLES_INTEL_XHCI > > To compile the driver as a module, choose M here: the module will > > be called intel-xhci-usb-role-switch. > > > > +config TYPEB_CONN_GPIO > > + tristate "USB Type-B GPIO Connector" > > + depends on GPIOLIB > > + help > > + The driver supports USB role switch between host and device via > > GPIO > > + based USB cable detection, used typically if an input GPIO is used > > + to detect USB ID pin. > > + > > + To compile the driver as a module, choose M here: the module will > > + be called typeb-conn-gpio.ko > > + > > endif # USB_ROLE_SWITCH > > diff --git a/drivers/usb/roles/Makefile b/drivers/usb/roles/Makefile index > > 757a7d2797eb..5d5620d9d113 100644 > > --- a/drivers/usb/roles/Makefile > > +++ b/drivers/usb/roles/Makefile > > @@ -3,3 +3,4 @@ > > obj-$(CONFIG_USB_ROLE_SWITCH) += roles.o > > roles-y := class.o > > obj-$(CONFIG_USB_ROLES_INTEL_XHCI) += intel-xhci-usb-role- > > switch.o > > +obj-$(CONFIG_TYPEB_CONN_GPIO) += typeb-conn-gpio.o > > diff --git a/drivers/usb/roles/typeb-conn-gpio.c b/drivers/usb/roles/typeb- > > conn-gpio.c > > new file mode 100644 > > index 000000000000..097d2ca12a12 > > --- /dev/null > > +++ b/drivers/usb/roles/typeb-conn-gpio.c > > @@ -0,0 +1,305 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * USB Type-B GPIO Connector Driver > > + * > > + * Copyright (C) 2019 MediaTek Inc. > > + * > > + * Author: Chunfeng Yun > > + * > > + * Some code borrowed from drivers/extcon/extcon-usb-gpio.c */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#define USB_GPIO_DEB_MS 20 /* ms */ > > +#define USB_GPIO_DEB_US ((USB_GPIO_DEB_MS) * 1000) /* us > > */ > > + > > +#define USB_CONN_IRQF \ > > + (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | > > IRQF_ONESHOT) > > + > > +struct usb_conn_info { > > + struct device *dev; > > + struct usb_role_switch *role_sw; > > + enum usb_role last_role; > > + struct regulator *vbus; > > + struct delayed_work dw_det; > > + unsigned long debounce_jiffies; > > + > > + struct gpio_desc *id_gpiod; > > + struct gpio_desc *vbus_gpiod; > > + int id_irq; > > + int vbus_irq; > > +}; > > + > > +/** > > + * "DEVICE" = VBUS and "HOST" = !ID, so we have: > > + * Both "DEVICE" and "HOST" can't be set as active at the same time > > + * so if "HOST" is active (i.e. ID is 0) we keep "DEVICE" inactive > > + * even if VBUS is on. > > + * > > + * Role | ID | VBUS > > + * ------------------------------------ > > + * [1] DEVICE | H | H > > + * [2] NONE | H | L > > + * [3] HOST | L | H > > + * [4] HOST | L | L > > + * > > + * In case we have only one of these signals: > > + * - VBUS only - we want to distinguish between [1] and [2], so ID is > > +always 1 > > + * - ID only - we want to distinguish between [1] and [4], so VBUS = ID > > +*/ static void usb_conn_detect_cable(struct work_struct *work) { > > + struct usb_conn_info *info; > > + enum usb_role role; > > + int id, vbus, ret; > > + > > + info = container_of(to_delayed_work(work), > > + struct usb_conn_info, dw_det); > > + > > + /* check ID and VBUS */ > > + id = info->id_gpiod ? > > + gpiod_get_value_cansleep(info->id_gpiod) : 1; > > + vbus = info->vbus_gpiod ? > > + gpiod_get_value_cansleep(info->vbus_gpiod) : id; > > + > > + if (!id) > > + role = USB_ROLE_HOST; > > + else if (vbus) > > + role = USB_ROLE_DEVICE; > > + else > > + role = USB_ROLE_NONE; > > + > > + dev_dbg(info->dev, "role %d/%d, gpios: id %d, vbus %d\n", > > + info->last_role, role, id, vbus); > > + > > + if (info->last_role == role) { > > + dev_warn(info->dev, "repeated role: %d\n", role); > > + return; > > + } > > + > > + if (info->last_role == USB_ROLE_HOST) > > + regulator_disable(info->vbus); > > + > > + ret = usb_role_switch_set_role(info->role_sw, role); > > + if (ret) > > + dev_err(info->dev, "failed to set role: %d\n", ret); > > + > > + if (role == USB_ROLE_HOST) { > > + ret = regulator_enable(info->vbus); > > + if (ret) > > + dev_err(info->dev, "enable vbus regulator failed\n"); > > + } > > + > > + info->last_role = role; > > + > > + dev_dbg(info->dev, "vbus regulator is %s\n", > > + regulator_is_enabled(info->vbus) ? "enabled" : "disabled"); } > > + > > +static void usb_conn_queue_dwork(struct usb_conn_info *info, > > + unsigned long delay) > > +{ > > + queue_delayed_work(system_power_efficient_wq, &info- > > >dw_det, delay); } > > + > > +static irqreturn_t usb_conn_isr(int irq, void *dev_id) { > > + struct usb_conn_info *info = dev_id; > > + > > + usb_conn_queue_dwork(info, info->debounce_jiffies); > > + > > + return IRQ_HANDLED; > > +} > > + > > +static int usb_conn_probe(struct platform_device *pdev) { > > + struct device *dev = &pdev->dev; > > + struct device_node *np = dev->of_node; > > + struct device_node *parent; > > + struct device_node *child; > > + struct usb_conn_info *info; > > + int ret = 0; > > + > > + if (!np) > > + return -EINVAL; > > + > > + info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL); > > + if (!info) > > + return -ENOMEM; > > + > > + info->dev = dev; > > + > > + child = of_get_child_by_name(np, "connector"); > > + if (!child) { > > + dev_err(dev, "failed to find connector node\n"); > > + return -ENODEV; > > + } > > + > > + info->id_gpiod = devm_gpiod_get_from_of_node( > > + dev, child, "id-gpios", 0, GPIOD_IN, "idpin"); > > + if (IS_ERR(info->id_gpiod)) { > > + of_node_put(child); > > + return PTR_ERR(info->id_gpiod); > > + } > > + > > + info->vbus_gpiod = devm_gpiod_get_from_of_node( > > + dev, child, "vbus-gpios", 0, GPIOD_IN, > > + "vbuspin"); > > + if (IS_ERR(info->vbus_gpiod)) { > > + of_node_put(child); > > + return PTR_ERR(info->vbus_gpiod); > > + } > > + > > + if (!info->id_gpiod && !info->vbus_gpiod) { > > + dev_err(dev, "failed to get gpios\n"); > > + return -ENODEV; > > + } > > + > > + of_node_put(child); > > + > > + if (info->id_gpiod) > > + ret = gpiod_set_debounce(info->id_gpiod, > > USB_GPIO_DEB_US); > > + if (!ret && info->vbus_gpiod) > > + ret = gpiod_set_debounce(info->vbus_gpiod, > > USB_GPIO_DEB_US); > > + if (ret < 0) > > + info->debounce_jiffies = > > msecs_to_jiffies(USB_GPIO_DEB_MS); > > + > > + INIT_DELAYED_WORK(&info->dw_det, usb_conn_detect_cable); > > + > > + info->vbus = devm_regulator_get(dev, "vbus"); > > + if (IS_ERR(info->vbus)) { > > + dev_err(dev, "failed to get vbus\n"); > > + return PTR_ERR(info->vbus); > > + } > > + > > + child = of_graph_get_endpoint_by_regs(np, -1, 0); > > + parent = of_graph_get_remote_port_parent(child); > > + info->role_sw = > > fwnode_usb_role_switch_get(of_fwnode_handle(parent)); > > + of_node_put(child); > > + of_node_put(parent); > > + if (IS_ERR(info->role_sw)) { > > + dev_err(dev, "failed to get role switch\n"); > > + return PTR_ERR(info->role_sw); > > + } > > + > > + if (info->id_gpiod) { > > + info->id_irq = gpiod_to_irq(info->id_gpiod); > > + if (info->id_irq < 0) { > > + dev_err(dev, "failed to get ID IRQ\n"); > May be usb_role_switch_put(info->role_sw); ?? Good catch, will fix it. Thanks > > + return info->id_irq; > > + } > > + > > + ret = devm_request_threaded_irq(dev, info->id_irq, NULL, > > + usb_conn_isr, > > USB_CONN_IRQF, > > + pdev->name, info); > > + if (ret < 0) { > > + dev_err(dev, "failed to request ID IRQ\n"); > May be usb_role_switch_put(info->role_sw); ?? > > + return ret; > > + } > > + } > > + > > + if (info->vbus_gpiod) { > > + info->vbus_irq = gpiod_to_irq(info->vbus_gpiod); > > + if (info->vbus_irq < 0) { > > + dev_err(dev, "failed to get VBUS IRQ\n"); > May be usb_role_switch_put(info->role_sw); > > + return info->vbus_irq; > > + } > > + > > + ret = devm_request_threaded_irq(dev, info->vbus_irq, > > NULL, > > + usb_conn_isr, > > USB_CONN_IRQF, > > + pdev->name, info); > > + if (ret < 0) { > > + dev_err(dev, "failed to request VBUS IRQ\n"); > May be usb_role_switch_put(info->role_sw); ?? > > + return ret; > > + } > > + } > > + > > + platform_set_drvdata(pdev, info); > > + > > + /* Perform initial detection */ > > + usb_conn_queue_dwork(info, 0); > > + > > + return 0; > > +} > > + > > +static int usb_conn_remove(struct platform_device *pdev) { > > + struct usb_conn_info *info = platform_get_drvdata(pdev); > > + > > + cancel_delayed_work_sync(&info->dw_det); > > + > > + if (info->last_role == USB_ROLE_HOST) > > + regulator_disable(info->vbus); > > + > > + usb_role_switch_put(info->role_sw); > > + > > + return 0; > > +} > > + > > +static int __maybe_unused usb_conn_suspend(struct device *dev) { > > + struct usb_conn_info *info = dev_get_drvdata(dev); > > + > > + if (info->id_gpiod) > > + disable_irq(info->id_irq); > > + if (info->vbus_gpiod) > > + disable_irq(info->vbus_irq); > > + > > + pinctrl_pm_select_sleep_state(dev); > > + > > + return 0; > > +} > > + > > +static int __maybe_unused usb_conn_resume(struct device *dev) { > > + struct usb_conn_info *info = dev_get_drvdata(dev); > > + > > + pinctrl_pm_select_default_state(dev); > > + > > + if (info->id_gpiod) > > + enable_irq(info->id_irq); > > + if (info->vbus_gpiod) > > + enable_irq(info->vbus_irq); > > + > > + usb_conn_queue_dwork(info, 0); > > + > > + return 0; > > +} > > + > > +static SIMPLE_DEV_PM_OPS(usb_conn_pm_ops, > > + usb_conn_suspend, usb_conn_resume); > > + > > +#define DEV_PMS_OPS (IS_ENABLED(CONFIG_PM_SLEEP) ? > > &usb_conn_pm_ops : > > +NULL) > > + > > +static const struct of_device_id usb_conn_dt_match[] = { > > + { .compatible = "linux,typeb-conn-gpio", }, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(of, usb_conn_dt_match); > > + > > +static struct platform_driver usb_conn_driver = { > > + .probe = usb_conn_probe, > > + .remove = usb_conn_remove, > > + .driver = { > > + .name = "typeb-conn-gpio", > > + .pm = DEV_PMS_OPS, > > + .of_match_table = usb_conn_dt_match, > > + }, > > +}; > > + > > +module_platform_driver(usb_conn_driver); > > + > > +MODULE_AUTHOR("Chunfeng Yun "); > > +MODULE_DESCRIPTION("USB Type-B GPIO connector driver"); > > +MODULE_LICENSE("GPL v2"); > > -- > > 2.21.0 >