From: Oliver Neukum <oneukum@suse.com>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org
Subject: [1/5] USB: serial: fix unthrottle races
Date: Mon, 29 Apr 2019 11:50:58 +0200 [thread overview]
Message-ID: <1556531458.20085.8.camel@suse.com> (raw)
On Do, 2019-04-25 at 18:05 +0200, Johan Hovold wrote:
> @@ -484,6 +503,12 @@ void usb_serial_generic_unthrottle(struct tty_struct *tty)
> port->throttled = port->throttle_req = 0;
> spin_unlock_irq(&port->lock);
>
> + /*
> + * Matches the smp_mb__after_atomic() in
> + * usb_serial_generic_read_bulk_callback().
> + */
> + smp_mb();
> +
> if (was_throttled)
> usb_serial_generic_submit_read_urbs(port, GFP_KERNEL);
Doesn't the spin_unlock_irq() imply smp_mb()?
Otherwise it looks correct to me.
Regards
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Neukum <oneukum@suse.com>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/5] USB: serial: fix unthrottle races
Date: Mon, 29 Apr 2019 11:50:58 +0200 [thread overview]
Message-ID: <1556531458.20085.8.camel@suse.com> (raw)
Message-ID: <20190429095058.Zs4Oy8jj_khxXq8s_0sLcCTjQDGL6SFFx0a2M-TdmsQ@z> (raw)
In-Reply-To: <20190425160540.10036-2-johan@kernel.org>
On Do, 2019-04-25 at 18:05 +0200, Johan Hovold wrote:
> @@ -484,6 +503,12 @@ void usb_serial_generic_unthrottle(struct tty_struct *tty)
> port->throttled = port->throttle_req = 0;
> spin_unlock_irq(&port->lock);
>
> + /*
> + * Matches the smp_mb__after_atomic() in
> + * usb_serial_generic_read_bulk_callback().
> + */
> + smp_mb();
> +
> if (was_throttled)
> usb_serial_generic_submit_read_urbs(port, GFP_KERNEL);
Doesn't the spin_unlock_irq() imply smp_mb()?
Otherwise it looks correct to me.
Regards
Oliver
next prev reply other threads:[~2019-04-29 9:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 16:05 [PATCH 0/5] USB: fix tty unthrottle races Johan Hovold
2019-04-25 16:05 ` [1/5] USB: serial: fix " Johan Hovold
2019-04-25 16:05 ` [PATCH 1/5] " Johan Hovold
2019-04-29 9:50 ` Oliver Neukum [this message]
2019-04-29 9:50 ` Oliver Neukum
2019-04-29 10:03 ` [1/5] " Johan Hovold
2019-04-29 10:03 ` [PATCH 1/5] " Johan Hovold
2019-05-13 10:43 ` Johan Hovold
2019-05-13 10:56 ` Greg Kroah-Hartman
2019-05-13 11:46 ` Johan Hovold
2019-05-13 12:51 ` Greg Kroah-Hartman
2019-05-13 12:59 ` Johan Hovold
2019-05-14 12:53 ` Sasha Levin
2019-05-14 12:57 ` Johan Hovold
2019-04-25 16:05 ` [2/5] USB: serial: clean up throttle handling Johan Hovold
2019-04-25 16:05 ` [PATCH 2/5] " Johan Hovold
2019-04-25 16:05 ` [3/5] USB: serial: generic: drop unnecessary goto Johan Hovold
2019-04-25 16:05 ` [PATCH 3/5] " Johan Hovold
2019-04-25 16:05 ` [4/5] USB: cdc-acm: fix unthrottle races Johan Hovold
2019-04-25 16:05 ` [PATCH 4/5] " Johan Hovold
2019-04-29 10:09 ` [4/5] " Oliver Neukum
2019-04-29 10:09 ` [PATCH 4/5] " Oliver Neukum
2019-04-25 16:05 ` [5/5] USB: cdc-acm: clean up throttle handling Johan Hovold
2019-04-25 16:05 ` [PATCH 5/5] " Johan Hovold
2019-04-29 10:10 ` [5/5] " Oliver Neukum
2019-04-29 10:10 ` [PATCH 5/5] " Oliver Neukum
2019-04-25 20:58 ` [PATCH 0/5] USB: fix tty unthrottle races Alan Stern
2019-04-26 4:55 ` Johan Hovold
2019-04-29 9:30 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556531458.20085.8.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).