From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch From: Chunfeng Yun Message-Id: <1556607457.10179.259.camel@mhfsdcap03> Date: Tue, 30 Apr 2019 14:57:37 +0800 To: Rob Herring Cc: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux USB List , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , Biju Das , Linus Walleij List-ID: T24gTW9uLCAyMDE5LTA0LTI5IGF0IDExOjI1IC0wNTAwLCBSb2IgSGVycmluZyB3cm90ZToKPiBP biBTdW4sIEFwciAyOCwgMjAxOSBhdCA3OjE2IEFNIENodW5mZW5nIFl1biA8Y2h1bmZlbmcueXVu QG1lZGlhdGVrLmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gRnJpLCAyMDE5LTA0LTI2IGF0IDE1OjQ5 IC0wNTAwLCBSb2IgSGVycmluZyB3cm90ZToKPiA+ID4gT24gRnJpLCBBcHIgMjYsIDIwMTkgYXQg MDI6NDc6MTRQTSArMDgwMCwgQ2h1bmZlbmcgWXVuIHdyb3RlOgo+ID4gPiA+IE5vdyB0aGUgVVNC IFJvbGUgU3dpdGNoIGlzIHN1cHBvcnRlZCwgc28gYWRkIHByb3BlcnRpZXMgYWJvdXQgaXQKPiA+ ID4gPgo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IENodW5mZW5nIFl1biA8Y2h1bmZlbmcueXVuQG1l ZGlhdGVrLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiB2NDogbm8gY2hhbmdlcwo+ID4gPiA+IHYz OiBubyBjaGFuZ2VzCj4gPiA+ID4KPiA+ID4gPiB2MiBjaGFuZ2VzOgo+ID4gPiA+ICAgMS4gZml4 IHR5cG8KPiA+ID4gPiAgIDIuIHJlZmVyIG5ldyBiaW5kaW5nIGFib3V0IGNvbm5lY3RvciBwcm9w ZXJ0eQo+ID4gPiA+IC0tLQo+ID4gPiA+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvbWVk aWF0ZWssbXR1My50eHQgICAgICAgICAgfCAxMCArKysrKysrKy0tCj4gPiA+ID4gIDEgZmlsZSBj aGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiA+ID4KPiA+ID4gPiBk aWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9tZWRpYXRl ayxtdHUzLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvbWVkaWF0 ZWssbXR1My50eHQKPiA+ID4gPiBpbmRleCAzMzgyYjVjYjQ3MWQuLjZlMDA0YzRhODlhZiAxMDA2 NDQKPiA+ID4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL21l ZGlhdGVrLG10dTMudHh0Cj4gPiA+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL3VzYi9tZWRpYXRlayxtdHUzLnR4dAo+ID4gPiA+IEBAIC0yNyw3ICsyNyw5IEBAIE9w dGlvbmFsIHByb3BlcnRpZXM6Cj4gPiA+ID4gICAtIHJhbmdlcyA6IGFsbG93cyB2YWxpZCAxOjEg dHJhbnNsYXRpb24gYmV0d2VlbiBjaGlsZCdzIGFkZHJlc3Mgc3BhY2UgYW5kCj4gPiA+ID4gICAg IHBhcmVudCdzIGFkZHJlc3Mgc3BhY2UKPiA+ID4gPiAgIC0gZXh0Y29uIDogZXh0ZXJuYWwgY29u bmVjdG9yIGZvciB2YnVzIGFuZCBpZHBpbiBjaGFuZ2VzIGRldGVjdGlvbiwgbmVlZGVkCj4gPiA+ ID4gLSAgIHdoZW4gc3VwcG9ydHMgZHVhbC1yb2xlIG1vZGUuCj4gPiA+ID4gKyAgIHdoZW4gc3Vw cG9ydHMgZHVhbC1yb2xlIG1vZGU7IGl0J3MgY29uc2llZGVyZWQgdmFsaWQgZm9yIGNvbXBhdGli aWxpdHkKPiA+ID4gPiArICAgcmVhc29ucywgYW5kIG5vdCBhbGxvd2VkIGZvciBuZXcgYmluZGlu Z3MsIHVzZSB0aGUgcHJvcGVydHkKPiA+ID4gPiArICAgdXNiLXJvbGUtc3dpdGNoIGluc3RlYWQu Cj4gPiA+ID4gICAtIHZidXMtc3VwcGx5IDogcmVmZXJlbmNlIHRvIHRoZSBWQlVTIHJlZ3VsYXRv ciwgbmVlZGVkIHdoZW4gc3VwcG9ydHMKPiA+ID4gPiAgICAgZHVhbC1yb2xlIG1vZGUuCj4gPiA+ ID4gICAtIHBpbmN0cmwtbmFtZXMgOiBhIHBpbmN0cmwgc3RhdGUgbmFtZWQgImRlZmF1bHQiIGlz IG9wdGlvbmFsLCBhbmQgbmVlZCBiZQo+ID4gPiA+IEBAIC0zNiw3ICszOCw4IEBAIE9wdGlvbmFs IHByb3BlcnRpZXM6Cj4gPiA+ID4gICAgIGlzIG5vdCBzZXQuCj4gPiA+ID4gICAtIHBpbmN0cmwt MCA6IHBpbiBjb250cm9sIGdyb3VwCj4gPiA+ID4gICAgIFNlZTogRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL3BpbmN0cmwvcGluY3RybC1iaW5kaW5ncy50eHQKPiA+ID4gPiAtCj4g PiA+ID4gKyAtIHVzYi1yb2xlLXN3aXRjaCA6IHVzZSBVU0IgUm9sZSBTd2l0Y2ggdG8gc3VwcG9y dCBkdWFsLXJvbGUgc3dpdGNoLCBidXQKPiA+ID4gPiArICAgbm90IGV4dGNvbgo+ID4gPgo+ID4g PiBDb29yZGluYXRlIHdpdGggdGhlIFJlbmVzYXMgYW5kIEhpU2lsaWNvbiBmb2xrcyBpbXBsZW1l bnRpbmcgdGhlIHNhbWUKPiA+ID4gdGhpbmcgYW5kIHB1dCB0aGlzIGluIGEgY29tbW9uIHNwb3Qu Cj4gPiBJJ2xsIHByZXBhcmUgYSBwYXRjaCBmb3IgaXQsIGFuZCBDQyBCaWp1IGFuZCBZdQo+ID4K PiA+ID4gSG93ZXZlciwgSSB0aGluayB0aGlzIHNob3VsZCBub3QKPiA+ID4gZXZlbiBiZSBuZWVk ZWQgYXMga25vd2luZyB0aGUgY29udHJvbGxlciBjYXBhYmlsaXRpZXMgKGJhc2VkIG9uIHRoZQo+ ID4gPiBjb21wYXRpYmxlKSBhbmQga25vd2luZyB0aGUgdHlwZSBvZiBjb25uZWN0b3Igc2hvdWxk IGJlIGVub3VnaAo+ID4gPiBpbmZvcm1hdGlvbiB0byB0ZWxsIHlvdSBpZiBkdWFsIHJvbGUgaXMg c3VwcG9ydGVkIG9yIG5vdC4KPiA+IFNvbWUgRHVhbC1Sb2xlIGNvbnRyb2xsZXIgZHJpdmVycyBh bHJlYWR5IHVzZWQgZXh0Y29uIGZyYW1ld29yayB0bwo+ID4gaGFuZGxlIHJvbGUgc3dpdGNoLCBp ZiB0cnkgdG8gc3VwcG9ydCB0aGUgbmV3IFVTQiBSb2xlIFN3aXRjaCBmcmFtZXdvcmssCj4gPiB0 aGUgZHJpdmVyIG1heSB3YW50IHRvIGtub3cgd2hpY2ggd2F5IHdpbGwgYmUgdXNlZC4KPiAKPiBX b3VsZG4ndCBpdCBrbm93IGJ5IHByZXNlbmNlIG9mICdleHRjb24nIHByb3BlcnR5IG9yIG5vdD8K Cm5vbi1wcmVzZW5jZSBvZiAnZXh0Y29uJyBkb2Vzbid0IG1lYW4gdGhlIGRyaXZlciBuZWVkIFVT QiBSb2xlIFN3aXRjaCwKZS5nLiBzdXBwb3J0IG1hbnVhbCByb2xlIHN3aXRjaCBkZWNpZGVkIGJ5 IHVzZXIsIG9mIGNvdXJzZSwgd2UgY2FuIGNoZWNrCnNvbWUgY2FzZXMgYW5kIHRoZW4gZGVjaWRl IHdoZXRoZXIgbmVlZCBVU0IgUm9sZSBTd2l0Y2ggb3Igbm90LCBtYXliZQpwcm92aWRlIGEgcHJv cGVydHkgd2lsbCBtYWtlIGl0IGVhc2llci4KCj4gCj4gPiBTb21ldGltZXMgdXNlcnMgYWxzbyB3 YW50IHRvIHVzZSBkdWFsLXJvbGUgZXZlbiB1c2UgdGhlIHR5cGUtQSwgc3VjaCBhcwo+ID4gdXNl IHN5cyBpbnRlcmZhY2UgdG8gaGFuZGxlIHJvbGUgc3dpdGNoLCBzbyBvbmx5IGtub3dpbmcgdGhl IGNvbm5lY3Rvcgo+ID4gdHlwZSBjYW4ndCB0ZWxsIGRyaXZlciB3aGljaCB3YXkgdG8gdXNlCj4g Cj4gVGhhdCB1c2UgY2FzZSBkb2Vzbid0IHNvdW5kIGxpa2Ugc29tZXRoaW5nIHRoYXQgc2hvdWxk IGJlIGluIERUCj4gdGhvdWdoLiBUaGF0IHdvdWxkIGJlIHBvc3NpYmxlIGZvciBhbnkgY29udHJv bGxlciB0aGF0IHN1cHBvcnRzCj4gZHVhbC1yb2xlLiAKSSBnaXZlIG1hbnVhbCByb2xlIHN3aXRj aCBieSBzeXNmcyBpbnRlcmZhY2UgYSBoaWdoZXIgcHJpb3JpdHkgdGhhbgpvdGhlciB3YXlzLCBp ZiBtYW51YWwgc3dpdGNoIGlzIGVuYWJsZWQsIGUuZy4gJ2V4dGNvbicgd2lsbCBiZSBpZ25vcmVk Lgp0aGlzIG1heSBiZSBkaWZmZXJlbnQgZnJvbSBvdGhlciBVU0IgZHVhbC1yb2xlIGNvbnRyb2xs ZXIgZHJpdmVycy4KCj4gVGhvdWdoIHBlcmhhcHMgdGhhdCByZXF1aXJlcyBzb21lIHNwZWNpZmlj IFZidXMgd2lyaW5nPyBPcgo+IGEgY2FibGUgd2l0aCBWYnVzIGRpc2Nvbm5lY3RlZC4gClllcywg c29tZSBwcm9qZWN0cyB1c2UgUE1JQyBvciBDaGFyZ2VyIHRvIGRldGVjdCBWYnVzLCBidXQgc29t ZSBkb24ndApoYXZlIFZidXMgZGV0ZWN0aW9uIGNpcmN1aXQsIGFuZCBzb21lIGV2ZW4gZG9uJ3Qg cHJvdmlkZSB2YnVzIHBpbgoKPiBFaXRoZXIgd2F5LCBkb2Vzbid0IHNvdW5kIFVTQiBjb21wbGlh bnQuClllcywgaXQncyBtb3JlIHJlbGF0ZWQgd2l0aCBjdXN0b21lciB1c2FnZSwgb3IgY29zdCBk b3duLCBhbnl3YXksIGl0J3MKYmV0dGVyIHRvIHN1cHBvcnQgY2FzZXMgYXMgbWFueSBhcyBwb3Nz aWJsZS4KCj4gCj4gUm9iCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F9A4C43219 for ; Tue, 30 Apr 2019 06:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8FA42080C for ; Tue, 30 Apr 2019 06:57:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726413AbfD3G5o (ORCPT ); Tue, 30 Apr 2019 02:57:44 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:8461 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725554AbfD3G5o (ORCPT ); Tue, 30 Apr 2019 02:57:44 -0400 X-UUID: 2d217474e79a4b76987e911cdbe6e632-20190430 X-UUID: 2d217474e79a4b76987e911cdbe6e632-20190430 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1809240108; Tue, 30 Apr 2019 14:57:39 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 30 Apr 2019 14:57:37 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 30 Apr 2019 14:57:37 +0800 Message-ID: <1556607457.10179.259.camel@mhfsdcap03> Subject: Re: [PATCH v4 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch From: Chunfeng Yun To: Rob Herring CC: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , "Badhri Jagan Sridharan" , Hans de Goede , Andy Shevchenko , Min Guo , , "linux-kernel@vger.kernel.org" , "Linux USB List" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , "Biju Das" , Linus Walleij Date: Tue, 30 Apr 2019 14:57:37 +0800 In-Reply-To: References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> <1556261237-13823-4-git-send-email-chunfeng.yun@mediatek.com> <20190426204906.GB15074@bogus> <1556453788.10179.224.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190430065737.RsDssilaL9B902U2Ez0bfBjDACRRv6KCkwJgF10sLds@z> On Mon, 2019-04-29 at 11:25 -0500, Rob Herring wrote: > On Sun, Apr 28, 2019 at 7:16 AM Chunfeng Yun wrote: > > > > On Fri, 2019-04-26 at 15:49 -0500, Rob Herring wrote: > > > On Fri, Apr 26, 2019 at 02:47:14PM +0800, Chunfeng Yun wrote: > > > > Now the USB Role Switch is supported, so add properties about it > > > > > > > > Signed-off-by: Chunfeng Yun > > > > --- > > > > v4: no changes > > > > v3: no changes > > > > > > > > v2 changes: > > > > 1. fix typo > > > > 2. refer new binding about connector property > > > > --- > > > > .../devicetree/bindings/usb/mediatek,mtu3.txt | 10 ++++++++-- > > > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > > > index 3382b5cb471d..6e004c4a89af 100644 > > > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > > > @@ -27,7 +27,9 @@ Optional properties: > > > > - ranges : allows valid 1:1 translation between child's address space and > > > > parent's address space > > > > - extcon : external connector for vbus and idpin changes detection, needed > > > > - when supports dual-role mode. > > > > + when supports dual-role mode; it's consiedered valid for compatibility > > > > + reasons, and not allowed for new bindings, use the property > > > > + usb-role-switch instead. > > > > - vbus-supply : reference to the VBUS regulator, needed when supports > > > > dual-role mode. > > > > - pinctrl-names : a pinctrl state named "default" is optional, and need be > > > > @@ -36,7 +38,8 @@ Optional properties: > > > > is not set. > > > > - pinctrl-0 : pin control group > > > > See: Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > > > > - > > > > + - usb-role-switch : use USB Role Switch to support dual-role switch, but > > > > + not extcon > > > > > > Coordinate with the Renesas and HiSilicon folks implementing the same > > > thing and put this in a common spot. > > I'll prepare a patch for it, and CC Biju and Yu > > > > > However, I think this should not > > > even be needed as knowing the controller capabilities (based on the > > > compatible) and knowing the type of connector should be enough > > > information to tell you if dual role is supported or not. > > Some Dual-Role controller drivers already used extcon framework to > > handle role switch, if try to support the new USB Role Switch framework, > > the driver may want to know which way will be used. > > Wouldn't it know by presence of 'extcon' property or not? non-presence of 'extcon' doesn't mean the driver need USB Role Switch, e.g. support manual role switch decided by user, of course, we can check some cases and then decide whether need USB Role Switch or not, maybe provide a property will make it easier. > > > Sometimes users also want to use dual-role even use the type-A, such as > > use sys interface to handle role switch, so only knowing the connector > > type can't tell driver which way to use > > That use case doesn't sound like something that should be in DT > though. That would be possible for any controller that supports > dual-role. I give manual role switch by sysfs interface a higher priority than other ways, if manual switch is enabled, e.g. 'extcon' will be ignored. this may be different from other USB dual-role controller drivers. > Though perhaps that requires some specific Vbus wiring? Or > a cable with Vbus disconnected. Yes, some projects use PMIC or Charger to detect Vbus, but some don't have Vbus detection circuit, and some even don't provide vbus pin > Either way, doesn't sound USB compliant. Yes, it's more related with customer usage, or cost down, anyway, it's better to support cases as many as possible. > > Rob