From: Paul Cercueil <paul@crapouillou.net>
To: Bin Liu <b-liu@ti.com>
Cc: od@zcrc.me, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: jz4740: Make probe function __init_or_module
Date: Sat, 08 Jun 2019 12:21:18 +0200 [thread overview]
Message-ID: <1559989278.1815.4@crapouillou.net> (raw)
In-Reply-To: <20190607155751.15778-1-paul@crapouillou.net>
I misunderstood what __init_or_module was for. Please ignore this patch.
Le ven. 7 juin 2019 à 17:57, Paul Cercueil <paul@crapouillou.net> a
écrit :
> This allows the probe function to be dropped after the kernel finished
> its initialization, in the case where the driver was not compiled as a
> module.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/usb/musb/jz4740.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c
> index 5261f8dfedec..c881f6d14752 100644
> --- a/drivers/usb/musb/jz4740.c
> +++ b/drivers/usb/musb/jz4740.c
> @@ -105,7 +105,7 @@ static const struct musb_platform_ops
> jz4740_musb_ops = {
> .init = jz4740_musb_init,
> };
>
> -static int jz4740_probe(struct platform_device *pdev)
> +static int __init_or_module jz4740_probe(struct platform_device
> *pdev)
> {
> struct musb_hdrc_platform_data *pdata = &jz4740_musb_platform_data;
> struct platform_device *musb;
> @@ -174,7 +174,7 @@ static int jz4740_probe(struct platform_device
> *pdev)
> return ret;
> }
>
> -static int jz4740_remove(struct platform_device *pdev)
> +static int __exit jz4740_remove(struct platform_device *pdev)
> {
> struct jz4740_glue *glue = platform_get_drvdata(pdev);
>
> --
> 2.21.0.593.g511ec345e18
>
prev parent reply other threads:[~2019-06-08 10:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 15:57 [PATCH] usb: musb: jz4740: Make probe function __init_or_module Paul Cercueil
2019-06-08 10:21 ` Paul Cercueil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559989278.1815.4@crapouillou.net \
--to=paul@crapouillou.net \
--cc=b-liu@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=od@zcrc.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).