From: Oliver Neukum <oneukum@suse.com>
To: JC Kuo <jckuo@nvidia.com>, Greg KH <gregkh@linuxfoundation.org>
Cc: usb-storage@lists.one-eyed-alien.net, stern@rowland.harvard.edu,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: storage: skip only when uas driver is loaded
Date: Tue, 02 Jul 2019 11:11:30 +0200 [thread overview]
Message-ID: <1562058690.5819.9.camel@suse.com> (raw)
In-Reply-To: <f43e7ecf-64d5-20d2-0461-85a55fa28a33@nvidia.com>
Am Dienstag, den 02.07.2019, 14:56 +0800 schrieb JC Kuo:
>
> Since blacklisting uas kernel module is not a good idea and could break UAS
Then don't do it. If you don't want a driver loaded for a device
blacklisting the driver must not magically assign another driver.
> capable storage functionality, do we consider forbidding making uas driver
> as module? That means to make CONFIG_USB_UAS a bool option.
No. Absolutely not. We cannot force people to build UAS into their
kernel or not use it. Building either driver not at all, modular
or statically are all valid use cases. Just not building UAS must
trigger a fallback. And we must have a flag to override the kernel's
decision
Making driver assignments depend on module loading order is a very bad
idea. We also have the necessary quirk in one way. I would accept a
patch adding a flag to force usage of UAS, but other than that, the
existing code is as it must be.
Regards
Oliver
next prev parent reply other threads:[~2019-07-02 9:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 8:48 [PATCH] usb: storage: skip only when uas driver is loaded JC Kuo
2019-07-01 8:52 ` Greg KH
2019-07-02 2:36 ` JC Kuo
2019-07-02 4:42 ` Greg KH
2019-07-02 5:29 ` JC Kuo
2019-07-02 6:56 ` JC Kuo
2019-07-02 7:34 ` Greg KH
2019-07-02 7:57 ` JC Kuo
2019-07-02 8:14 ` Greg KH
2019-07-02 9:11 ` Oliver Neukum [this message]
2019-07-02 14:05 ` JC Kuo
2019-07-02 15:29 ` Oliver Neukum
2019-07-02 6:53 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562058690.5819.9.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=jckuo@nvidia.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).