From: Oliver Neukum <oneukum@suse.com>
To: Charles.Hyde@dellteam.com, lenb@kernel.org, rjw@rjwysocki.net
Cc: Mario.Limonciello@dell.com, nic_swsd@realtek.com,
linux-acpi@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/3] net: cdc_ncm: add get/set ethernet address functions
Date: Mon, 02 Sep 2019 11:43:40 +0200 [thread overview]
Message-ID: <1567417420.2469.3.camel@suse.com> (raw)
In-Reply-To: <5cee0eb405f2492b8086d8684f1c75ca@AUSX13MPS307.AMER.DELL.COM>
Am Freitag, den 30.08.2019, 19:37 +0000 schrieb
Charles.Hyde@dellteam.com:
> This patch adds support for pushing a MAC address out to USB based
> ethernet controllers driven by cdc_ncm. With this change, ifconfig can
> now set the device's MAC address. For example, the Dell Universal Dock
> D6000 is driven by cdc_ncm. The D6000 can now have its MAC address set
> by ifconfig, as it can be done in Windows. This was tested with a D6000
> using ifconfig on an x86 based chromebook, where iproute2 is not
> available.
> +/* Provide method to push MAC address to the USB device's ethernet controller.
> + */
> +int cdc_ncm_set_mac_addr(struct net_device *net, void *p)
> +{
> + struct usbnet *dev = netdev_priv(net);
> +
> + /* Try to push the MAC address out to the device. Ignore any errors,
> + * to be compatible with prior versions of this source.
> + */
> + cdc_ncm_set_ethernet_address(dev, (struct sockaddr *)p);
You are throwing away error reports.
Regards
Oliver
next prev parent reply other threads:[~2019-09-02 9:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 19:37 [PATCH 1/3] net: cdc_ncm: add get/set ethernet address functions Charles.Hyde
2019-09-02 9:43 ` Oliver Neukum [this message]
2019-09-03 16:45 ` Charles.Hyde
-- strict thread matches above, loose matches on Subject: below --
2019-09-05 21:01 Charles.Hyde
2019-09-06 9:02 ` Bjørn Mork
2019-09-06 18:00 ` Charles.Hyde
2019-09-06 18:15 ` Alan Stern
2019-09-06 18:19 ` Charles.Hyde
2019-09-06 20:07 ` Bjørn Mork
2019-09-06 20:20 ` Charles.Hyde
2019-09-06 20:39 ` Bjørn Mork
2019-09-06 21:00 ` Charles.Hyde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567417420.2469.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=Charles.Hyde@dellteam.com \
--cc=Mario.Limonciello@dell.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).