From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EEDFC3A5A8 for ; Mon, 2 Sep 2019 09:43:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 025DC217F4 for ; Mon, 2 Sep 2019 09:43:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730852AbfIBJno (ORCPT ); Mon, 2 Sep 2019 05:43:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:48548 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729668AbfIBJno (ORCPT ); Mon, 2 Sep 2019 05:43:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C6F57AF54; Mon, 2 Sep 2019 09:43:42 +0000 (UTC) Message-ID: <1567417420.2469.3.camel@suse.com> Subject: Re: [PATCH 1/3] net: cdc_ncm: add get/set ethernet address functions From: Oliver Neukum To: Charles.Hyde@dellteam.com, lenb@kernel.org, rjw@rjwysocki.net Cc: Mario.Limonciello@dell.com, nic_swsd@realtek.com, linux-acpi@vger.kernel.org, linux-usb@vger.kernel.org Date: Mon, 02 Sep 2019 11:43:40 +0200 In-Reply-To: <5cee0eb405f2492b8086d8684f1c75ca@AUSX13MPS307.AMER.DELL.COM> References: <5cee0eb405f2492b8086d8684f1c75ca@AUSX13MPS307.AMER.DELL.COM> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Am Freitag, den 30.08.2019, 19:37 +0000 schrieb Charles.Hyde@dellteam.com: > This patch adds support for pushing a MAC address out to USB based > ethernet controllers driven by cdc_ncm. With this change, ifconfig can > now set the device's MAC address. For example, the Dell Universal Dock > D6000 is driven by cdc_ncm. The D6000 can now have its MAC address set > by ifconfig, as it can be done in Windows. This was tested with a D6000 > using ifconfig on an x86 based chromebook, where iproute2 is not > available. > +/* Provide method to push MAC address to the USB device's ethernet controller. > + */ > +int cdc_ncm_set_mac_addr(struct net_device *net, void *p) > +{ > + struct usbnet *dev = netdev_priv(net); > + > + /* Try to push the MAC address out to the device. Ignore any errors, > + * to be compatible with prior versions of this source. > + */ > + cdc_ncm_set_ethernet_address(dev, (struct sockaddr *)p); You are throwing away error reports. Regards Oliver