Re: Lacie Rugged USB3-FW does not work with UAS

Julian Sikorski
2021-08-01T07:47:46Z

Am 01.08.21 um 09:35 schrieb Julian Sikorski:
> Am 29.07.21 um 11:08 schrieb Hans de Goede:
>> Hi,
>>
>> On 7/28/21 7:29 PM, Julian Sikorski wrote:
>>> Hi all,
>>>
>>> f quirk alone seems to be sufficient.
>>
>> Thank you for testing, but I'm not sure using only the NO_REPORT_OPCODES
>> quirk is wise here, the other similar La Cie drive also started out with
>> just that quirk, only to have the NO_SAME quirk added later. See:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8010622c86ca5bb44bc98492f5968726fc7c7a21
>>
>>
>> Actually triggering a WRITE_SAME SCSI command is likely tricky, so
>> it likely requires a special workload to ensure that that flag is
>> not necessary.
>>
>> As Oliver set with the quirk to disable UAS we at least have the
>> drive working (albeit slower then it would work with UAS) so we
>> can take our time to make sure that things work properly with
>> the combination of the f+k flags (at least using both seems
>> best to me) before re-enabling UAS.
>>
>> Regards,
>>
>> Hans
>>
> Hi,
>
> are there some tests which I could run in particular to test whether
> WRITE_SAME is working as intended? I use this drive for backups which
> means I don't connect it all that often.
>
> Best regards,
> Julian

Hi,

one more question: is there a way to force-enable UAS for testing now
that the quirk has been upstreamed, other than reverting the patch and
rebuilding the kernel?

Best regards,
Julian
>
>>>
>>> Best regards,
>>> Julian
>>>
>>> Julian Sikorski <belegdol@gmail.com <mailto:belegdol@gmail.com>>
>>> schrieb am Mi., 28. Juli 2021, 01:14:
>>>
>>>      Hi Hans,
>>>
>>>      apologies for top-posting and HTML but I only can send emails
>>> from my mobile currently.
>>>      With fk quirk the drive indeed appears to be working with uas: I
>>> can decrypt and mount a veracrypt volume from it. Thanks!
>>>      The patch disabling uas has already made it to Linus' tree and
>>> is about to be added to stable:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6abf2fe6b4bf6e5256b80c5817908151d2d33e9f
>>> <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6abf2fe6b4bf6e5256b80c5817908151d2d33e9f>
>>>
>>>      As I have no working internet on any of my Linux machines and
>>> won't for the foreseeable future (thank you construction workers),
>>> would you mind taking care of amending the quirk accordingly? Thank
>>> you in advance.
>>>
>>>      Best regards,
>>>      Julian
>>>
>>>
>>>      Hans de Goede <hdegoede@redhat.com <mailto:hdegoede@redhat.com>>
>>> schrieb am Di., 27. Juli 2021, 23:19:
>>>
>>>          Hi,
>>>
>>>          On 7/19/21 6:10 PM, Julian Sikorski wrote:
>>>          > W dniu 19.07.2021 o 14:47, Oliver Neukum pisze:
>>>          >>
>>>          >>> Hi all,
>>>          >>>
>>>          >>> apologies for necro-ing this thread. I have just tried
>>> this drive with
>>>          >>> my new laptop (Asus ZenBook UM425IA) and the same quirk
>>> was needed to
>>>          >>> get the drive to work:
>>>          >>> options usb-storage quirks=059f:1061:u
>>>          >>>
>>>          >>> Should we still try to get uas working with this drive
>>> or should I
>>>          >>> send a patch hardcoding a quirk? I am on
>>> 5.13.2-300.fc34.x86_64 kernel
>>>          >>> now. Thanks for the feedback in advance.
>>>          >>>
>>>          >>
>>>          >> Hi,
>>>          >>
>>>          >>
>>>          >> sometimes we must give up. This thing is too elusive.
>>> Please send a
>>>          >> patch with a quirk.
>>>          >>
>>>          >>      Regards
>>>          >>
>>>          >>          Oliver
>>>          >>
>>>          >>
>>>          >
>>>          > Hi,
>>>          >
>>>          > thanks for confirming. Patch is attached, it appears to be
>>> working correctly when applied against 5.13.3. Please let me know if
>>> changes are required.
>>>
>>>          I seem to have missed the earlier part of this thread somehow.
>>>
>>>          Looking at the USB-ids, your model seems mightily close to
>>> this existing quirk:
>>>
>>>          UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
>>>                          "LaCie",
>>>                          "2Big Quadra USB3",
>>>                          USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>>>                          US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),
>>>
>>>          Before we go with the suggested patch, can you give the uas
>>> driver one last
>>>          try with:
>>>
>>>          options usb-storage quirks=059f:1061:fk
>>>
>>>          ? The fk translates like this:
>>>
>>>          f -> US_FL_NO_REPORT_OPCODES
>>>          k -> US_FL_NO_SAME
>>>
>>>          Regards,
>>>
>>>          Hans
>>>
>>