From: Oliver Neukum <oneukum@suse.com>
To: syzbot <syzbot+f5349b421c6213d34ce2@syzkaller.appspotmail.com>,
gustavo@embeddedor.com, andreyknvl@google.com,
syzkaller-bugs@googlegroups.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: WARNING in _chaoskey_fill/usb_submit_urb
Date: Mon, 30 Sep 2019 15:35:16 +0200 [thread overview]
Message-ID: <1569850516.2639.2.camel@suse.com> (raw)
In-Reply-To: <000000000000488dd305933945d2@google.com>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
Am Montag, den 23.09.2019, 07:31 -0700 schrieb syzbot:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit: e0bd8d79 usb-fuzzer: main usb gadget fuzzer driver
> git tree: https://github.com/google/kasan.git usb-fuzzer
> console output: https://syzkaller.appspot.com/x/log.txt?x=1452c6a1600000
> kernel config: https://syzkaller.appspot.com/x/.config?x=8847e5384a16f66a
> dashboard link: https://syzkaller.appspot.com/bug?extid=f5349b421c6213d34ce2
> compiler: gcc (GCC) 9.0.0 20181231 (experimental)
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16342d45600000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=166769b1600000
>
> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> Reported-by: syzbot+f5349b421c6213d34ce2@syzkaller.appspotmail.com
#syz test: https://github.com/google/kasan.git e0bd8d79
[-- Attachment #2: 0001-USB-chaoskey-fix-error-case-of-a-timeout.patch --]
[-- Type: text/x-patch, Size: 901 bytes --]
From 27b0085768b55f2ed8faf4f1254023a03dc3eb24 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Mon, 30 Sep 2019 15:19:13 +0200
Subject: [PATCH] USB: chaoskey: fix error case of a timeout
In case of a timeout communication with the device needs to be ended
from the host side, lest we overwrite an active URB
Signed-off-by: Oliver Neukum <oneukum@suse.de>
---
drivers/usb/misc/chaoskey.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/misc/chaoskey.c b/drivers/usb/misc/chaoskey.c
index cf5828ce927a..850f46cbace2 100644
--- a/drivers/usb/misc/chaoskey.c
+++ b/drivers/usb/misc/chaoskey.c
@@ -391,6 +391,8 @@ static int _chaoskey_fill(struct chaoskey *dev)
else
result = dev->valid;
out:
+ /* in case of a timeout */
+ usb_kill_urb(dev->urb);
/* Let the device go back to sleep eventually */
usb_autopm_put_interface(dev->interface);
--
2.16.4
next prev parent reply other threads:[~2019-09-30 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 14:31 WARNING in _chaoskey_fill/usb_submit_urb syzbot
2019-09-30 13:35 ` Oliver Neukum [this message]
2019-09-30 14:05 ` syzbot
2019-09-30 14:27 ` Oliver Neukum
2019-09-30 14:57 ` syzbot
2020-03-09 15:29 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569850516.2639.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=andreyknvl@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=syzbot+f5349b421c6213d34ce2@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).