From: Oliver Neukum <oneukum@suse.com>
To: Vladimir Stankovic <vladimir.stankovic@displaylink.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-usb <linux-usb@vger.kernel.org>,
mausb-host-devel <mausb-host-devel@displaylink.com>
Subject: Re: [PATCH v2 5/8] usb: mausb_host: Introduce PAL processing
Date: Wed, 26 Feb 2020 15:19:56 +0100 [thread overview]
Message-ID: <1582726796.17520.28.camel@suse.com> (raw)
In-Reply-To: <659eab4d-a995-d372-2c46-8b3d72ba13bc@displaylink.com>
Hi,
+ atomic_inc(&urb->use_count);
+
+ mausb_print_urb(urb);
+
+ /*
+ * Masking URB_SHORT_NOT_OK flag as SCSI driver is adding it where it
+ * should not, so it is breaking the USB drive on the linux
+ */
+ urb->transfer_flags &= ~URB_SHORT_NOT_OK;
This is extremely drastic and will break drivers. Which driver causes
the problems?
Regards
Oliver
prev parent reply other threads:[~2020-02-26 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 9:58 [PATCH v2 5/8] usb: mausb_host: Introduce PAL processing Vladimir Stankovic
2020-02-26 12:35 ` Oliver Neukum
2020-02-27 8:50 ` [External] " Vladimir Stankovic
2020-02-26 14:19 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582726796.17520.28.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mausb-host-devel@displaylink.com \
--cc=vladimir.stankovic@displaylink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).