From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F4FC10F27 for ; Tue, 10 Mar 2020 11:22:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D48824691 for ; Tue, 10 Mar 2020 11:22:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726273AbgCJLWu (ORCPT ); Tue, 10 Mar 2020 07:22:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:50536 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725937AbgCJLWu (ORCPT ); Tue, 10 Mar 2020 07:22:50 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1E524B22D; Tue, 10 Mar 2020 11:22:47 +0000 (UTC) Message-ID: <1583838270.11582.11.camel@suse.com> Subject: Re: USB transaction errors causing RCU stalls and kernel panics From: Oliver Neukum To: Jonas Karlsson , Peter Chen Cc: Mathias Nyman , Greg KH , "linux-usb@vger.kernel.org" , Alan Stern Date: Tue, 10 Mar 2020 12:04:30 +0100 In-Reply-To: References: <20200303163945.GB652754@kroah.com> <6909d182-6cc5-c07f-ed79-02c741aec60b@linux.intel.com> <1583331173.12738.26.camel@suse.com> <4fa64e92-64ce-07f3-ed8e-ea4e07d091bb@linux.intel.com> <699a49f2f69e494ea6558b99fad23cc4@actia.se> <20200310081452.GA14625@b29397-desktop> Content-Type: multipart/mixed; boundary="=-hVUogmiFDx3k+KTRaErW" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org --=-hVUogmiFDx3k+KTRaErW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Am Dienstag, den 10.03.2020, 10:04 +0000 schrieb Jonas Karlsson: > Yes, I have applied that commit. The logs I have attached so far have had that commit applied. > It reduces the amount of Unknown event type 37 messages significantly. I am a bit confused. If this still happens after you disabled autosuspend, the initial diagnosis can't be right. It looks like we are entering some kind of busy loop. Can you test the attached patches? Regards Oliver --=-hVUogmiFDx3k+KTRaErW Content-Disposition: attachment; filename*0=0001-cdc-acm-close-race-betrween-suspend-and-acm_softint.patc; filename*1=h Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-cdc-acm-close-race-betrween-suspend-and-acm_softint.patch"; charset="UTF-8" RnJvbSBlNWY5MWZhMzJlNTI5NGI3NjRlZDkzNjE1YzIwODM0ZWUzYmE2OTBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPbGl2ZXIgTmV1a3VtIDxvbmV1a3VtQHN1c2UuY29tPgpEYXRl OiBUaHUsIDUgTWFyIDIwMjAgMTE6MTY6MDIgKzAxMDAKU3ViamVjdDogW1BBVENIIDEvMl0gY2Rj LWFjbTogY2xvc2UgcmFjZSBiZXRyd2VlbiBzdXNwZW5kKCkgYW5kIGFjbV9zb2Z0aW50CgpTdXNw ZW5kIGluY3JlbWVudHMgYSBjb3VudGVyLCB0aGVuIGtpbGxzIHRoZSBVUkJzLAp0aGVuIGtpbGxz IHRoZSBzY2hlZHVsZWQgd29yay4gVGhlIHNjaGVkdWxlZCB3b3JrLCBob3dldmVyLAptYXkgcmVz Y2hlZHVsZSB0aGUgVVJCcy4gRml4IHRoaXMgYnkgaGF2aW5nIHRoZSB3b3JrCmNoZWNrIHRoZSBj b3VudGVyLgoKU2lnbmVkLW9mZi1ieTogT2xpdmVyIE5ldWt1bSA8b25ldWt1bUBzdXNlLmNvbT4K LS0tCiBkcml2ZXJzL3VzYi9jbGFzcy9jZGMtYWNtLmMgfCA2ICsrKy0tLQogMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJz L3VzYi9jbGFzcy9jZGMtYWNtLmMgYi9kcml2ZXJzL3VzYi9jbGFzcy9jZGMtYWNtLmMKaW5kZXgg NjJmNGZiOWIzNjJmLi43ZDAxNjczODJjODcgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL2NsYXNz L2NkYy1hY20uYworKysgYi9kcml2ZXJzL3VzYi9jbGFzcy9jZGMtYWNtLmMKQEAgLTU1NywxNCAr NTU3LDE0IEBAIHN0YXRpYyB2b2lkIGFjbV9zb2Z0aW50KHN0cnVjdCB3b3JrX3N0cnVjdCAqd29y aykKIAlzdHJ1Y3QgYWNtICphY20gPSBjb250YWluZXJfb2Yod29yaywgc3RydWN0IGFjbSwgd29y ayk7CiAKIAlpZiAodGVzdF9iaXQoRVZFTlRfUlhfU1RBTEwsICZhY20tPmZsYWdzKSkgewotCQlp ZiAoISh1c2JfYXV0b3BtX2dldF9pbnRlcmZhY2UoYWNtLT5kYXRhKSkpIHsKKwkJc21wX21iKCk7 IC8qIGFnYWluc3QgYWNtX3N1c3BlbmQoKSAqLworCQlpZiAoIWFjbS0+c3VzcF9jb3VudCkgewog CQkJZm9yIChpID0gMDsgaSA8IGFjbS0+cnhfYnVmbGltaXQ7IGkrKykKIAkJCQl1c2Jfa2lsbF91 cmIoYWNtLT5yZWFkX3VyYnNbaV0pOwogCQkJdXNiX2NsZWFyX2hhbHQoYWNtLT5kZXYsIGFjbS0+ aW4pOwogCQkJYWNtX3N1Ym1pdF9yZWFkX3VyYnMoYWNtLCBHRlBfS0VSTkVMKTsKLQkJCXVzYl9h dXRvcG1fcHV0X2ludGVyZmFjZShhY20tPmRhdGEpOworCQkJY2xlYXJfYml0KEVWRU5UX1JYX1NU QUxMLCAmYWNtLT5mbGFncyk7CiAJCX0KLQkJY2xlYXJfYml0KEVWRU5UX1JYX1NUQUxMLCAmYWNt LT5mbGFncyk7CiAJfQogCiAJaWYgKHRlc3RfYW5kX2NsZWFyX2JpdChFVkVOVF9UVFlfV0FLRVVQ LCAmYWNtLT5mbGFncykpCi0tIAoyLjE2LjQKCg== --=-hVUogmiFDx3k+KTRaErW Content-Disposition: attachment; filename="0002-cdc-acm-introduce-a-cool-down.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0002-cdc-acm-introduce-a-cool-down.patch"; charset="UTF-8" RnJvbSA0NmY4ZmU3ZGJjNTFkNjQ3NmJkODU4OWRjYmYwZmM4YTc2ZTk0MTAyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPbGl2ZXIgTmV1a3VtIDxvbmV1a3VtQHN1c2UuY29tPgpEYXRl OiBUdWUsIDEwIE1hciAyMDIwIDExOjU1OjIxICswMTAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIGNk Yy1hY206IGludHJvZHVjZSBhIGNvb2wgZG93bgoKSW1tZWRpYXRlIHN1Ym1pc3Npb24gaW4gY2Fz ZSBvZiBhIGJhYmJsaW5nIGRldmljZSBjYW4gbGVhZAp0byBhIGJ1c3kgbG9vcC4gSW50cm9kdWNp bmcgYSBkZWxheWVkIHdvcmsuCgpTaWduZWQtb2ZmLWJ5OiBPbGl2ZXIgTmV1a3VtIDxvbmV1a3Vt QHN1c2UuY29tPgotLS0KIGRyaXZlcnMvdXNiL2NsYXNzL2NkYy1hY20uYyB8IDI5ICsrKysrKysr KysrKysrKysrKysrKysrKysrKy0tCiBkcml2ZXJzL3VzYi9jbGFzcy9jZGMtYWNtLmggfCAgNSAr KysrLQogMiBmaWxlcyBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2NsYXNzL2NkYy1hY20uYyBiL2RyaXZlcnMvdXNiL2Ns YXNzL2NkYy1hY20uYwppbmRleCA3ZDAxNjczODJjODcuLmExZmJmNmJmNWNmNCAxMDA2NDQKLS0t IGEvZHJpdmVycy91c2IvY2xhc3MvY2RjLWFjbS5jCisrKyBiL2RyaXZlcnMvdXNiL2NsYXNzL2Nk Yy1hY20uYwpAQCAtNDEyLDkgKzQxMiwxMiBAQCBzdGF0aWMgdm9pZCBhY21fY3RybF9pcnEoc3Ry dWN0IHVyYiAqdXJiKQogCiBleGl0OgogCXJldHZhbCA9IHVzYl9zdWJtaXRfdXJiKHVyYiwgR0ZQ X0FUT01JQyk7Ci0JaWYgKHJldHZhbCAmJiByZXR2YWwgIT0gLUVQRVJNKQorCWlmIChyZXR2YWwg JiYgcmV0dmFsICE9IC1FUEVSTSAmJiByZXR2YWwgIT0gLUVOT0RFVikKIAkJZGV2X2VycigmYWNt LT5jb250cm9sLT5kZXYsCiAJCQkiJXMgLSB1c2Jfc3VibWl0X3VyYiBmYWlsZWQ6ICVkXG4iLCBf X2Z1bmNfXywgcmV0dmFsKTsKKwllbHNlCisJCWRldl92ZGJnKCZhY20tPmNvbnRyb2wtPmRldiwK KwkJCSJjb250cm9sIHJlc3VibWlzc2lvbiB0ZXJtaW5hdGVkICVkXG4iLCByZXR2YWwpOwogfQog CiBzdGF0aWMgaW50IGFjbV9zdWJtaXRfcmVhZF91cmIoc3RydWN0IGFjbSAqYWNtLCBpbnQgaW5k ZXgsIGdmcF90IG1lbV9mbGFncykKQEAgLTQzMCw2ICs0MzMsOCBAQCBzdGF0aWMgaW50IGFjbV9z dWJtaXRfcmVhZF91cmIoc3RydWN0IGFjbSAqYWNtLCBpbnQgaW5kZXgsIGdmcF90IG1lbV9mbGFn cykKIAkJCWRldl9lcnIoJmFjbS0+ZGF0YS0+ZGV2LAogCQkJCSJ1cmIgJWQgZmFpbGVkIHN1Ym1p c3Npb24gd2l0aCAlZFxuIiwKIAkJCQlpbmRleCwgcmVzKTsKKwkJfSBlbHNlIHsKKwkJCWRldl92 ZGJnKCZhY20tPmRhdGEtPmRldiwgImludGVuZGVkIGZhaWx1cmUgJWRcbiIsIHJlcyk7CiAJCX0K IAkJc2V0X2JpdChpbmRleCwgJmFjbS0+cmVhZF91cmJzX2ZyZWUpOwogCQlyZXR1cm4gcmVzOwpA QCAtNDcxLDYgKzQ3Niw3IEBAIHN0YXRpYyB2b2lkIGFjbV9yZWFkX2J1bGtfY2FsbGJhY2soc3Ry dWN0IHVyYiAqdXJiKQogCWludCBzdGF0dXMgPSB1cmItPnN0YXR1czsKIAlib29sIHN0b3BwZWQg PSBmYWxzZTsKIAlib29sIHN0YWxsZWQgPSBmYWxzZTsKKwlib29sIGNvb2xkb3duID0gZmFsc2U7 CiAKIAlkZXZfdmRiZygmYWNtLT5kYXRhLT5kZXYsICJnb3QgdXJiICVkLCBsZW4gJWQsIHN0YXR1 cyAlZFxuIiwKIAkJcmItPmluZGV4LCB1cmItPmFjdHVhbF9sZW5ndGgsIHN0YXR1cyk7CkBAIC00 OTcsNiArNTAzLDEzIEBAIHN0YXRpYyB2b2lkIGFjbV9yZWFkX2J1bGtfY2FsbGJhY2soc3RydWN0 IHVyYiAqdXJiKQogCQkJX19mdW5jX18sIHN0YXR1cyk7CiAJCXN0b3BwZWQgPSB0cnVlOwogCQli cmVhazsKKwljYXNlIC1FT1ZFUkZMT1c6CisJCWRldl9kYmcoJmFjbS0+ZGF0YS0+ZGV2LAorCQkJ IiVzIC0gY29vbGluZyBiYWJibGluZyBkZXZpY2VcbiIsIF9fZnVuY19fKTsKKwkJdXNiX21hcmtf bGFzdF9idXN5KGFjbS0+ZGV2KTsKKwkJc2V0X2JpdChyYi0+aW5kZXgsICZhY20tPnVyYnNfaW5f ZXJyb3JfZGVsYXkpOworCQljb29sZG93biA9IHRydWU7CisJCWJyZWFrOwogCWRlZmF1bHQ6CiAJ CWRldl9kYmcoJmFjbS0+ZGF0YS0+ZGV2LAogCQkJIiVzIC0gbm9uemVybyB1cmIgc3RhdHVzIHJl Y2VpdmVkOiAlZFxuIiwKQEAgLTUxOCw5ICs1MzEsMTEgQEAgc3RhdGljIHZvaWQgYWNtX3JlYWRf YnVsa19jYWxsYmFjayhzdHJ1Y3QgdXJiICp1cmIpCiAJICovCiAJc21wX21iX19hZnRlcl9hdG9t aWMoKTsKIAotCWlmIChzdG9wcGVkIHx8IHN0YWxsZWQpIHsKKwlpZiAoc3RvcHBlZCB8fCBzdGFs bGVkIHx8IGNvb2xkb3duKSB7CiAJCWlmIChzdGFsbGVkKQogCQkJc2NoZWR1bGVfd29yaygmYWNt LT53b3JrKTsKKwkJZWxzZSBpZiAoY29vbGRvd24pCisJCQlzY2hlZHVsZV9kZWxheWVkX3dvcmso JmFjbS0+ZHdvcmssIEhaIC8gMik7CiAJCXJldHVybjsKIAl9CiAKQEAgLTU2Nyw2ICs1ODIsMTIg QEAgc3RhdGljIHZvaWQgYWNtX3NvZnRpbnQoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQogCQl9 CiAJfQogCisJaWYgKHRlc3RfYW5kX2NsZWFyX2JpdChBQ01fRVJST1JfREVMQVksICZhY20tPmZs YWdzKSkgeworCQlmb3IgKGkgPSAwOyBpIDwgQUNNX05SOyBpKyspIAorCQkJaWYgKHRlc3RfYW5k X2NsZWFyX2JpdChpLCAmYWNtLT51cmJzX2luX2Vycm9yX2RlbGF5KSkKKwkJCQkJYWNtX3N1Ym1p dF9yZWFkX3VyYihhY20sIGksIEdGUF9OT0lPKTsKKwl9CisKIAlpZiAodGVzdF9hbmRfY2xlYXJf Yml0KEVWRU5UX1RUWV9XQUtFVVAsICZhY20tPmZsYWdzKSkKIAkJdHR5X3BvcnRfdHR5X3dha2V1 cCgmYWNtLT5wb3J0KTsKIH0KQEAgLTEzMjUsNiArMTM0Niw3IEBAIHN0YXRpYyBpbnQgYWNtX3By b2JlKHN0cnVjdCB1c2JfaW50ZXJmYWNlICppbnRmLAogCWFjbS0+cmVhZHNpemUgPSByZWFkc2l6 ZTsKIAlhY20tPnJ4X2J1ZmxpbWl0ID0gbnVtX3J4X2J1ZjsKIAlJTklUX1dPUksoJmFjbS0+d29y aywgYWNtX3NvZnRpbnQpOworCUlOSVRfREVMQVlFRF9XT1JLKCZhY20tPmR3b3JrLCBhY21fc29m dGludCk7CiAJaW5pdF93YWl0cXVldWVfaGVhZCgmYWNtLT53aW9jdGwpOwogCXNwaW5fbG9ja19p bml0KCZhY20tPndyaXRlX2xvY2spOwogCXNwaW5fbG9ja19pbml0KCZhY20tPnJlYWRfbG9jayk7 CkBAIC0xNTM0LDYgKzE1NTYsNyBAQCBzdGF0aWMgdm9pZCBhY21fZGlzY29ubmVjdChzdHJ1Y3Qg dXNiX2ludGVyZmFjZSAqaW50ZikKIAogCWFjbV9raWxsX3VyYnMoYWNtKTsKIAljYW5jZWxfd29y a19zeW5jKCZhY20tPndvcmspOworCWNhbmNlbF9kZWxheWVkX3dvcmtfc3luYygmYWNtLT5kd29y ayk7CiAKIAl0dHlfdW5yZWdpc3Rlcl9kZXZpY2UoYWNtX3R0eV9kcml2ZXIsIGFjbS0+bWlub3Ip OwogCkBAIC0xNTc2LDYgKzE1OTksOCBAQCBzdGF0aWMgaW50IGFjbV9zdXNwZW5kKHN0cnVjdCB1 c2JfaW50ZXJmYWNlICppbnRmLCBwbV9tZXNzYWdlX3QgbWVzc2FnZSkKIAogCWFjbV9raWxsX3Vy YnMoYWNtKTsKIAljYW5jZWxfd29ya19zeW5jKCZhY20tPndvcmspOworCWNhbmNlbF9kZWxheWVk X3dvcmtfc3luYygmYWNtLT5kd29yayk7CisJYWNtLT51cmJzX2luX2Vycm9yX2RlbGF5ID0gMDsK IAogCXJldHVybiAwOwogfQpkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvY2xhc3MvY2RjLWFjbS5o IGIvZHJpdmVycy91c2IvY2xhc3MvY2RjLWFjbS5oCmluZGV4IGNhMWMwMjYzODJjMi4uY2Q1ZTlk OGFiMjM3IDEwMDY0NAotLS0gYS9kcml2ZXJzL3VzYi9jbGFzcy9jZGMtYWNtLmgKKysrIGIvZHJp dmVycy91c2IvY2xhc3MvY2RjLWFjbS5oCkBAIC0xMDksOCArMTA5LDExIEBAIHN0cnVjdCBhY20g ewogIwkJZGVmaW5lIEVWRU5UX1RUWV9XQUtFVVAJMAogIwkJZGVmaW5lIEVWRU5UX1JYX1NUQUxM CTEKICMJCWRlZmluZSBBQ01fVEhST1RUTEVECTIKKyMJCWRlZmluZSBBQ01fRVJST1JfREVMQVkJ MworCXVuc2lnbmVkIGxvbmcgdXJic19pbl9lcnJvcl9kZWxheTsJCS8qIHRoZXNlIG5lZWQgdG8g YmUgcmVzdGFydGVkIGFmdGVyIGEgZGVsYXkgKi8KIAlzdHJ1Y3QgdXNiX2NkY19saW5lX2NvZGlu ZyBsaW5lOwkJLyogYml0cywgc3RvcCwgcGFyaXR5ICovCi0Jc3RydWN0IHdvcmtfc3RydWN0IHdv cms7CQkJLyogd29yayBxdWV1ZSBlbnRyeSBmb3IgbGluZSBkaXNjaXBsaW5lIHdha2luZyB1cCAq LworCXN0cnVjdCB3b3JrX3N0cnVjdCB3b3JrOwkJCS8qIHdvcmsgcXVldWUgZW50cnkgZm9yIHZh cmlvdXMgcHVycG9zZXMqLworCXN0cnVjdCBkZWxheWVkX3dvcmsgZHdvcms7CQkJLyogZm9yIGNv b2wgZG93bnMgbmVlZGVkIGluIGVycm9yIHJlY292ZXJ5ICovCiAJdW5zaWduZWQgaW50IGN0cmxp bjsJCQkJLyogaW5wdXQgY29udHJvbCBsaW5lcyAoRENELCBEU1IsIFJJLCBicmVhaywgb3ZlcnJ1 bnMpICovCiAJdW5zaWduZWQgaW50IGN0cmxvdXQ7CQkJCS8qIG91dHB1dCBjb250cm9sIGxpbmVz IChEVFIsIFJUUykgKi8KIAlzdHJ1Y3QgYXN5bmNfaWNvdW50IGlvY291bnQ7CQkJLyogY291bnRl cnMgZm9yIGNvbnRyb2wgbGluZSBjaGFuZ2VzICovCi0tIAoyLjE2LjQKCg== --=-hVUogmiFDx3k+KTRaErW--