From: Oliver Neukum <oneukum@suse.com>
To: Jonas Karlsson <jonas.karlsson@actia.se>,
Fabio Estevam <festevam@gmail.com>
Cc: Peter Chen <peter.chen@nxp.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: USB transaction errors causing RCU stalls and kernel panics
Date: Wed, 11 Mar 2020 11:28:43 +0100 [thread overview]
Message-ID: <1583922523.20566.4.camel@suse.com> (raw)
In-Reply-To: <fc2d27c17ebc409ea8c318c22ac1f4a7@actia.se>
Am Mittwoch, den 11.03.2020, 06:25 +0000 schrieb Jonas Karlsson:
> Hi Fabio,
>
> > Hi Jonas,
> >
> > On Tue, Mar 10, 2020 at 1:07 PM Jonas Karlsson <jonas.karlsson@actia.se>
> > wrote:
> >
> > > I have also _reverted_ this patch after recommendation from NXP to avoid
> >
> > RCU stall
> > > crashes:
> > >
> > > commit 077506972ba23772b752e08b1ab7052cf5f04511
> > > Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > > Date: Mon Jul 9 13:47:30 2018 -0700
> > >
> > > rcu: Make need_resched() respond to urgent RCU-QS needs
> >
> > Could you please test without this revert?
> >
> > Thanks
>
> I removed the revert and it still works fine.
Hi,
it is good that we have something that works.
It would be even better if we understood exactly how
it works. In fact that these patches work and are needed
may very well indicate that error handling on at least
some XHCs does not work as expected.
So a question and a request, if I may.
Did you run the test with autosuspend disabled? If so could
you retest with it enabled?
Secondly could you run tests with
commit 7c8f7af078a4eda73f347667d12584736e613062
Author: Oliver Neukum <oneukum@suse.com>
Date: Thu Mar 5 11:16:02 2020 +0100
cdc-acm: close race betrween suspend() and acm_softint
not applied (respectively reverted) with and without autosuspend?
Regards
Oliver
PS: When I submit upstream, may I add your 'Tested-by'?
next prev parent reply other threads:[~2020-03-11 10:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 15:05 USB transaction errors causing RCU stalls and kernel panics Jonas Karlsson
2020-03-03 16:39 ` Greg KH
2020-03-03 20:08 ` Jonas Karlsson
2020-03-04 6:37 ` Greg KH
2020-03-04 10:29 ` Oliver Neukum
2020-03-04 12:11 ` Mathias Nyman
2020-03-04 14:12 ` Oliver Neukum
2020-03-04 16:21 ` Mathias Nyman
2020-03-06 1:31 ` Peter Chen
2020-03-09 14:21 ` Jonas Karlsson
2020-03-10 8:14 ` Peter Chen
2020-03-10 10:04 ` Jonas Karlsson
2020-03-10 11:04 ` Oliver Neukum
2020-03-10 11:21 ` Oliver Neukum
2020-03-10 12:26 ` Jonas Karlsson
2020-03-10 16:04 ` Jonas Karlsson
2020-03-10 16:11 ` Fabio Estevam
2020-03-11 6:25 ` Jonas Karlsson
2020-03-11 10:28 ` Oliver Neukum [this message]
2020-03-11 14:59 ` Jonas Karlsson
2020-03-12 13:45 ` Oliver Neukum
2020-03-12 15:37 ` Jonas Karlsson
2020-03-13 9:27 ` Oliver Neukum
2020-03-16 7:07 ` Jonas Karlsson
2020-03-23 11:37 ` Jonas Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583922523.20566.4.camel@suse.com \
--to=oneukum@suse.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonas.karlsson@actia.se \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).