From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE0F2C10DCE for ; Thu, 12 Mar 2020 13:45:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD4202067C for ; Thu, 12 Mar 2020 13:45:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727431AbgCLNpo (ORCPT ); Thu, 12 Mar 2020 09:45:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:35660 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgCLNpo (ORCPT ); Thu, 12 Mar 2020 09:45:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 24B83AD1E; Thu, 12 Mar 2020 13:45:42 +0000 (UTC) Message-ID: <1584020739.20566.10.camel@suse.com> Subject: Re: USB transaction errors causing RCU stalls and kernel panics From: Oliver Neukum To: Jonas Karlsson , Fabio Estevam Cc: Peter Chen , Mathias Nyman , Greg KH , "linux-usb@vger.kernel.org" , Alan Stern Date: Thu, 12 Mar 2020 14:45:39 +0100 In-Reply-To: References: <20200303163945.GB652754@kroah.com> <6909d182-6cc5-c07f-ed79-02c741aec60b@linux.intel.com> <1583331173.12738.26.camel@suse.com> <4fa64e92-64ce-07f3-ed8e-ea4e07d091bb@linux.intel.com> <699a49f2f69e494ea6558b99fad23cc4@actia.se> <20200310081452.GA14625@b29397-desktop> <1583838270.11582.11.camel@suse.com> <1583839306.11582.12.camel@suse.de> <325d5af5d4c44eafac94fc8e0e4d1a7d@actia.se> <1583922523.20566.4.camel@suse.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Am Mittwoch, den 11.03.2020, 14:59 +0000 schrieb Jonas Karlsson: > Hi Oliver, > > > Hi, > > > > it is good that we have something that works. > > It would be even better if we understood exactly how it works. In fact that > > these patches work and are needed may very well indicate that error > > handling on at least some XHCs does not work as expected. > > > > So a question and a request, if I may. > > Did you run the test with autosuspend disabled? If so could you retest with it > > enabled? > > I have only tested with autosuspend enabled. > > > Secondly could you run tests with > > > > commit 7c8f7af078a4eda73f347667d12584736e613062 > > Author: Oliver Neukum > > Date: Thu Mar 5 11:16:02 2020 +0100 > > > > cdc-acm: close race betrween suspend() and acm_softint > > > > not applied (respectively reverted) with and without autosuspend? > > I ran a test with this commit reverted and saw no difference in behavior. > i.e we do not get event spam with this commit reverted. > I tested with enabled and disabled autosuspend. > > > > > Regards > > Oliver > > > > PS: When I submit upstream, may I add your 'Tested-by'? > > Sure, you can add me, but I have only tested that this specific problem > seems to be solved. The normal functionality has not been tested properly yet > on our side. Hi, thank you. In this case it looks like the wisest course is to wait a few days then. Thank you for thorough testing. Regards Oliver