From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Alan Stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 0/7] Universal Serial Bus: Removing Acronyms
Date: Thu, 2 Apr 2020 10:15:39 +0800 [thread overview]
Message-ID: <1585793739.28772.4.camel@mhfsdcap03> (raw)
In-Reply-To: <Pine.LNX.4.44L0.2004011036470.22914-100000@netrider.rowland.org>
On Wed, 2020-04-01 at 10:43 -0400, Alan Stern wrote:
> On Wed, 1 Apr 2020, Felipe Balbi wrote:
>
> >
> > Hi,
> >
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> > > On Wed, Apr 01, 2020 at 10:32:42AM +0300, Felipe Balbi wrote:
> > >> 764 files changed, 86304 insertions(+), 86304 deletions(-)
> > >
> > > Ah, a nice tiny patchset, I'll try to sneak this in during the merge
> > > window now :)
> >
> > That's great, Greg. It'll help hundreds of people, I'm sure.
> >
> > > nice job...
> >
> > Thank you
>
> Yes indeed. Not to mention the admirable side effect of increasing the
> amount of exercise our fingers will get in the future while we write
> patches and new drivers. And a wonderful example of how a sizable
> _increase_ in the total size of the kernel source can lead to a
> _decrease_ in confusion for readers.
>
I find that I will spend more time to read/write the code!
e.g.
-static void uhci_unlink_qh(struct uhci_hcd *uhci, struct uhci_qh *qh)
+static void universal_host_controller_interface_unlink_qh(struct
universal_host_controller_interface_hcd
*universal_host_controller_interface, struct
universal_host_controller_interface_qh *qh)
> (Plus this is a great illustration of how consistently violating the
> 80-column rule can be justifiable under the right circumstances.)
>
> Alan Stern
>
next prev parent reply other threads:[~2020-04-02 2:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 7:32 [PATCH 0/7] Universal Serial Bus: Removing Acronyms Felipe Balbi
2020-04-01 7:32 ` [PATCH 3/7] universal host controller interface: remove acronyms Felipe Balbi
2020-04-01 7:38 ` [PATCH 0/7] Universal Serial Bus: Removing Acronyms Greg Kroah-Hartman
2020-04-01 7:44 ` Felipe Balbi
2020-04-01 10:26 ` Peter Chen
2020-04-01 11:13 ` Greg Kroah-Hartman
2020-04-01 11:34 ` Felipe Balbi
2020-04-01 14:43 ` Alan Stern
2020-04-02 2:15 ` Chunfeng Yun [this message]
2020-04-01 18:06 ` Thinh Nguyen
2020-04-01 18:48 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1585793739.28772.4.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox