* [PATCH] cdc-acm: Add DISABLE_ECHO quirk for Microchip/SMSC chip
@ 2020-06-05 10:54 Joakim Tjernlund
2020-06-09 9:18 ` Joakim Tjernlund
2020-06-09 10:25 ` Oliver Neukum
0 siblings, 2 replies; 3+ messages in thread
From: Joakim Tjernlund @ 2020-06-05 10:54 UTC (permalink / raw)
To: linux-usb; +Cc: Joakim Tjernlund, stable
USB_DEVICE(0x0424, 0x274e) can send data before cdc_acm is ready,
causing garbage chars on the TTY causing stray input to the shell
and/or login prompt.
Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Cc: stable@vger.kernel.org
---
drivers/usb/class/cdc-acm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index ded8d93834ca..d579b05a2c2b 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1689,6 +1689,8 @@ static int acm_pre_reset(struct usb_interface *intf)
static const struct usb_device_id acm_ids[] = {
/* quirky and broken devices */
+ { USB_DEVICE(0x0424, 0x274e), /* Microchip Technology, Inc. (formerly SMSC) */
+ .driver_info = DISABLE_ECHO, }, /* DISABLE ECHO in termios flag */
{ USB_DEVICE(0x076d, 0x0006), /* Denso Cradle CU-321 */
.driver_info = NO_UNION_NORMAL, },/* has no union descriptor */
{ USB_DEVICE(0x17ef, 0x7000), /* Lenovo USB modem */
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] cdc-acm: Add DISABLE_ECHO quirk for Microchip/SMSC chip
2020-06-05 10:54 [PATCH] cdc-acm: Add DISABLE_ECHO quirk for Microchip/SMSC chip Joakim Tjernlund
@ 2020-06-09 9:18 ` Joakim Tjernlund
2020-06-09 10:25 ` Oliver Neukum
1 sibling, 0 replies; 3+ messages in thread
From: Joakim Tjernlund @ 2020-06-09 9:18 UTC (permalink / raw)
To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Cc: stable@vger.kernel.org, Joakim Tjernlund
USB_DEVICE(0x0424, 0x274e) can send data before cdc_acm is ready,
causing garbage chars on the TTY causing stray input to the shell
and/or login prompt.
Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Cc: stable@vger.kernel.org
---
drivers/usb/class/cdc-acm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index ded8d93834ca..d579b05a2c2b 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1689,6 +1689,8 @@ static int acm_pre_reset(struct usb_interface *intf)
static const struct usb_device_id acm_ids[] = {
/* quirky and broken devices */
+ { USB_DEVICE(0x0424, 0x274e), /* Microchip Technology, Inc. (formerly SMSC) */
+ .driver_info = DISABLE_ECHO, }, /* DISABLE ECHO in termios flag */
{ USB_DEVICE(0x076d, 0x0006), /* Denso Cradle CU-321 */
.driver_info = NO_UNION_NORMAL, },/* has no union descriptor */
{ USB_DEVICE(0x17ef, 0x7000), /* Lenovo USB modem */
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cdc-acm: Add DISABLE_ECHO quirk for Microchip/SMSC chip
2020-06-05 10:54 [PATCH] cdc-acm: Add DISABLE_ECHO quirk for Microchip/SMSC chip Joakim Tjernlund
2020-06-09 9:18 ` Joakim Tjernlund
@ 2020-06-09 10:25 ` Oliver Neukum
1 sibling, 0 replies; 3+ messages in thread
From: Oliver Neukum @ 2020-06-09 10:25 UTC (permalink / raw)
To: Joakim Tjernlund, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org
Cc: stable@vger.kernel.org
Am Dienstag, den 09.06.2020, 09:18 +0000 schrieb Joakim Tjernlund:
> USB_DEVICE(0x0424, 0x274e) can send data before cdc_acm is ready,
> causing garbage chars on the TTY causing stray input to the shell
> and/or login prompt.
>
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> Cc: stable@vger.kernel.org
Acked-by: Oliver Neukum <oneukum@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-09 10:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-05 10:54 [PATCH] cdc-acm: Add DISABLE_ECHO quirk for Microchip/SMSC chip Joakim Tjernlund
2020-06-09 9:18 ` Joakim Tjernlund
2020-06-09 10:25 ` Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).