From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>, Peter Chen <Peter.Chen@nxp.com>,
"Minas Harutyunyan" <hminas@synopsys.com>,
Felipe Balbi <balbi@kernel.org>,
"Michal Simek" <michal.simek@xilinx.com>,
Mathias Nyman <mathias.nyman@intel.com>, Bin Liu <b-liu@ti.com>,
Pawel Laszczak <pawell@cadence.com>,
YueHaibing <yuehaibing@huawei.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Jason Yan <yanaijie@huawei.com>,
Jia-Ju Bai <baijiaju1990@gmail.com>,
Stephen Boyd <swboyd@chromium.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Arnd Bergmann <arnd@arndb.de>,
"Jules Irenge" <jbi.octave@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Rob Gill <rrobgill@protonmail.com>,
Macpaul Lin <macpaul.lin@mediatek.com>
Subject: Re: [PATCH] USB: ch9: add "USB_" prefix in front of TEST defines
Date: Mon, 22 Jun 2020 12:17:35 +0800 [thread overview]
Message-ID: <1592799455.3798.1.camel@mhfsdcap03> (raw)
In-Reply-To: <20200618144206.2655890-1-gregkh@linuxfoundation.org>
On Thu, 2020-06-18 at 16:42 +0200, Greg Kroah-Hartman wrote:
> For some reason, the TEST_ defines in the usb/ch9.h files did not have
> the USB_ prefix on it, making it a bit confusing when reading the file,
> as well as not the nicest thing to do in a uapi file.
>
> So fix that up and add the USB_ prefix on to them, and fix up all
> in-kernel usages. This included deleting the duplicate copy in the
> net2272.h file.
>
> Cc: Peter Chen <Peter.Chen@nxp.com>
> Cc: Minas Harutyunyan <hminas@synopsys.com>
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Mathias Nyman <mathias.nyman@intel.com>
> Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Cc: Bin Liu <b-liu@ti.com>
> Cc: Pawel Laszczak <pawell@cadence.com>
> Cc: YueHaibing <yuehaibing@huawei.com>
> Cc: Nathan Chancellor <natechancellor@gmail.com>
> Cc: Jason Yan <yanaijie@huawei.com>
> Cc: Jia-Ju Bai <baijiaju1990@gmail.com>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Jules Irenge <jbi.octave@gmail.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> Cc: Rob Gill <rrobgill@protonmail.com>
> Cc: Macpaul Lin <macpaul.lin@mediatek.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/usb/cdns3/ep0.c | 8 ++++----
> drivers/usb/chipidea/udc.c | 10 +++++-----
> drivers/usb/common/debug.c | 10 +++++-----
> drivers/usb/dwc2/debugfs.c | 20 ++++++++++----------
> drivers/usb/dwc2/gadget.c | 10 +++++-----
> drivers/usb/dwc3/debugfs.c | 20 ++++++++++----------
> drivers/usb/dwc3/ep0.c | 10 +++++-----
> drivers/usb/dwc3/gadget.c | 10 +++++-----
> drivers/usb/gadget/udc/bdc/bdc_ep.c | 10 +++++-----
> drivers/usb/gadget/udc/gr_udc.c | 4 ++--
> drivers/usb/gadget/udc/mv_udc_core.c | 2 +-
> drivers/usb/gadget/udc/net2272.c | 2 +-
> drivers/usb/gadget/udc/net2272.h | 5 -----
> drivers/usb/gadget/udc/udc-xilinx.c | 4 ++--
> drivers/usb/host/xhci-hub.c | 7 ++++---
> drivers/usb/misc/ehset.c | 8 ++++----
> drivers/usb/mtu3/mtu3_gadget_ep0.c | 16 ++++++++--------
for mtu3,
Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Thanks
> drivers/usb/musb/musb_gadget_ep0.c | 20 ++++++++------------
> drivers/usb/musb/musb_virthub.c | 20 ++++++++++----------
> include/uapi/linux/usb/ch9.h | 10 +++++-----
> 20 files changed, 99 insertions(+), 107 deletions(-)
prev parent reply other threads:[~2020-06-22 4:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 14:42 [PATCH] USB: ch9: add "USB_" prefix in front of TEST defines Greg Kroah-Hartman
2020-06-19 1:42 ` Peter Chen
2020-06-19 9:17 ` Minas Harutyunyan
2020-06-19 15:13 ` Bin Liu
2020-06-22 4:17 ` Chunfeng Yun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1592799455.3798.1.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=Peter.Chen@nxp.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=arnd@arndb.de \
--cc=b-liu@ti.com \
--cc=baijiaju1990@gmail.com \
--cc=balbi@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=jbi.octave@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul.lin@mediatek.com \
--cc=mathias.nyman@intel.com \
--cc=michal.simek@xilinx.com \
--cc=natechancellor@gmail.com \
--cc=pawell@cadence.com \
--cc=rrobgill@protonmail.com \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
--cc=yanaijie@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox