From: Oliver Neukum <oneukum@suse.com>
To: Himadri Pandya <himadrispandya@gmail.com>,
gregKH@linuxfoundation.org,
Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org
Subject: usb_control_msg_send() and usb_control_msg_recv() are highly problematic
Date: Wed, 23 Sep 2020 12:59:00 +0200 [thread overview]
Message-ID: <1600858740.26851.16.camel@suse.com> (raw)
Hi,
you probably do not want to hear this. I was out of comission
for the last week weeks and I should have looked at this more closely.
You may notice that usb_control_msg() for times immemorial has been
using GFP_NOIO internally. This is because control messages are needed
in a lot of contexts such as SCSI error handling and runtime PM
that require GFP_NOIO. IIRC at that time we found ourselves unable to
go through all those call chains, so we pulled the nuclear option
and slapped a blanket GFP_NOIO on the function.
Today I got a patch that outright deleted a memory allocation with
GFP_NOIO, so I looked into this. We are making the same mistake
we couldn't fix in the past.
I am afraid the API has to be changed to include memory flags.
And we should do this now while the damage is still within limits.
I am preparing patches.
Regards
Oliver
next reply other threads:[~2020-09-23 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 10:59 Oliver Neukum [this message]
2020-09-23 11:07 ` usb_control_msg_send() and usb_control_msg_recv() are highly problematic Greg KH
2020-09-23 11:28 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600858740.26851.16.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregKH@linuxfoundation.org \
--cc=himadrispandya@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).