Re: [PATCH] usb: fotg210-hcd: Fix an error message

Chunfeng Yun
2021-05-07T02:20:43Z

On Thu, 2021-05-06 at 22:39 +0200, Christophe JAILLET wrote:
> 'retval' is known to be -ENODEV here.
> This is a hard-coded default error code which is not useful in the error
> message. Moreover, another error message is printed at the end of the
> error handling path. The corresponding error code (-ENOMEM) is more
> informative.
>
> So remove simplify the first error message.
>
> While at it, also remove the useless initialization of 'retval'.
>
> Fixes: 7d50195f6c50 ("usb: host: Faraday fotg210-hcd driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/usb/host/fotg210-hcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
> index 6cac642520fc..9c2eda0918e1 100644
> --- a/drivers/usb/host/fotg210-hcd.c
> +++ b/drivers/usb/host/fotg210-hcd.c
> @@ -5568,7 +5568,7 @@ static int fotg210_hcd_probe(struct platform_device *pdev)
> struct usb_hcd *hcd;
> struct resource *res;
> int irq;
> - int retval = -ENODEV;
> + int retval;
> struct fotg210_hcd *fotg210;
>
> if (usb_disabled())
> @@ -5588,7 +5588,7 @@ static int fotg210_hcd_probe(struct platform_device *pdev)
> hcd = usb_create_hcd(&fotg210_fotg210_hc_driver, dev,
> dev_name(dev));
> if (!hcd) {
> - dev_err(dev, "failed to create hcd with err %d\n", retval);
> + dev_err(dev, "failed to create hcd\n");
> retval = -ENOMEM;
How about moving this line before dev_err()? then could keep error log
unchanged.

> goto fail_create_hcd;
> }