Re: [PATCH v2 02/13] dt-bindings: usb: mtu3: add optional property to disable usb2 ports

Chunfeng Yun
2021-07-13T09:00:48Z

On Mon, 2021-07-12 at 13:08 -0600, Rob Herring wrote:
> On Fri, Jun 18, 2021 at 05:29:07PM +0800, Chunfeng Yun wrote:
> > Add support to disable specific usb2 host ports, it's useful when
> > a usb2 port is disabled on some platforms, but enabled on others for
> > the same SoC, another case is that the different package may support
> > different number of ports.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v2: no changes
> > ---
> > Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > index 2cac7a87ce36..3e6f2750f48d 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > @@ -166,6 +166,12 @@ properties:
> > description: The mask to disable u3ports, bit0 for u3port0,
> > bit1 for u3port1, ... etc
> >
> > + mediatek,u2p-dis-msk:
>
> Just spell out 'mask'.
There is already a property "mediatek,u3p-dis-msk", prefer to use the
same format, thanks

>
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description: The mask to disable u2ports, bit0 for u2port0,
> > + bit1 for u2port1, ... etc; but can't disable u2port0 if dual role mode
> > + is enabled, so will be skipped in this case.
> > +
> > # Required child node when support dual-role
> > patternProperties:
> > "^usb@[0-9a-f]+$":
> > --
> > 2.18.0
> >
> >