From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v1] leds: fix regression in usbport led trigger From: Christian Lamparter Message-Id: <1655079.TiSNOjKWFA@debian64> Date: Tue, 01 Jan 2019 15:00:03 +0100 To: Jacek Anaszewski Cc: linux-usb@vger.kernel.org, linux-leds@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , Greg Kroah-Hartman List-ID: SGVsbG8gSmFjZWssCk9uIEZyaWRheSwgRGVjZW1iZXIgMjgsIDIwMTggNToyOTo1NiBQTSBDRVQg SmFjZWsgQW5hc3pld3NraSB3cm90ZToKPiBPbiAxMi8yNS8xOCA5OjQ5IFBNLCBDaHJpc3RpYW4g TGFtcGFydGVyIHdyb3RlOgo+ID4gVGhlIHBhdGNoICJ1c2I6IHNpbXBsaWZ5IHVzYnBvcnQgdHJp Z2dlciIgdG9nZXRoZXIgd2l0aAo+ID4gImxlZHM6IHRyaWdnZXJzOiBhZGQgZGV2aWNlIGF0dHJp YnV0ZSBzdXBwb3J0IiBjYXVzZWQgYW4KPiA+IHJlZ3Jlc3Npb24gZm9yIHRoZSB1c2Jwb3J0IHRy aWdnZXIuIGl0IHdpbGwgbm8gbG9uZ2VyCj4gPiBlbnVtZXJhdGUgYW55IGFjdGl2ZSB1c2IgaHVi IHBvcnRzIHVuZGVyIHRoZSAicG9ydHMiCj4gPiBkaXJlY3RvcnkgaW4gdGhlIHN5c2ZzIGNsYXNz IGRpcmVjdG9yeSwgaWYgdGhlIHVzYiBob3N0Cj4gPiBkcml2ZXJzIGFyZSBmdWxseSBpbml0aWFs aXplZCBiZWZvcmUgdGhlIHVzYnBvcnQgdHJpZ2dlcgo+ID4gd2FzIGxvYWRlZC4KPiA+IAo+ID4g VGhlIHJlYXNvbiBpcyB0aGF0IHRoZSB1c2Jwb3J0IGRyaXZlciB0cmllcyB0byByZWdpc3Rlcgo+ ID4gdGhlIHN5c2ZzIGVudHJpZXMgZHVyaW5nIHRoZSBhY3RpdmF0ZSgpIGNhbGxiYWNrLiBBbmQg dGhpcwo+ID4gd2lsbCBmYWlsIHdpdGggLTIgLyBFTk9FTlQgYmVjYXVzZSB0aGUgcGF0Y2gKPiA+ ICJsZWRzOiB0cmlnZ2VyczogYWRkIGRldmljZSBhdHRyaWJ1dGUgc3VwcG9ydCIgbWFkZSBpdCBz bwo+ID4gdGhhdCB0aGUgc3lzZnMgInBvcnRzIiBncm91cCB3YXMgb25seSBiZWluZyBhZGRlZCBh ZnRlcgo+ID4gdGhlIGFjdGl2YXRlKCkgY2FsbGJhY2sgc3VjY2VlZGVkLgo+ID4gCj4gPiBUaGlz IHZlcnNpb24gb2YgdGhlIHBhdGNoIG1vdmVzIHRoZSBkZXZpY2VfYWRkX2dyb3VwcygpCj4gPiBp biBmcm9udCBvZiB0aGUgY2FsbCB0byB0aGUgdHJpZ2dlcidzIGFjdGl2YXRlKCkgZnVuY3Rpb24K PiA+IGluIG9yZGVyIHRvIHNvbHZlIHRoZSBwcm9ibGVtLgo+ID4gCj4gPiBDYzogR3JlZyBLcm9h aC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPiA+IENjOiBVd2UgS2xlaW5l LUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+ID4gQ2M6IFJhZmHFgiBN acWCZWNraSA8emFqZWM1QGdtYWlsLmNvbT4KPiA+IEZpeGVzOiA2ZjdiMGJhZDg4MzkgKCJ1c2I6 IHNpbXBsaWZ5IHVzYnBvcnQgdHJpZ2dlciIpCj4gPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4g TGFtcGFydGVyIDxjaHVua2VleUBnbWFpbC5jb20+Cj4gPiAtLS0KPiA+IAo+ID4gVGhpcyB2ZXJz aW9uIG9mIHRoZSBwYXRjaCAuLi4gb2Ygd2hpY2ggd2lsbCBiZSBtYW55IG1vcmU/IQo+ID4gCj4g PiB5ZWFoLCBkZXZpY2VfYWRkX2dyb3VwcygpIGluIGZyb250IG9mIGFjdGl2YXRlKCkgd29ya3MK PiA+IGZvciB0aGUgdXNicG9ydCBkcml2ZXIgc2luY2UgaXQgZHluYW1pY2FsbHkgcmVnaXN0ZXJz Cj4gPiB0aGUgZW50cmllcyBpbiAicG9ydHMiLiBIb3dldmVyLCBpZiBhIHRyaWdnZXIgaGFzIGEK PiA+IHN0YXRpYyBsaXN0IG9mIGVudGl0aWVzIHRoaXMgY2FuIGdldCBtb3JlIGNvbXBsaWNhdGVk LAo+ID4gc2luY2UgSSB0aGluayB0aGUgc3lzZnMgZW50cmllcyB3aWxsIG5vdyBiZSBhdmFpbGFi bGUKPiA+IGJlZm9yZSB0aGUgYWN0aXZhdGUoKSBjYWxsIGV2ZW4gc3RhcnRlZCBhbmQgdGhpcyBj YW4KPiA+IGVuZCB1cCBiYWRseS4gU28sIGlzIHRoZXJlIGFueSBiZXR0ZXIgYXBwcm9hY2g/Cj4g PiBJbnRyb2R1Y2UgYSAicG9zdF9hY3RpdmF0ZSgpIiBjYWxsYmFjaz8gT3IgdXNlIHRoZSBldmVu dAo+ID4gc3lzdGVtIGFuZCBtYWtlIHVzYnBvcnQgdHJpZ2dlciBvbiB0aGUgS09CSl9DSEFOR0U/ IHVzZQo+ID4gYSAoZGVsYXllZCkgd29ya19zdHJ1Y3QgaW4gdXNicG9ydCB0byByZWdpc3RlciB0 aGUgcG9ydHMKPiA+IGF0IGEgc2xpZ2h0bHkgbGF0ZXIgdGltZT8gZXRjLi4uCj4gCj4gcG9zdF9h Y3RpdmF0ZSgpIGlzIGFuIG9wdGlvbi4KSSB3YXMgdG9sZCB0byB3YWl0IGEgYml0IG1vcmUgYmVj YXVzZSBwYXJ0cyBvZiBFdXJvcGUgYXJlCnN0aWxsIGVuam95aW5nIHRoZSBob2xpZGF5cy4gSGFw cHkgTmV3IFllYXIuIDotRCAKIAo+IE90aGVyd2lzZSwgd2l0aCB5b3VyIHBhdGNoLCBpbiBvcmRl ciB0byBwcmV2ZW50IGFjY2VzcyB0byB0aGUgc3lzZnMKPiBpbnRlcmZhY2UgYmVmb3JlIHRoZSB0 cmlnZ2VyIGlzIGluaXRpYWxpemVkLCB3ZSB3b3VsZCBoYXZlIHRvIGltcGxlbWVudAo+IGlzX3Zp c2libGUgb3AgZm9yIGVhY2ggc3RydWN0IGF0dHJpYnV0ZV9ncm91cCBpbiB0aGUgdHJpZ2dlcnMK PiB3aXRoIHN0YXRpYyBhdHRycywgYW5kIGNoZWNrIGxlZF9jZGV2LT5hY3RpdmF0ZWQgdGhlcmUK PiAoaXQgaXMgY3VycmVudGx5IHVudXNlZCBhbmQgc2NoZWR1bGVkIGZvciByZW1vdmFsLCBidXQg d2UKPiB3b3VsZCBoYXZlIHRvIHNldCBpdCBhZnRlciBjYWxsaW5nIGFjdGl2YXRlKCkgaW4gTEVE IHRyaWdnZXIgY29yZSkuCkZyb20gd2hhdCBJIGNhbiB0ZWxsIGJ5IGxvb2tpbmcgYXQgYSBsb3Qg b2YgbGVkIHRyaWdnZXJzLCBvbmx5IHRoZSB1c2Jwb3J0CmxlZCB0cmlnZ2VyIGlzIGFmZmVjdGVk LiBTbyBhbm90aGVyIHNlbnNpYmxlIG9wdGlvbiBjb3VsZCBiZSB0byBwYXJ0aWFsbHkKcmV2ZXJ0 IDZmN2IwYmFkODgzOSAoInVzYjogc2ltcGxpZnkgdXNicG9ydCB0cmlnZ2VyIikgYW5kIGxldCB0 aGUgdXNicG9ydAp0cmlnZ2VyIG1hbmFnZSBpdHMgc3lzZnMgZ3JvdXBzIGJ5IGl0c2VsZi4gKHNl ZSBiZWxvdykuIFdoYXQgZG8geW91IHRoaW5rPwoKQmVzdCByZWdhcmRzLApDaHJpc3RpYW4gTGFt cGFydGVyCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvY29yZS9sZWR0cmlnLXVzYnBvcnQuYyBi L2RyaXZlcnMvdXNiL2NvcmUvbGVkdHJpZy11c2Jwb3J0LmMKaW5kZXggZGM3ZjdmZDcxNjg0Li5j MTJhYzU2NjA2YzMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL2NvcmUvbGVkdHJpZy11c2Jwb3J0 LmMKKysrIGIvZHJpdmVycy91c2IvY29yZS9sZWR0cmlnLXVzYnBvcnQuYwpAQCAtMTE5LDExICsx MTksNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGF0dHJpYnV0ZV9ncm91cCBwb3J0c19ncm91cCA9 IHsKIAkuYXR0cnMgPSBwb3J0c19hdHRycywKIH07CiAKLXN0YXRpYyBjb25zdCBzdHJ1Y3QgYXR0 cmlidXRlX2dyb3VwICpwb3J0c19ncm91cHNbXSA9IHsKLQkmcG9ydHNfZ3JvdXAsCi0JTlVMTAot fTsKLQogLyoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKgogICogQWRkaW5n ICYgcmVtb3ZpbmcgcG9ydHMKICAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KiovCkBAIC0zMDcsNiArMzAyLDcgQEAgc3RhdGljIGludCB1c2Jwb3J0X3RyaWdfbm90aWZ5KHN0 cnVjdCBub3RpZmllcl9ibG9jayAqbmIsIHVuc2lnbmVkIGxvbmcgYWN0aW9uLAogc3RhdGljIGlu dCB1c2Jwb3J0X3RyaWdfYWN0aXZhdGUoc3RydWN0IGxlZF9jbGFzc2RldiAqbGVkX2NkZXYpCiB7 CiAJc3RydWN0IHVzYnBvcnRfdHJpZ19kYXRhICp1c2Jwb3J0X2RhdGE7CisJaW50IGVycjsKIAog CXVzYnBvcnRfZGF0YSA9IGt6YWxsb2Moc2l6ZW9mKCp1c2Jwb3J0X2RhdGEpLCBHRlBfS0VSTkVM KTsKIAlpZiAoIXVzYnBvcnRfZGF0YSkKQEAgLTMxNSw2ICszMTEsOSBAQCBzdGF0aWMgaW50IHVz YnBvcnRfdHJpZ19hY3RpdmF0ZShzdHJ1Y3QgbGVkX2NsYXNzZGV2ICpsZWRfY2RldikKIAogCS8q IExpc3Qgb2YgcG9ydHMgKi8KIAlJTklUX0xJU1RfSEVBRCgmdXNicG9ydF9kYXRhLT5wb3J0cyk7 CisJZXJyID0gc3lzZnNfY3JlYXRlX2dyb3VwKCZsZWRfY2Rldi0+ZGV2LT5rb2JqLCAmcG9ydHNf Z3JvdXApOworCWlmIChlcnIpCisJCWdvdG8gZXJyX2ZyZWU7CiAJdXNiX2Zvcl9lYWNoX2Rldih1 c2Jwb3J0X2RhdGEsIHVzYnBvcnRfdHJpZ19hZGRfdXNiX2Rldl9wb3J0cyk7CiAJdXNicG9ydF90 cmlnX3VwZGF0ZV9jb3VudCh1c2Jwb3J0X2RhdGEpOwogCkBAIC0zMjIsOCArMzIxLDExIEBAIHN0 YXRpYyBpbnQgdXNicG9ydF90cmlnX2FjdGl2YXRlKHN0cnVjdCBsZWRfY2xhc3NkZXYgKmxlZF9j ZGV2KQogCXVzYnBvcnRfZGF0YS0+bmIubm90aWZpZXJfY2FsbCA9IHVzYnBvcnRfdHJpZ19ub3Rp Znk7CiAJbGVkX3NldF90cmlnZ2VyX2RhdGEobGVkX2NkZXYsIHVzYnBvcnRfZGF0YSk7CiAJdXNi X3JlZ2lzdGVyX25vdGlmeSgmdXNicG9ydF9kYXRhLT5uYik7Ci0KIAlyZXR1cm4gMDsKKworZXJy X2ZyZWU6CisJa2ZyZWUodXNicG9ydF9kYXRhKTsKKwlyZXR1cm4gZXJyOwogfQogCiBzdGF0aWMg dm9pZCB1c2Jwb3J0X3RyaWdfZGVhY3RpdmF0ZShzdHJ1Y3QgbGVkX2NsYXNzZGV2ICpsZWRfY2Rl dikKQEAgLTMzNSw2ICszMzcsOCBAQCBzdGF0aWMgdm9pZCB1c2Jwb3J0X3RyaWdfZGVhY3RpdmF0 ZShzdHJ1Y3QgbGVkX2NsYXNzZGV2ICpsZWRfY2RldikKIAkJdXNicG9ydF90cmlnX3JlbW92ZV9w b3J0KHVzYnBvcnRfZGF0YSwgcG9ydCk7CiAJfQogCisJc3lzZnNfcmVtb3ZlX2dyb3VwKCZsZWRf Y2Rldi0+ZGV2LT5rb2JqLCAmcG9ydHNfZ3JvdXApOworCiAJdXNiX3VucmVnaXN0ZXJfbm90aWZ5 KCZ1c2Jwb3J0X2RhdGEtPm5iKTsKIAogCWtmcmVlKHVzYnBvcnRfZGF0YSk7CkBAIC0zNDQsNyAr MzQ4LDYgQEAgc3RhdGljIHN0cnVjdCBsZWRfdHJpZ2dlciB1c2Jwb3J0X2xlZF90cmlnZ2VyID0g ewogCS5uYW1lICAgICA9ICJ1c2Jwb3J0IiwKIAkuYWN0aXZhdGUgPSB1c2Jwb3J0X3RyaWdfYWN0 aXZhdGUsCiAJLmRlYWN0aXZhdGUgPSB1c2Jwb3J0X3RyaWdfZGVhY3RpdmF0ZSwKLQkuZ3JvdXBz ID0gcG9ydHNfZ3JvdXBzLAogfTsKIAogc3RhdGljIGludCBfX2luaXQgdXNicG9ydF90cmlnX2lu aXQodm9pZCkK