From: Prashanth K <quic_prashk@quicinc.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Xiu Jianfeng <xiujianfeng@huawei.com>
Cc: Pratham Pratap <quic_ppratap@quicinc.com>,
Jack Pham <quic_jackp@quicinc.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Prashanth K <quic_prashk@quicinc.com>
Subject: [PATCH] usb: gadget: u_serial: Add null pointer check in gserial_resume
Date: Wed, 8 Feb 2023 19:24:47 +0530 [thread overview]
Message-ID: <1675864487-18620-1-git-send-email-quic_prashk@quicinc.com> (raw)
Consider a case where gserial_disconnect has already cleared
gser->ioport. And if a wakeup interrupt triggers afterwards,
gserial_resume gets called, which will lead to accessing of
gserial->port and thus causing null pointer dereference.Add
a null pointer check to prevent this.
Fixes: aba3a8d01d62 (" usb: gadget: u_serial: add suspend resume callbacks")
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
---
drivers/usb/gadget/function/u_serial.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c
index 840626e..98be2b8 100644
--- a/drivers/usb/gadget/function/u_serial.c
+++ b/drivers/usb/gadget/function/u_serial.c
@@ -1428,6 +1428,9 @@ void gserial_resume(struct gserial *gser)
struct gs_port *port = gser->ioport;
unsigned long flags;
+ if (!port)
+ return;
+
spin_lock_irqsave(&port->port_lock, flags);
port->suspended = false;
if (!port->start_delayed) {
--
2.7.4
next reply other threads:[~2023-02-08 13:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 13:54 Prashanth K [this message]
2023-02-08 14:54 ` [PATCH] usb: gadget: u_serial: Add null pointer check in gserial_resume Greg Kroah-Hartman
2023-02-08 15:45 ` Prashanth K
2023-02-08 20:21 ` Alan Stern
2023-02-09 5:01 ` Prashanth K
2023-02-09 7:01 ` Greg Kroah-Hartman
2023-02-09 7:03 ` Prashanth K
2023-02-09 14:07 ` Prashanth K
2023-02-09 15:09 ` Alan Stern
2023-02-09 15:43 ` Prashanth K
2023-02-09 16:03 ` Alan Stern
2023-02-09 18:27 ` Prashanth K
2023-02-09 21:05 ` Alan Stern
2023-02-10 6:22 ` Prashanth K
2023-02-10 6:56 ` Prashanth K
2023-02-10 15:47 ` Alan Stern
2023-02-11 6:25 ` Prashanth K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1675864487-18620-1-git-send-email-quic_prashk@quicinc.com \
--to=quic_prashk@quicinc.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox