From: Rob Herring <robh@kernel.org>
To: Piyush Mehta <piyush.mehta@amd.com>
Cc: p.zabel@pengutronix.de, siva.durga.prasad.paladugu@amd.com,
michal.simek@xilinx.com, nava.manne@xilinx.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, conor+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
michal.simek@amd.com, git@amd.com
Subject: Re: [PATCH 1/2] dt-bindings: reset: convert the xlnx,zynqmp-reset.txt to yaml
Date: Wed, 07 Jun 2023 01:36:05 -0600 [thread overview]
Message-ID: <168612336438.2153757.6000360498539992409.robh@kernel.org> (raw)
In-Reply-To: <20230607065121.2265076-2-piyush.mehta@amd.com>
On Wed, 07 Jun 2023 12:21:20 +0530, Piyush Mehta wrote:
> Convert the binding to DT schema format. It also updates the
> reset-controller description.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
> ---
> Note:
> The 1/2 patch introduced a warning related to the dt binding check,
> which was subsequently fixed in the 2/2 patch. This warning is a
> conversion warning due to a dependency on firmware dt binding.
>
> Warning:
> DTC_CHK Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.example.dtb
> /scratch/piyushm/torvalds/linux/Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.example.dtb: zynqmp-firmware: 'reset-controller' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: /scratch/piyushm/torvalds/linux/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>
> Please suggest to me, if it's fine to make a single patch instead of the
> separate patch 1/2 and 2/2.
> ---
> .../bindings/reset/xlnx,zynqmp-reset.txt | 55 ---------------
> .../bindings/reset/xlnx,zynqmp-reset.yaml | 67 +++++++++++++++++++
> 2 files changed, 67 insertions(+), 55 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.txt
> create mode 100644 Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.example.dtb: zynqmp-firmware: 'reset-controller' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230607065121.2265076-2-piyush.mehta@amd.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-06-07 7:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 6:51 [PATCH 0/2] dt-bindings: reset: convert the xlnx,zynqmp-reset.txt to yaml Piyush Mehta
2023-06-07 6:51 ` [PATCH 1/2] " Piyush Mehta
2023-06-07 7:36 ` Rob Herring [this message]
2023-06-08 10:55 ` Mehta, Piyush
2023-06-08 11:29 ` Krzysztof Kozlowski
2023-06-08 11:34 ` Michal Simek
2023-06-08 11:39 ` Krzysztof Kozlowski
2023-06-07 6:51 ` [PATCH 2/2] dt-bindings: firmware: add reset-controller property Piyush Mehta
2023-06-07 7:36 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168612336438.2153757.6000360498539992409.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=p.zabel@pengutronix.de \
--cc=piyush.mehta@amd.com \
--cc=robh+dt@kernel.org \
--cc=siva.durga.prasad.paladugu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox