From: Rob Herring <robh@kernel.org>
To: Praveenkumar I <quic_ipkumar@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
kishon@kernel.org, robert.marko@sartura.hr, robh+dt@kernel.org,
geert+renesas@glider.be, peng.fan@nxp.com,
konrad.dybcio@linaro.org, devicetree@vger.kernel.org,
linux-phy@lists.infradead.org, will@kernel.org,
conor+dt@kernel.org, p.zabel@pengutronix.de,
quic_varada@quicinc.com, vkoul@kernel.org,
nfraprado@collabora.com, krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, quic_wcheng@quicinc.com,
rafal@milecki.pl, gregkh@linuxfoundation.org,
luka.perkov@sartura.hr, andersson@kernel.org, arnd@arndb.de,
linux-usb@vger.kernel.org, agross@kernel.org,
catalin.marinas@arm.com
Subject: Re: [PATCH 4/9] dt-bindings: phy: qcom,uniphy: Add ipq5332 USB3 SS UNIPHY
Date: Tue, 29 Aug 2023 09:35:58 -0500 [thread overview]
Message-ID: <169331975886.2142011.7345682428392154402.robh@kernel.org> (raw)
In-Reply-To: <20230829135818.2219438-5-quic_ipkumar@quicinc.com>
On Tue, 29 Aug 2023 19:28:13 +0530, Praveenkumar I wrote:
> Add ipq5332 USB3 SS UNIPHY support.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> ---
> .../devicetree/bindings/phy/qcom,uniphy.yaml | 117 +++++++++++++++++-
> 1 file changed, 114 insertions(+), 3 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
In file included from Documentation/devicetree/bindings/phy/qcom,uniphy.example.dts:45:
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:19: warning: "GCC_BLSP1_AHB_CLK" redefined
19 | #define GCC_BLSP1_AHB_CLK 10
|
In file included from Documentation/devicetree/bindings/phy/qcom,uniphy.example.dts:18:
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:40: note: this is the location of the previous definition
40 | #define GCC_BLSP1_AHB_CLK 21
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:20: warning: "GCC_BLSP1_QUP1_I2C_APPS_CLK" redefined
20 | #define GCC_BLSP1_QUP1_I2C_APPS_CLK 11
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:41: note: this is the location of the previous definition
41 | #define GCC_BLSP1_QUP1_I2C_APPS_CLK 22
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:21: warning: "GCC_BLSP1_QUP1_SPI_APPS_CLK" redefined
21 | #define GCC_BLSP1_QUP1_SPI_APPS_CLK 12
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:42: note: this is the location of the previous definition
42 | #define GCC_BLSP1_QUP1_SPI_APPS_CLK 23
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:23: warning: "GCC_BLSP1_QUP2_I2C_APPS_CLK" redefined
23 | #define GCC_BLSP1_QUP2_I2C_APPS_CLK 14
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:43: note: this is the location of the previous definition
43 | #define GCC_BLSP1_QUP2_I2C_APPS_CLK 24
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:24: warning: "GCC_BLSP1_QUP2_SPI_APPS_CLK" redefined
24 | #define GCC_BLSP1_QUP2_SPI_APPS_CLK 15
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:44: note: this is the location of the previous definition
44 | #define GCC_BLSP1_QUP2_SPI_APPS_CLK 25
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:30: warning: "GCC_BLSP1_UART1_APPS_CLK" redefined
30 | #define GCC_BLSP1_UART1_APPS_CLK 21
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:45: note: this is the location of the previous definition
45 | #define GCC_BLSP1_UART1_APPS_CLK 26
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:32: warning: "GCC_BLSP1_UART2_APPS_CLK" redefined
32 | #define GCC_BLSP1_UART2_APPS_CLK 23
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:46: note: this is the location of the previous definition
46 | #define GCC_BLSP1_UART2_APPS_CLK 27
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:42: warning: "GCC_GP1_CLK" redefined
42 | #define GCC_GP1_CLK 33
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:48: note: this is the location of the previous definition
48 | #define GCC_GP1_CLK 29
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:44: warning: "GCC_GP2_CLK" redefined
44 | #define GCC_GP2_CLK 35
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:49: note: this is the location of the previous definition
49 | #define GCC_GP2_CLK 30
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:98: warning: "GCC_PRNG_AHB_CLK" redefined
98 | #define GCC_PRNG_AHB_CLK 89
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:62: note: this is the location of the previous definition
62 | #define GCC_PRNG_AHB_CLK 43
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:117: warning: "GCC_QPIC_AHB_CLK" redefined
117 | #define GCC_QPIC_AHB_CLK 108
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:63: note: this is the location of the previous definition
63 | #define GCC_QPIC_AHB_CLK 44
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:118: warning: "GCC_QPIC_CLK" redefined
118 | #define GCC_QPIC_CLK 109
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:64: note: this is the location of the previous definition
64 | #define GCC_QPIC_CLK 45
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:122: warning: "GCC_SDCC1_AHB_CLK" redefined
122 | #define GCC_SDCC1_AHB_CLK 113
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:65: note: this is the location of the previous definition
65 | #define GCC_SDCC1_AHB_CLK 46
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:123: warning: "GCC_SDCC1_APPS_CLK" redefined
123 | #define GCC_SDCC1_APPS_CLK 114
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:66: note: this is the location of the previous definition
66 | #define GCC_SDCC1_APPS_CLK 47
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:191: warning: "GCC_BLSP1_BCR" redefined
191 | #define GCC_BLSP1_BCR 8
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:126: note: this is the location of the previous definition
126 | #define GCC_BLSP1_BCR 30
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:192: warning: "GCC_BLSP1_QUP1_BCR" redefined
192 | #define GCC_BLSP1_QUP1_BCR 9
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:127: note: this is the location of the previous definition
127 | #define GCC_BLSP1_QUP1_BCR 31
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:195: warning: "GCC_BLSP1_QUP2_BCR" redefined
195 | #define GCC_BLSP1_QUP2_BCR 12
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:129: note: this is the location of the previous definition
129 | #define GCC_BLSP1_QUP2_BCR 33
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:203: warning: "GCC_BLSP1_UART1_BCR" redefined
203 | #define GCC_BLSP1_UART1_BCR 20
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:128: note: this is the location of the previous definition
128 | #define GCC_BLSP1_UART1_BCR 32
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:205: warning: "GCC_BLSP1_UART2_BCR" redefined
205 | #define GCC_BLSP1_UART2_BCR 22
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:130: note: this is the location of the previous definition
130 | #define GCC_BLSP1_UART2_BCR 34
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:260: warning: "GCC_PCNOC_BCR" redefined
260 | #define GCC_PCNOC_BCR 77
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:148: note: this is the location of the previous definition
148 | #define GCC_PCNOC_BCR 52
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:263: warning: "GCC_PRNG_BCR" redefined
263 | #define GCC_PRNG_BCR 80
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:135: note: this is the location of the previous definition
135 | #define GCC_PRNG_BCR 39
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:274: warning: "GCC_QDSS_BCR" redefined
274 | #define GCC_QDSS_BCR 91
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:165: note: this is the location of the previous definition
165 | #define GCC_QDSS_BCR 69
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:290: warning: "GCC_QPIC_BCR" redefined
290 | #define GCC_QPIC_BCR 107
|
./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,gcc-ipq4019.h:141: note: this is the location of the previous definition
141 | #define GCC_QPIC_BCR 45
|
doc reference errors (make refcheckdocs):
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml
MAINTAINERS: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230829135818.2219438-5-quic_ipkumar@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-08-29 14:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 13:58 [PATCH 0/9] Enable USB3 for IPQ5332 Praveenkumar I
2023-08-29 13:58 ` [PATCH 1/9] dt-bindings: phy: qcom,uniphy: Rename ipq4019 usb PHY to UNIPHY Praveenkumar I
2023-08-29 14:19 ` Dmitry Baryshkov
2023-08-31 11:53 ` Praveenkumar I
2023-08-31 12:17 ` Dmitry Baryshkov
2023-08-31 12:29 ` Praveenkumar I
2023-08-31 12:34 ` Dmitry Baryshkov
2023-08-31 12:50 ` Praveenkumar I
2023-08-29 16:53 ` Krzysztof Kozlowski
2023-08-29 13:58 ` [PATCH 2/9] phy: qcom: uniphy: Rename ipq4019 USB phy driver to UNIPHY driver Praveenkumar I
2023-08-29 16:55 ` Krzysztof Kozlowski
2023-08-31 13:08 ` Praveenkumar I
2023-08-29 13:58 ` [PATCH 3/9] phy: qcom: uniphy: Update UNIPHY driver to be a common driver Praveenkumar I
2023-08-29 14:37 ` Dmitry Baryshkov
2023-08-31 12:05 ` Praveenkumar I
2023-08-29 16:57 ` Krzysztof Kozlowski
2023-08-29 13:58 ` [PATCH 4/9] dt-bindings: phy: qcom,uniphy: Add ipq5332 USB3 SS UNIPHY Praveenkumar I
2023-08-29 14:16 ` Dmitry Baryshkov
2023-08-29 14:35 ` Rob Herring [this message]
2023-08-29 17:08 ` Krzysztof Kozlowski
2023-08-29 18:46 ` Dmitry Baryshkov
2023-08-29 16:16 ` Rob Herring
2023-08-29 16:59 ` Krzysztof Kozlowski
2023-08-29 13:58 ` [PATCH 5/9] dt-bindings: usb: dwc3: Update IPQ5332 compatible Praveenkumar I
2023-08-29 17:01 ` Krzysztof Kozlowski
2023-08-29 13:58 ` [PATCH 6/9] arm64: dts: qcom: ipq5332: Add USB3 related nodes Praveenkumar I
2023-08-29 14:46 ` Dmitry Baryshkov
2023-08-29 17:02 ` Krzysztof Kozlowski
2023-08-29 13:58 ` [PATCH 7/9] arm64: dts: qcom: ipq5332: Enable USB SS UNIPHY Praveenkumar I
2023-08-29 17:03 ` Krzysztof Kozlowski
2023-08-29 13:58 ` [PATCH 8/9] phy: qcom: uniphy: Add ipq5332 USB UNIPHY support Praveenkumar I
2023-08-29 14:45 ` Dmitry Baryshkov
[not found] ` <2ff8ef8e-c7d8-4a02-a764-ef2a3f83e87c@quicinc.com>
2023-08-31 12:21 ` Dmitry Baryshkov
2023-08-29 13:58 ` [PATCH 9/9] arm64: defconfig: Enable UNIPHY driver Praveenkumar I
2023-08-29 17:06 ` Krzysztof Kozlowski
2023-08-29 17:07 ` [PATCH 0/9] Enable USB3 for IPQ5332 Krzysztof Kozlowski
2023-08-31 12:14 ` Praveenkumar I
2023-08-31 12:15 ` Praveenkumar I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169331975886.2142011.7345682428392154402.robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=rafal@milecki.pl \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox