public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Ze Huang <huangze@whut.edu.cn>
Cc: Conor Dooley <conor+dt@kernel.org>,
	 Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	linux-usb@vger.kernel.org,  devicetree@vger.kernel.org,
	Yixun Lan <dlan@gentoo.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Alexandre Ghiti <alex@ghiti.fr>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	 Kishon Vijay Abraham I <kishon@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,  Albert Ou <aou@eecs.berkeley.edu>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	 linux-phy@lists.infradead.org, linux-riscv@lists.infradead.org,
	 spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] dt-bindings: usb: add SpacemiT K1 DWC3 glue
Date: Mon, 07 Apr 2025 08:51:10 -0500	[thread overview]
Message-ID: <174403387085.2155711.16403180293126338183.robh@kernel.org> (raw)
In-Reply-To: <20250407-b4-k1-usb3-v3-2-v1-3-bf0bcc41c9ba@whut.edu.cn>


On Mon, 07 Apr 2025 20:38:48 +0800, Ze Huang wrote:
> Add support for SpacemiT DWC3 glue driver, which manages interrupt,
> reset and clock resource.
> 
> Signed-off-by: Ze Huang <huangze@whut.edu.cn>
> ---
>  .../devicetree/bindings/usb/spacemit,k1-dwc3.yaml  | 78 ++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/spacemit,k1-dwc3.example.dtb: usb@c0a00000 (spacemit,k1-dwc3): '#address-cells', '#size-cells' do not match any of the regexes: '^usb@', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/usb/spacemit,k1-dwc3.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/spacemit,k1-dwc3.example.dtb: usb@c0a00000 (spacemit,k1-dwc3): usb@0:reg: [[0, 0], [0, 65536]] is too long
	from schema $id: http://devicetree.org/schemas/usb/spacemit,k1-dwc3.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/spacemit,k1-dwc3.example.dtb: usb@0 (snps,dwc3): reg: [[0, 0], [0, 65536]] is too long
	from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250407-b4-k1-usb3-v3-2-v1-3-bf0bcc41c9ba@whut.edu.cn

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2025-04-07 13:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 12:38 [PATCH 0/7] Add USB3.0 PHY and host controller support for SpacemiT K1 SoC Ze Huang
2025-04-07 12:38 ` [PATCH 1/7] dt-bindings: phy: spacemit: add K1 USB2 PHY Ze Huang
2025-04-07 13:18   ` Krzysztof Kozlowski
2025-04-09  8:01     ` Ze Huang
2025-04-10 20:53   ` Rob Herring (Arm)
2025-04-07 12:38 ` [PATCH 2/7] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY Ze Huang
2025-04-07 13:20   ` Krzysztof Kozlowski
2025-04-09  8:05     ` Ze Huang
2025-04-07 12:38 ` [PATCH 3/7] dt-bindings: usb: add SpacemiT K1 DWC3 glue Ze Huang
2025-04-07 13:22   ` Krzysztof Kozlowski
2025-04-09  8:16     ` Ze Huang
2025-04-09 10:08       ` Krzysztof Kozlowski
2025-04-07 13:51   ` Rob Herring (Arm) [this message]
2025-04-09  8:30     ` Ze Huang
2025-04-07 12:38 ` [PATCH 4/7] phy: spacemit: support K1 USB2.0 PHY controller Ze Huang
2025-04-07 13:25   ` Krzysztof Kozlowski
2025-04-09  8:18     ` Ze Huang
2025-04-07 12:38 ` [PATCH 5/7] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY Ze Huang
2025-04-07 13:28   ` Krzysztof Kozlowski
2025-04-09  9:43     ` Ze Huang
2025-04-09 10:10       ` Krzysztof Kozlowski
2025-04-09 11:38   ` Pan Junzhong
2025-04-09 11:42     ` Ze Huang
2025-04-07 12:38 ` [PATCH 6/7] usb: dwc3: add spacemit dwc3 glue layer driver Ze Huang
2025-04-09 22:34   ` Thinh Nguyen
2025-04-10  1:34     ` Ze Huang
2025-04-07 12:38 ` [PATCH 7/7] riscv: dts: spacemit: add usb3.0 support for K1 Ze Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174403387085.2155711.16403180293126338183.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=huangze@whut.edu.cn \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=spacemit@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox