Re: [PATCH v2 1/1] dt-bindings: usb: convert lpc32xx-udc.txt to yaml format

Frank Li
2025-06-29T15:56:03Z

On Sat, Jun 28, 2025 at 03:57:44AM +0300, Vladimir Zapolskiy wrote:
> Hi Frank.
>
> On 6/26/25 00:43, Frank Li wrote:
> > Convert lpc32xx-udc.txt to yaml format.
> >
> > Additional changes:
> > - add clocks and put it into required list to match existed lp32xx.dtsi.
> > - remove usb-transceiver@2c at examples.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
>
> Thank you a lot for doing this massive conversion work of NXP LPC
> device tree bindings, I would appreciate, if you put me to CC for
> all such changes.
>
> While you do one-to-one conversion, you do bring a lot of errors,
> because the .txt descriptions are broken.
>
> Please always reference to arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> and arch/arm/boot/dts/nxp/lpc/lpc18xx.dtsi, that's the correct
> version of NXP LPC DT bindings, otherwise something important
> can be missed by occasion.

Okay, I dependent on CHECK_DTBS but omit the factor the node with status
="disabled" will skip check.

Frank

>
> <snip>
>
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/lpc32xx-clock.h>
> > +
> > + usbd@31020000 {
> > + compatible = "nxp,lpc3220-udc";
> > + reg = <0x31020000 0x300>;
> > + interrupt-parent = <&mic>;
>
> interrupt-parent = <sic1>;
>
> > + interrupts = <0x3d 0>, <0x3e 0>, <0x3c 0>, <0x3a 0>;
>
> Should subscribe 32 and correct the type:
>
> interrupts = <29 4>, <30 4>, <28 4>, <26 8>;
>
> > + clocks = <&usbclk LPC32XX_USB_CLK_DEVICE>;
> > + transceiver = <&isp1301>;
> > + };
>
> --
> Best wishes,
> Vladimir