* [PATCH net] usb: net: sierra: check for no status endpoint
@ 2025-07-14 11:12 Oliver Neukum
2025-07-15 23:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2025-07-14 11:12 UTC (permalink / raw)
To: andrew+netdev, davem, edumazet, kuba, pabeni, linux-usb, netdev
Cc: Oliver Neukum, syzbot+3f89ec3d1d0842e95d50
The driver checks for having three endpoints and
having bulk in and out endpoints, but not that
the third endpoint is interrupt input.
Rectify the omission.
Reported-by: syzbot+3f89ec3d1d0842e95d50@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/linux-usb/686d5a9f.050a0220.1ffab7.0017.GAE@google.com/
Tested-by: syzbot+3f89ec3d1d0842e95d50@syzkaller.appspotmail.com
Fixes: eb4fd8cd355c8 ("net/usb: add sierra_net.c driver")
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/net/usb/sierra_net.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c
index c30ca415d1d3..36c73db44f77 100644
--- a/drivers/net/usb/sierra_net.c
+++ b/drivers/net/usb/sierra_net.c
@@ -689,6 +689,10 @@ static int sierra_net_bind(struct usbnet *dev, struct usb_interface *intf)
status);
return -ENODEV;
}
+ if (!dev->status) {
+ dev_err(&dev->udev->dev, "No status endpoint found");
+ return -ENODEV;
+ }
/* Initialize sierra private data */
priv = kzalloc(sizeof *priv, GFP_KERNEL);
if (!priv)
--
2.50.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] usb: net: sierra: check for no status endpoint
2025-07-14 11:12 [PATCH net] usb: net: sierra: check for no status endpoint Oliver Neukum
@ 2025-07-15 23:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-07-15 23:10 UTC (permalink / raw)
To: Oliver Neukum
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, linux-usb, netdev,
syzbot+3f89ec3d1d0842e95d50
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 14 Jul 2025 13:12:56 +0200 you wrote:
> The driver checks for having three endpoints and
> having bulk in and out endpoints, but not that
> the third endpoint is interrupt input.
> Rectify the omission.
>
> Reported-by: syzbot+3f89ec3d1d0842e95d50@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/linux-usb/686d5a9f.050a0220.1ffab7.0017.GAE@google.com/
> Tested-by: syzbot+3f89ec3d1d0842e95d50@syzkaller.appspotmail.com
> Fixes: eb4fd8cd355c8 ("net/usb: add sierra_net.c driver")
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
>
> [...]
Here is the summary with links:
- [net] usb: net: sierra: check for no status endpoint
https://git.kernel.org/netdev/net/c/4c4ca3c46167
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-15 23:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-14 11:12 [PATCH net] usb: net: sierra: check for no status endpoint Oliver Neukum
2025-07-15 23:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).